You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@weex.apache.org by GitBox <gi...@apache.org> on 2018/11/17 08:31:41 UTC

[GitHub] JeromeTan1997 opened a new pull request #1771: [iOS] fix infinite recursion caused by affine type

JeromeTan1997 opened a new pull request #1771:  [iOS] fix infinite recursion caused by affine type
URL: https://github.com/apache/incubator-weex/pull/1771
 
 
   When registering a subcomponent of base component, take `list` for example, the key-value pair of `"list": "list"` is appended to `affineTypes_` by `RenderCreator::RegisterAffineType(const std::string &type, const std::string& asType)`. This causes `RenderCreator::IsAffineType(const std::string &type, const std::string& asType)` to recur infinitely
   
   CheckList:
   
   **if** *isBugFix* **:**
   
     * [x] Make sure that you add at least one unit test for the bug which you had fixed.
   
   **elif** *isNewFeature* **:**
   
     * [ ] Update API docs for the component.
     * [ ] Update/Add demo to demonstrate new feature.
     * [ ] Update test scripts for the feature.
     * [ ] Add unit tests for the feature.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services