[GitHub] [trafficserver] ezelkow1 commented on a diff in pull request #9590: Adds a new hash_url directive to strategies

["ezelkow1 (via GitHub)" <gi...@apache.org>]

ezelkow1 commented on code in PR #9590:
URL: https://github.com/apache/trafficserver/pull/9590#discussion_r1162133468


##########
doc/admin-guide/files/strategies.yaml.en.rst:
##########
@@ -182,9 +182,18 @@ Each **strategy** in the list may using the following parameters:
    #. **path**: (**default**) Creates a hash over the path portion of the request URL.
    #. **path+query**: Same as **path** but adds the **query string** in the request URL.
    #. **path+fragment**: Same as **path** but adds the fragment portion of the URL.
-   #. **cache_key**: Uses the hash key from the **cachekey** plugin.  defaults to **path** if the **cachekey** plugin is not configured on the **remap**.
+   #. **cache_key**: Deprecated, use the URL designation instead.

Review Comment:
   Since we are deprecating/changing how some of this works it would be good if there was a deprecation note on what settings to use so that this can act how it used to pre-changes. Just helps with transition



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org