You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by "mosche (via GitHub)" <gi...@apache.org> on 2023/08/02 09:55:36 UTC
[GitHub] [beam] mosche opened a new pull request, #27800: [AWS] Adjust interface of SqsIO.writeBatches to make entryMapper optional
mosche opened a new pull request, #27800:
URL: https://github.com/apache/beam/pull/27800
The purpose of this PR is to polish the interfaces of `SqsIO.writeBatches()` before the next release cut (Aug 9th).
- `EntryBuilder` was renamed to `EntryMapper` (and there's an additional `EntryMapper.Builder` for convenience)
- `EntryMapper` became optional, if possible a mapper is automatically built leveraging schemas and toRow / fromRow functions.
- Last, `SqsIO.write` is deprecated and implemented by means of `SqsIO.writeBatches()` using batch size 1.
------------------------
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
- [ ] Mention the appropriate issue in your description (for example: `addresses #123`), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment `fixes #<ISSUE NUMBER>` instead.
- [ ] Update `CHANGES.md` with noteworthy changes.
- [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
See the [Contributor Guide](https://beam.apache.org/contribute) for more tips on [how to make review process smoother](https://beam.apache.org/contribute/get-started-contributing/#make-the-reviewers-job-easier).
To check the build health, please visit [https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md](https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md)
GitHub Actions Tests Status (on master branch)
------------------------------------------------------------------------------------------------
[](https://github.com/apache/beam/actions?query=workflow%3A%22Build+python+source+distribution+and+wheels%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Python+Tests%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Java+Tests%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Go+tests%22+branch%3Amaster+event%3Aschedule)
See [CI.md](https://github.com/apache/beam/blob/master/CI.md) for more information about GitHub Actions CI or the [workflows README](https://github.com/apache/beam/blob/master/.github/workflows/README.md) to see a list of phrases to trigger workflows.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] github-actions[bot] commented on pull request #27800: [AWS] Adjust interface of SqsIO.writeBatches to make entryMapper optional
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #27800:
URL: https://github.com/apache/beam/pull/27800#issuecomment-1661913170
Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] mosche commented on pull request #27800: [AWS] Adjust interface of SqsIO.writeBatches to make entryMapper optional
Posted by "mosche (via GitHub)" <gi...@apache.org>.
mosche commented on PR #27800:
URL: https://github.com/apache/beam/pull/27800#issuecomment-1668016082
> Should we update CHANGES on this?
Do you mean mentioning the new feature `writeBatches`? Will do in another PR tomorrow 👍
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] mosche merged pull request #27800: [AWS] Adjust interface of SqsIO.writeBatches to make entryMapper optional
Posted by "mosche (via GitHub)" <gi...@apache.org>.
mosche merged PR #27800:
URL: https://github.com/apache/beam/pull/27800
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] mosche commented on pull request #27800: [AWS] Adjust interface of SqsIO.writeBatches to make entryMapper optional
Posted by "mosche (via GitHub)" <gi...@apache.org>.
mosche commented on PR #27800:
URL: https://github.com/apache/beam/pull/27800#issuecomment-1661911531
R: @aromanenko-dev
R: @psolomin
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org