You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@thrift.apache.org by dr...@apache.org on 2009/09/03 00:15:55 UTC

svn commit: r810713 - /incubator/thrift/trunk/compiler/cpp/src/thrifty.yy

Author: dreiss
Date: Wed Sep  2 22:15:55 2009
New Revision: 810713

URL: http://svn.apache.org/viewvc?rev=810713&view=rev
Log:
THRIFT-575. Allow required fields in function parameters

r665255 was a bit too aggressive.  "optional" was causing confusion,
but there doesn't seem to be any harm in allowing "required".

Modified:
    incubator/thrift/trunk/compiler/cpp/src/thrifty.yy

Modified: incubator/thrift/trunk/compiler/cpp/src/thrifty.yy
URL: http://svn.apache.org/viewvc/incubator/thrift/trunk/compiler/cpp/src/thrifty.yy?rev=810713&r1=810712&r2=810713&view=diff
==============================================================================
--- incubator/thrift/trunk/compiler/cpp/src/thrifty.yy (original)
+++ incubator/thrift/trunk/compiler/cpp/src/thrifty.yy Wed Sep  2 22:15:55 2009
@@ -902,14 +902,7 @@
 FieldRequiredness:
   tok_required
     {
-      if (g_arglist) {
-        if (g_parse_mode == PROGRAM) {
-          pwarning(1, "required keyword is ignored in argument lists.\n");
-        }
-        $$ = t_field::T_OPT_IN_REQ_OUT;
-      } else {
-        $$ = t_field::T_REQUIRED;
-      }
+      $$ = t_field::T_REQUIRED;
     }
 | tok_optional
     {