[GitHub] [drill] luocooong commented on pull request #2192: DRILL-7828: Refactor Pcap and Pcapng format plugin

[GitBox <gi...@apache.org>]

luocooong commented on pull request #2192:
URL: https://github.com/apache/drill/pull/2192#issuecomment-811878482


   > One other thought on the compatibility issue. We can perhaps fudge it here as we discussed. Perhaps it make sense to fix it correctly:
   > 
   > * Store a version number in the "persistent store" (ZK) each time we write to the store. This can't be a product version, it must be a persistent store format version. (Why? So you can change things in the SNAPSHOT release.)
   > * On each startup, check the persistent store version. If it is less than the current version, run an upgrade process. In particular, invoke a `versionxToy` conversion for each 'x' from the current store version to the current software version.
   > * In each conversion, look for changed configs and "do the right thing." For this PR, it would mean changing the plugin name and rewriting one of them ("pcap-ng" maybe) as needed. In some cases, it might mean deleting an unsupported plugin. Etc.
   > 
   > The wise thing would be to log the original JSON and any changes, so if things go wrong (and they will), there is a way to recover.
   
   Nice Idea. Versioning + Upgrade from previous + Recovery mode


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org