You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@apex.apache.org by vrozov <gi...@git.apache.org> on 2016/02/10 02:38:09 UTC
[GitHub] incubator-apex-core pull request: APEXCORE-337 update number of ch...
GitHub user vrozov opened a pull request:
https://github.com/apache/incubator-apex-core/pull/224
APEXCORE-337 update number of checkstyle violations and upgrade checkstyle to 6.15
@chandnisingh Please review and merge
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/vrozov/incubator-apex-core APEXCORE-337
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-apex-core/pull/224.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #224
----
commit 8856939b3007e4a7d47cb566e26da046daa87479
Author: Vlad Rozov <v....@datatorrent.com>
Date: 2016-02-10T01:35:05Z
APEXCORE-337 update number of checkstyle violations and upgrade checkstyle to 6.15
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-apex-core pull request: APEXCORE-337 update number of ch...
Posted by vrozov <gi...@git.apache.org>.
Github user vrozov commented on a diff in the pull request:
https://github.com/apache/incubator-apex-core/pull/224#discussion_r52414874
--- Diff: pom.xml ---
@@ -328,7 +328,7 @@
<dependency>
<groupId>com.puppycrawl.tools</groupId>
<artifactId>checkstyle</artifactId>
- <version>6.14</version>
+ <version>6.15</version>
--- End diff --
http://checkstyle.sourceforge.net/releasenotes.html
Upgrade is optional, there was no change in the number of violations detected by the old and upgraded version.
I use IntelliJ checkstyle plugin and this plugin was upgraded to 6.15 checkstyle version. It is better to keep them in sync.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-apex-core pull request: APEXCORE-337 update number of ch...
Posted by gauravgopi123 <gi...@git.apache.org>.
Github user gauravgopi123 commented on the pull request:
https://github.com/apache/incubator-apex-core/pull/224#issuecomment-182201033
Although it is merged but I don't think the reason is good enough to upgrade the version. Please have have details in Jira (not one liners) and take it up on dev before sending PR.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-apex-core pull request: APEXCORE-337 update number of ch...
Posted by vrozov <gi...@git.apache.org>.
Github user vrozov commented on the pull request:
https://github.com/apache/incubator-apex-core/pull/224#issuecomment-183580278
The checkstyle version upgrade is transparent for other developers and does not require any reconfiguration, so I don't see any reason not to upgrade it. Additionally, compared to, for example, maven plugins, where unless we face a specific bug in the plugin we don't need to upgrade it, checkstyle is used to analyze a new code, not the existing code where we already know how may violations exists.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-apex-core pull request: APEXCORE-337 update number of ch...
Posted by tweise <gi...@git.apache.org>.
Github user tweise commented on a diff in the pull request:
https://github.com/apache/incubator-apex-core/pull/224#discussion_r52413620
--- Diff: pom.xml ---
@@ -328,7 +328,7 @@
<dependency>
<groupId>com.puppycrawl.tools</groupId>
<artifactId>checkstyle</artifactId>
- <version>6.14</version>
+ <version>6.15</version>
--- End diff --
+1 would be good to know what issues the update fixes, if any
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-apex-core pull request: APEXCORE-337 update number of ch...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-apex-core/pull/224
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-apex-core pull request: APEXCORE-337 update number of ch...
Posted by gauravgopi123 <gi...@git.apache.org>.
Github user gauravgopi123 commented on a diff in the pull request:
https://github.com/apache/incubator-apex-core/pull/224#discussion_r52406007
--- Diff: pom.xml ---
@@ -328,7 +328,7 @@
<dependency>
<groupId>com.puppycrawl.tools</groupId>
<artifactId>checkstyle</artifactId>
- <version>6.14</version>
+ <version>6.15</version>
--- End diff --
@vrozov : Why is this upgrade required? I don't see anything in Jira
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---