You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@livy.apache.org by arunmahadevan <gi...@git.apache.org> on 2018/10/08 20:14:59 UTC
[GitHub] incubator-livy pull request #120: Upgrade jetty minor version
GitHub user arunmahadevan opened a pull request:
https://github.com/apache/incubator-livy/pull/120
Upgrade jetty minor version
## What changes were proposed in this pull request?
Upgrade the jetty minor version to a more recent version that has fixes for a few security issues.
## How was this patch tested?
Existing unit tests
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/arunmahadevan/incubator-livy jetty-upgrade
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-livy/pull/120.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #120
----
commit 0dfa20d78b1c02fcf64cb2143ea46b92e0b79c1f
Author: Arun Mahadevan <ar...@...>
Date: 2018-10-08T20:11:44Z
Upgrade jetty minor version
----
---
[GitHub] incubator-livy pull request #120: [LIVY-526] Upgrade jetty version
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-livy/pull/120
---
[GitHub] incubator-livy issue #120: [LIVY-526] Upgrade jetty version
Posted by arunmahadevan <gi...@git.apache.org>.
Github user arunmahadevan commented on the issue:
https://github.com/apache/incubator-livy/pull/120
@mgaido91 fixed the unit test failure and created a JIRA.
---
[GitHub] incubator-livy issue #120: [LIVY-526] Upgrade jetty version
Posted by arunmahadevan <gi...@git.apache.org>.
Github user arunmahadevan commented on the issue:
https://github.com/apache/incubator-livy/pull/120
thanks @mgaido91 for reviewing.
@vanzin @jerryshao , can you take it forward?
---
[GitHub] incubator-livy issue #120: [LIVY-526] Upgrade jetty version
Posted by mgaido91 <gi...@git.apache.org>.
Github user mgaido91 commented on the issue:
https://github.com/apache/incubator-livy/pull/120
thanks. LGTM
---
[GitHub] incubator-livy issue #120: Upgrade jetty version
Posted by mgaido91 <gi...@git.apache.org>.
Github user mgaido91 commented on the issue:
https://github.com/apache/incubator-livy/pull/120
@arunmahadevan there is a consistent UT failure. We need to address it. I think we should also have a JIRA (to be referenced here) proposing the Jetty version upgrade. Thanks.
---
[GitHub] incubator-livy issue #120: [LIVY-526] Upgrade jetty version
Posted by codecov-io <gi...@git.apache.org>.
Github user codecov-io commented on the issue:
https://github.com/apache/incubator-livy/pull/120
# [Codecov](https://codecov.io/gh/apache/incubator-livy/pull/120?src=pr&el=h1) Report
> Merging [#120](https://codecov.io/gh/apache/incubator-livy/pull/120?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-livy/commit/d87a34872069107329b67940d193c2962cf2026d?src=pr&el=desc) will **increase** coverage by `0.01%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-livy/pull/120?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #120 +/- ##
============================================
+ Coverage 70.94% 70.96% +0.01%
Complexity 922 922
============================================
Files 100 100
Lines 5500 5500
Branches 828 828
============================================
+ Hits 3902 3903 +1
- Misses 1062 1063 +1
+ Partials 536 534 -2
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-livy/pull/120?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...in/java/org/apache/livy/rsc/driver/JobWrapper.java](https://codecov.io/gh/apache/incubator-livy/pull/120/diff?src=pr&el=tree#diff-cnNjL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9saXZ5L3JzYy9kcml2ZXIvSm9iV3JhcHBlci5qYXZh) | `80% <0%> (ø)` | `7% <0%> (-1%)` | :arrow_down: |
| [...ain/java/org/apache/livy/rsc/driver/RSCDriver.java](https://codecov.io/gh/apache/incubator-livy/pull/120/diff?src=pr&el=tree#diff-cnNjL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9saXZ5L3JzYy9kcml2ZXIvUlNDRHJpdmVyLmphdmE=) | `77.96% <0%> (ø)` | `41% <0%> (+1%)` | :arrow_up: |
| [...c/main/scala/org/apache/livy/repl/ReplDriver.scala](https://codecov.io/gh/apache/incubator-livy/pull/120/diff?src=pr&el=tree#diff-cmVwbC9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2xpdnkvcmVwbC9SZXBsRHJpdmVyLnNjYWxh) | `33.33% <0%> (+2.56%)` | `7% <0%> (ø)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-livy/pull/120?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-livy/pull/120?src=pr&el=footer). Last update [d87a348...b100d85](https://codecov.io/gh/apache/incubator-livy/pull/120?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
---
[GitHub] incubator-livy issue #120: [LIVY-526] Upgrade jetty version
Posted by jerryshao <gi...@git.apache.org>.
Github user jerryshao commented on the issue:
https://github.com/apache/incubator-livy/pull/120
OK, LGMT. Merging to master.
---
[GitHub] incubator-livy issue #120: Upgrade jetty version
Posted by arunmahadevan <gi...@git.apache.org>.
Github user arunmahadevan commented on the issue:
https://github.com/apache/incubator-livy/pull/120
cc @mgaido91 @vanzin
---