You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2021/04/01 09:57:53 UTC
[GitHub] [arrow] Clcanny opened a new pull request #9870: ARROW-12176: [C++] Fix some typos of cpp/examples/parquet/low-level-a…
Clcanny opened a new pull request #9870:
URL: https://github.com/apache/arrow/pull/9870
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] cyb70289 commented on pull request #9870: ARROW-12176: [C++] Fix some typos of cpp examples
Posted by GitBox <gi...@apache.org>.
cyb70289 commented on pull request #9870:
URL: https://github.com/apache/arrow/pull/9870#issuecomment-813771985
> > @pitrou, Shall we use underscore for all source file names?
>
> Yes, we should. We probably forgot to convert these files.
Created jira https://issues.apache.org/jira/browse/ARROW-12217
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] pitrou commented on pull request #9870: ARROW-12176: [C++] Fix some typos of cpp examples
Posted by GitBox <gi...@apache.org>.
pitrou commented on pull request #9870:
URL: https://github.com/apache/arrow/pull/9870#issuecomment-812631121
> @pitrou, Shall we use underscore for all source file names?
Yes, we should. We probably forgot to convert these files.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] cyb70289 commented on a change in pull request #9870: ARROW-12176: [C++] Fix some typos of cpp examples
Posted by GitBox <gi...@apache.org>.
cyb70289 commented on a change in pull request #9870:
URL: https://github.com/apache/arrow/pull/9870#discussion_r606042537
##########
File path: cpp/examples/parquet/low-level-api/reader-writer.cc
##########
@@ -27,7 +27,7 @@
* reference to the API.
* The file contains all the physical data types supported by Parquet.
* This example uses the RowGroupWriter API that supports writing RowGroups optimized for
- *memory consumption
+ * memory consumption.
Review comment:
You may also want to change this line: https://github.com/apache/arrow/blob/master/cpp/examples/parquet/low-level-api/reader-writer2.cc#L30
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] cyb70289 closed pull request #9870: ARROW-12176: [C++] Fix some typos of cpp examples
Posted by GitBox <gi...@apache.org>.
cyb70289 closed pull request #9870:
URL: https://github.com/apache/arrow/pull/9870
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] Clcanny commented on a change in pull request #9870: ARROW-12176: [C++] Fix some typos of cpp examples
Posted by GitBox <gi...@apache.org>.
Clcanny commented on a change in pull request #9870:
URL: https://github.com/apache/arrow/pull/9870#discussion_r606164332
##########
File path: cpp/examples/parquet/low-level-api/reader-writer.cc
##########
@@ -27,7 +27,7 @@
* reference to the API.
* The file contains all the physical data types supported by Parquet.
* This example uses the RowGroupWriter API that supports writing RowGroups optimized for
- *memory consumption
+ * memory consumption.
Review comment:
Thanks for your review!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #9870: ARROW-12176: [C++] Fix some typos of cpp/examples/parquet/low-level-a…
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #9870:
URL: https://github.com/apache/arrow/pull/9870#issuecomment-811798226
https://issues.apache.org/jira/browse/ARROW-12176
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org