You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@jackrabbit.apache.org by Angela Schreiber <an...@day.com> on 2006/03/02 16:55:38 UTC

Jcr-Server Contrib: JSR170 dependency in WebDAV library

hi

it has been mentioned in an earlier thread, that the webdav
library (contrib/jcr-server/webdav) is designed for generic
usage. nevertheless there are currently the following
dependencies to jsr170:

1) DavSession.getRepositorySession() [javax.jcr.Session]
    -> dependency in return value
2) DavResourceLocator.getJcrPath()   [String]
    -> naming issue
3) DavLocatorFactory: javadoc refering to 2)
    -> javadoc issue

actually, i'd prefer to get rid of those dependencies.
while 2) and 3) whould only be a matter or renaming,
1) could be solved by returning a generic object or
removing the method altogether.

what is the feeling about such a change?

regards
angela





Re: Jcr-Server Contrib: JSR170 dependency in WebDAV library

Posted by Brian Moseley <bc...@osafoundation.org>.
On 3/2/06, Angela Schreiber <an...@day.com> wrote:

> what is the feeling about such a change?

this would be wonderful, as it would open the door to creating mock
implementations of the webdav interfaces that don't require a jcr
repository.

Re: JCR-337 and Jackrabbit 1.0 Release

Posted by Jukka Zitting <ju...@gmail.com>.
Hi,

On 3/13/06, Angela Schreiber <an...@day.com> wrote:
> i'm done.
> the list of JIRA issues is available from the modification
> summary. the additional checkins not attached to a jira
> issue are mainly related to code reformatting and javadoc.

OK, thanks. I've now merged the changes to the 1.0 branch and
commented the Jira issues accordingly. Can you please check out the
jcr-server in the 1.0 branch and see that everything is OK? It
compiled OK, and I was able to deploy and browse the webdav server,
but I didn't do any more extensive testing.

I didn't merge the formatting and javadoc changes you made to keep the
amount of changes in the branch to a minimum. If you want I can still
merge those changes as well.

PS. Sorry for the extra reopen/edit/resolve/reopen/unedit/resolve
cycles on some of your issues. I was about to mark the issues as
affecting the 0.9 version to enable better Jira reports, but realized
only too late that jcr-server wasn't even included in 0.9. My bad. :-)

BR,

Jukka Zitting

--
Yukatan - http://yukatan.fi/ - info@yukatan.fi
Software craftsmanship, JCR consulting, and Java development

Re: JCR-337 and Jackrabbit 1.0 Release

Posted by Angela Schreiber <an...@day.com>.
hi jukka

Jukka Zitting wrote:
> Hi,
> Sounds good, make it so! :-)

i'm done.
the list of JIRA issues is available from the modification
summary. the additional checkins not attached to a jira
issue are mainly related to code reformatting and javadoc.

thanks for merging with your 1.0 branch.
angela


Re: JCR-337 and Jackrabbit 1.0 Release

Posted by Jukka Zitting <ju...@gmail.com>.
Hi,

On 3/10/06, Angela Schreiber <an...@day.com> wrote:
> Since i consider the risk of the complete set of changes
> as low, i'd like to suggest, that not only JCR-337
> should make it into the 1.0 release.
>
> If you agree i would enter separate JIRA bugs for
> the additional issues scheduled for 1.0 and mark
> the checkins accordingly. As usual i'll provide a
> summary of the changes for those that prefer a simple
> overview to reading svn-diffs.

Sounds good, make it so! :-)

BR,

Jukka Zitting

--
Yukatan - http://yukatan.fi/ - info@yukatan.fi
Software craftsmanship, JCR consulting, and Java development

JCR-337 and Jackrabbit 1.0 Release

Posted by Angela Schreiber <an...@day.com>.
hi jukka

While preparing the checkin and writing a modification
summary, i realized that fixing JCR-337 not only
requires API changes but that i underestimated the
amount of classes modified specially in the remoting
part. Second i realized that i fixed additional bugs
and consistency issues during the last weeks, some
of them interfering with the modifications related to
the JCR-337 issue.

Since i consider the risk of the complete set of changes
as low, i'd like to suggest, that not only JCR-337
should make it into the 1.0 release.

If you agree i would enter separate JIRA bugs for
the additional issues scheduled for 1.0 and mark
the checkins accordingly. As usual i'll provide a
summary of the changes for those that prefer a simple
overview to reading svn-diffs.

What do you think?
angela

Re: Jcr-Server Contrib: JSR170 dependency in WebDAV library

Posted by Tobias Bocanegra <to...@day.com>.
i totaly agree. i would prefer to remove the getRepositorySession()
completely. returning "an object" is a sign of poor design.

regards, toby

On 3/2/06, Angela Schreiber <an...@day.com> wrote:
> hi
>
> it has been mentioned in an earlier thread, that the webdav
> library (contrib/jcr-server/webdav) is designed for generic
> usage. nevertheless there are currently the following
> dependencies to jsr170:
>
> 1) DavSession.getRepositorySession() [javax.jcr.Session]
>     -> dependency in return value
> 2) DavResourceLocator.getJcrPath()   [String]
>     -> naming issue
> 3) DavLocatorFactory: javadoc refering to 2)
>     -> javadoc issue
>
> actually, i'd prefer to get rid of those dependencies.
> while 2) and 3) whould only be a matter or renaming,
> 1) could be solved by returning a generic object or
> removing the method altogether.
>
> what is the feeling about such a change?
>
> regards
> angela
>
>
>
>
>


--
-----------------------------------------< tobias.bocanegra@day.com >---
Tobias Bocanegra, Day Management AG, Barfuesserplatz 6, CH - 4001 Basel
T +41 61 226 98 98, F +41 61 226 98 97
-----------------------------------------------< http://www.day.com >---