You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ignite.apache.org by "Ignite TC Bot (Jira)" <ji...@apache.org> on 2020/07/31 11:49:00 UTC
[jira] [Commented] (IGNITE-13296) .NET: TransactionImpl finalizer
can crash the process
[ https://issues.apache.org/jira/browse/IGNITE-13296?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17168657#comment-17168657 ]
Ignite TC Bot commented on IGNITE-13296:
----------------------------------------
{panel:title=Branch: [pull/8104/head] Base: [master] : Possible Blockers (5)|borderStyle=dashed|borderColor=#ccc|titleBGColor=#F7D6C1}
{color:#d04437}Cache 5{color} [[tests 1|https://ci.ignite.apache.org/viewLog.html?buildId=5503159]]
* IgniteCacheTestSuite5: CacheSerializableTransactionsTest.testTxConflictInvoke2 - Test has low fail rate in base branch 0,0% and is not flaky
{color:#d04437}PDS 1{color} [[tests 1|https://ci.ignite.apache.org/viewLog.html?buildId=5503172]]
* IgnitePdsTestSuite: IgniteClusterActivateDeactivateTestWithPersistence.testDeactivateFromReadOnlyFailover3 - Test has low fail rate in base branch 0,0% and is not flaky
{color:#d04437}Cache 8{color} [[tests 0 TIMEOUT , Exit Code |https://ci.ignite.apache.org/viewLog.html?buildId=5503162]]
{color:#d04437}Basic 1{color} [[tests 1|https://ci.ignite.apache.org/viewLog.html?buildId=5503135]]
* IgniteBasicTestSuite: BPlusTreeFakeReuseSelfTest.testMassiveRemove2_true - Test has low fail rate in base branch 0,0% and is not flaky
{color:#d04437}SPI (URI Deploy){color} [[tests 1|https://ci.ignite.apache.org/viewLog.html?buildId=5503125]]
* IgniteUriDeploymentTestSuite: GridFileDeploymentUndeploySelfTest.testUndeployGarFile - Test has low fail rate in base branch 0,0% and is not flaky
{panel}
{panel:title=Branch: [pull/8104/head] Base: [master] : New Tests (22)|borderStyle=dashed|borderColor=#ccc|titleBGColor=#D6F7C1}
{color:#00008b}Platform .NET{color} [[tests 7|https://ci.ignite.apache.org/viewLog.html?buildId=5503176]]
* {color:#013220}exe: GetLocalActiveTransactionsTest.TestUnsupportedOperationsThrow - PASSED{color}
* {color:#013220}exe: GetLocalActiveTransactionsTest.TestTxAttributes - PASSED{color}
* {color:#013220}exe: GetLocalActiveTransactionsTest.TestRollbacks(False) - PASSED{color}
* {color:#013220}exe: GetLocalActiveTransactionsTest.TestRollbacks(True) - PASSED{color}
* {color:#013220}exe: GetLocalActiveTransactionsTest.TestMultipleRollbackThrows - PASSED{color}
* {color:#013220}exe: GetLocalActiveTransactionsTest.TestDisposeDoesNotEndTx - PASSED{color}
* {color:#013220}exe: CacheTransactionGridStopTest.TestDisposeDoesNotThrow - PASSED{color}
{color:#00008b}Platform .NET (Core Linux){color} [[tests 7|https://ci.ignite.apache.org/viewLog.html?buildId=5503177]]
* {color:#013220}dll: GetLocalActiveTransactionsTest.TestRollbacks(False) - PASSED{color}
* {color:#013220}dll: GetLocalActiveTransactionsTest.TestRollbacks(True) - PASSED{color}
* {color:#013220}dll: GetLocalActiveTransactionsTest.TestMultipleRollbackThrows - PASSED{color}
* {color:#013220}dll: GetLocalActiveTransactionsTest.TestDisposeDoesNotEndTx - PASSED{color}
* {color:#013220}dll: CacheTransactionGridStopTest.TestDisposeDoesNotThrow - PASSED{color}
* {color:#013220}dll: GetLocalActiveTransactionsTest.TestUnsupportedOperationsThrow - PASSED{color}
* {color:#013220}dll: GetLocalActiveTransactionsTest.TestTxAttributes - PASSED{color}
{color:#00008b}Service Grid{color} [[tests 4|https://ci.ignite.apache.org/viewLog.html?buildId=5503188]]
* {color:#013220}IgniteServiceGridTestSuite: ServiceDeploymentProcessIdSelfTest.topologyVersion[Test event=IgniteBiTuple [val1=DiscoveryEvent [evtNode=80006016-33e9-48ab-8a7f-11389e7e4b82, topVer=0, msgTemplate=null, span=null, nodeId8=733616f4, msg=, type=NODE_JOINED, tstamp=1596183216523], val2=AffinityTopologyVersion [topVer=-2243621677827066615, minorTopVer=0]]] - PASSED{color}
* {color:#013220}IgniteServiceGridTestSuite: ServiceDeploymentProcessIdSelfTest.requestId[Test event=IgniteBiTuple [val1=DiscoveryEvent [evtNode=80006016-33e9-48ab-8a7f-11389e7e4b82, topVer=0, msgTemplate=null, span=null, nodeId8=733616f4, msg=, type=NODE_JOINED, tstamp=1596183216523], val2=AffinityTopologyVersion [topVer=-2243621677827066615, minorTopVer=0]]] - PASSED{color}
* {color:#013220}IgniteServiceGridTestSuite: ServiceDeploymentProcessIdSelfTest.topologyVersion[Test event=IgniteBiTuple [val1=DiscoveryCustomEvent [customMsg=ServiceChangeBatchRequest [id=f810fe3a371-5ec6a607-6588-4778-9e65-1c83d03d5cc5, reqs=SingletonList [ServiceUndeploymentRequest []]], affTopVer=null, super=DiscoveryEvent [evtNode=5b9b62a6-8dc1-418f-9837-e6377a1d80c4, topVer=0, msgTemplate=null, span=null, nodeId8=5b9b62a6, msg=null, type=DISCOVERY_CUSTOM_EVT, tstamp=1596183216523]], val2=AffinityTopologyVersion [topVer=-4196155983088536022, minorTopVer=0]]] - PASSED{color}
* {color:#013220}IgniteServiceGridTestSuite: ServiceDeploymentProcessIdSelfTest.requestId[Test event=IgniteBiTuple [val1=DiscoveryCustomEvent [customMsg=ServiceChangeBatchRequest [id=f810fe3a371-5ec6a607-6588-4778-9e65-1c83d03d5cc5, reqs=SingletonList [ServiceUndeploymentRequest []]], affTopVer=null, super=DiscoveryEvent [evtNode=5b9b62a6-8dc1-418f-9837-e6377a1d80c4, topVer=0, msgTemplate=null, span=null, nodeId8=5b9b62a6, msg=null, type=DISCOVERY_CUSTOM_EVT, tstamp=1596183216523]], val2=AffinityTopologyVersion [topVer=-4196155983088536022, minorTopVer=0]]] - PASSED{color}
{color:#00008b}Service Grid (legacy mode){color} [[tests 4|https://ci.ignite.apache.org/viewLog.html?buildId=5503189]]
* {color:#013220}IgniteServiceGridTestSuite: ServiceDeploymentProcessIdSelfTest.requestId[Test event=IgniteBiTuple [val1=DiscoveryCustomEvent [customMsg=ServiceChangeBatchRequest [id=331e1f3a371-e55d101c-9eff-4772-ba88-fbaaf3ec2fed, reqs=SingletonList [ServiceUndeploymentRequest []]], affTopVer=null, super=DiscoveryEvent [evtNode=460eedce-b60d-4913-9c6d-077dd39ad2ff, topVer=0, msgTemplate=null, span=null, nodeId8=460eedce, msg=null, type=DISCOVERY_CUSTOM_EVT, tstamp=1596183404847]], val2=AffinityTopologyVersion [topVer=-2255598350085340680, minorTopVer=0]]] - PASSED{color}
* {color:#013220}IgniteServiceGridTestSuite: ServiceDeploymentProcessIdSelfTest.topologyVersion[Test event=IgniteBiTuple [val1=DiscoveryEvent [evtNode=e1362b0d-7202-433a-80d4-7f1abe3ccb27, topVer=0, msgTemplate=null, span=null, nodeId8=c089e2ec, msg=, type=NODE_JOINED, tstamp=1596183404847], val2=AffinityTopologyVersion [topVer=6351482184566024700, minorTopVer=0]]] - PASSED{color}
* {color:#013220}IgniteServiceGridTestSuite: ServiceDeploymentProcessIdSelfTest.requestId[Test event=IgniteBiTuple [val1=DiscoveryEvent [evtNode=e1362b0d-7202-433a-80d4-7f1abe3ccb27, topVer=0, msgTemplate=null, span=null, nodeId8=c089e2ec, msg=, type=NODE_JOINED, tstamp=1596183404847], val2=AffinityTopologyVersion [topVer=6351482184566024700, minorTopVer=0]]] - PASSED{color}
* {color:#013220}IgniteServiceGridTestSuite: ServiceDeploymentProcessIdSelfTest.topologyVersion[Test event=IgniteBiTuple [val1=DiscoveryCustomEvent [customMsg=ServiceChangeBatchRequest [id=331e1f3a371-e55d101c-9eff-4772-ba88-fbaaf3ec2fed, reqs=SingletonList [ServiceUndeploymentRequest []]], affTopVer=null, super=DiscoveryEvent [evtNode=460eedce-b60d-4913-9c6d-077dd39ad2ff, topVer=0, msgTemplate=null, span=null, nodeId8=460eedce, msg=null, type=DISCOVERY_CUSTOM_EVT, tstamp=1596183404847]], val2=AffinityTopologyVersion [topVer=-2255598350085340680, minorTopVer=0]]] - PASSED{color}
{panel}
[TeamCity *--> Run :: All* Results|https://ci.ignite.apache.org/viewLog.html?buildId=5503211&buildTypeId=IgniteTests24Java8_RunAll]
> .NET: TransactionImpl finalizer can crash the process
> -----------------------------------------------------
>
> Key: IGNITE-13296
> URL: https://issues.apache.org/jira/browse/IGNITE-13296
> Project: Ignite
> Issue Type: Bug
> Components: platforms
> Reporter: Pavel Tupitsyn
> Assignee: Sergey Stronchinskiy
> Priority: Major
> Labels: .NET
> Fix For: 2.10
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> ~TransactionImpl potentially throws an exception (e.g. when grid is stopped), causing the entire process to abort.
> GetLocalActiveTransactions is especially problematic - the method is informational, yet will result in all the returned transactions to be finalized later.
> * Finalizers should not throw exceptions
> * Stopped grid is a valid use case
> * GetLocalActiveTransactions should be fixed to return "read-only" transactions that won't be finalized
> Review all filalizers and make sure they are safe.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)