You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@couchdb.apache.org by garrensmith <gi...@git.apache.org> on 2015/01/05 15:12:36 UTC

[GitHub] couchdb-fauxton pull request: remove sidebar class and set sidebar...

GitHub user garrensmith opened a pull request:

    https://github.com/apache/couchdb-fauxton/pull/213

    remove sidebar class and set sidebar width in #sidebar-content

    Without this fix the sidebar goes across into the main section like this:
    
    ![](https://www.dropbox.com/s/y4sjkybedrb6rzk/Screenshot%202015-01-05%2016.11.46.png?dl=1)

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/garrensmith/couchdb-fauxton set-sidebar-width

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/couchdb-fauxton/pull/213.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #213
    
----
commit c8ffd21c9cb317cb388f22859b579311f5986c7a
Author: Garren Smith <ga...@gmail.com>
Date:   2015-01-05T14:11:03Z

    remove sidebar class and set sidebar width in #sidebar-content

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] couchdb-fauxton pull request: remove sidebar class and set sidebar...

Posted by robertkowalski <gi...@git.apache.org>.
Github user robertkowalski commented on the pull request:

    https://github.com/apache/couchdb-fauxton/pull/213#issuecomment-68715311
  
    example fix
    
    ```patch
    diff --git a/app/addons/activetasks/assets/less/activetasks.less b/app/addons/activetasks/assets/less/activetasks.less
    index 5acc4bb..68c44a9 100644
    --- a/app/addons/activetasks/assets/less/activetasks.less
    +++ b/app/addons/activetasks/assets/less/activetasks.less
    @@ -45,7 +45,7 @@
       }
     }
    
    -.sidebar .polling-interval {
    +.nav.polling-interval {
       li.nav-header {
         padding: 9px 0px 0px 9px;
       }
    ```


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] couchdb-fauxton pull request: remove sidebar class and set sidebar...

Posted by garrensmith <gi...@git.apache.org>.
Github user garrensmith closed the pull request at:

    https://github.com/apache/couchdb-fauxton/pull/213


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] couchdb-fauxton pull request: remove sidebar class and set sidebar...

Posted by robertkowalski <gi...@git.apache.org>.
Github user robertkowalski commented on the pull request:

    https://github.com/apache/couchdb-fauxton/pull/213#issuecomment-68714689
  
    that fixes the issue, but we have to take care of 
    
    ```css
    .sidebar .polling-interval {
    ```
    
    in `activetasks.less`


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] couchdb-fauxton pull request: remove sidebar class and set sidebar...

Posted by garrensmith <gi...@git.apache.org>.
Github user garrensmith commented on the pull request:

    https://github.com/apache/couchdb-fauxton/pull/213#issuecomment-68859918
  
    merged.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] couchdb-fauxton pull request: remove sidebar class and set sidebar...

Posted by robertkowalski <gi...@git.apache.org>.
Github user robertkowalski commented on the pull request:

    https://github.com/apache/couchdb-fauxton/pull/213#issuecomment-68859578
  
    +1


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---