You are viewing a plain text version of this content. The canonical link for it is here.

Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2021/11/23 18:59:25 UTC

[GitHub] [kafka] cmccabe commented on pull request #11457: MINOR: guard against calls to exit in QuorumTestHarness tests

cmccabe commented on pull request #11457:
URL: https://github.com/apache/kafka/pull/11457#issuecomment-977021255


   > Thanks for the change @cmccabe . Which tests are impacted by this change? I could only find ReplicationQuotasTestRig does that matches your understanding?
   
   We have actually accumulated a lot of calls to `Exit#exit` and `Exit#halt`, unfortunately. Here is a partial list of files that include these calls:
   
   * KafkaRequestHandler.scala
   * ShutdownableThread.scala
   * LogManager.scala
   * ReplicaManager.scala
   
   If any of these trigger during a junit test, the entire multi-hour Jenkins test run will terminate with a cryptic error message that doesn't explain which test had the problem.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org