You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/08/26 09:09:01 UTC
[GitHub] [flink] rmetzger opened a new pull request #13248: [FLINK-18222][e2e] Stabilize Avro Confluent Schema Registry nightly test
rmetzger opened a new pull request #13248:
URL: https://github.com/apache/flink/pull/13248
The test was unstable because the broker tried to connect to ZK before ZK was running.
With this change, we wait for ZK to be running before proceeding.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13248: [FLINK-18222][e2e] Stabilize Avro Confluent Schema Registry nightly test
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13248:
URL: https://github.com/apache/flink/pull/13248#issuecomment-680766918
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "c67f4e27864b0af383d58248c2767e04342c9fbb",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5880",
"triggerID" : "c67f4e27864b0af383d58248c2767e04342c9fbb",
"triggerType" : "PUSH"
}, {
"hash" : "f89d112f560de7b16267eb66c4701c9bbf6e4112",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "f89d112f560de7b16267eb66c4701c9bbf6e4112",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* c67f4e27864b0af383d58248c2767e04342c9fbb Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5880)
* f89d112f560de7b16267eb66c4701c9bbf6e4112 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13248: [FLINK-18222][e2e] Stabilize Avro Confluent Schema Registry nightly test
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13248:
URL: https://github.com/apache/flink/pull/13248#issuecomment-680766918
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "c67f4e27864b0af383d58248c2767e04342c9fbb",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5880",
"triggerID" : "c67f4e27864b0af383d58248c2767e04342c9fbb",
"triggerType" : "PUSH"
}, {
"hash" : "f89d112f560de7b16267eb66c4701c9bbf6e4112",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5925",
"triggerID" : "f89d112f560de7b16267eb66c4701c9bbf6e4112",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* c67f4e27864b0af383d58248c2767e04342c9fbb Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5880)
* f89d112f560de7b16267eb66c4701c9bbf6e4112 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5925)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13248: [FLINK-18222][e2e] Stabilize Avro Confluent Schema Registry nightly test
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13248:
URL: https://github.com/apache/flink/pull/13248#issuecomment-680766918
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "c67f4e27864b0af383d58248c2767e04342c9fbb",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5880",
"triggerID" : "c67f4e27864b0af383d58248c2767e04342c9fbb",
"triggerType" : "PUSH"
}, {
"hash" : "f89d112f560de7b16267eb66c4701c9bbf6e4112",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5925",
"triggerID" : "f89d112f560de7b16267eb66c4701c9bbf6e4112",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* f89d112f560de7b16267eb66c4701c9bbf6e4112 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5925)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13248: [FLINK-18222][e2e] Stabilize Avro Confluent Schema Registry nightly test
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13248:
URL: https://github.com/apache/flink/pull/13248#issuecomment-680766918
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "c67f4e27864b0af383d58248c2767e04342c9fbb",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5880",
"triggerID" : "c67f4e27864b0af383d58248c2767e04342c9fbb",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* c67f4e27864b0af383d58248c2767e04342c9fbb Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5880)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] XComp commented on a change in pull request #13248: [FLINK-18222][e2e] Stabilize Avro Confluent Schema Registry nightly test
Posted by GitBox <gi...@apache.org>.
XComp commented on a change in pull request #13248:
URL: https://github.com/apache/flink/pull/13248#discussion_r478218263
##########
File path: flink-end-to-end-tests/test-scripts/kafka-common.sh
##########
@@ -59,13 +59,29 @@ function setup_confluent_dist {
sed -i -e "s#listeners=http://0.0.0.0:8081#listeners=http://0.0.0.0:${SCHEMA_REGISTRY_PORT}#" $CONFLUENT_DIR/etc/schema-registry/schema-registry.properties
}
+function wait_for_zookeeper_running {
+ while $KAFKA_DIR/bin/zookeeper-shell.sh localhost:2181 get /testnonexistent 2>&1 | grep -q "Connection refused"; do
+ echo "waiting for zookeeper to start."
+ sleep 1
+ done
Review comment:
Shouldn't we add a counter here? Otherwise we'd create an infinite loop if the zookeeper startup fails. The old implementation would have ended up exiting in the [while loop](https://github.com/apache/flink/pull/13248/files#diff-3a25c674bfb7f722ef91f6b8630e56f4R99) in such a case. I think, we don't reach that one in case of a missing ZooKeeper anymore...
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #13248: [FLINK-18222][e2e] Stabilize Avro Confluent Schema Registry nightly test
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #13248:
URL: https://github.com/apache/flink/pull/13248#issuecomment-680759707
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit c67f4e27864b0af383d58248c2767e04342c9fbb (Wed Aug 26 09:11:38 UTC 2020)
**Warnings:**
* No documentation files were touched! Remember to keep the Flink docs up to date!
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] rmetzger commented on pull request #13248: [FLINK-18222][e2e] Stabilize Avro Confluent Schema Registry nightly test
Posted by GitBox <gi...@apache.org>.
rmetzger commented on pull request #13248:
URL: https://github.com/apache/flink/pull/13248#issuecomment-684849306
Thanks a lot. Merging ...
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13248: [FLINK-18222][e2e] Stabilize Avro Confluent Schema Registry nightly test
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13248:
URL: https://github.com/apache/flink/pull/13248#issuecomment-680766918
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "c67f4e27864b0af383d58248c2767e04342c9fbb",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5880",
"triggerID" : "c67f4e27864b0af383d58248c2767e04342c9fbb",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* c67f4e27864b0af383d58248c2767e04342c9fbb Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5880)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #13248: [FLINK-18222][e2e] Stabilize Avro Confluent Schema Registry nightly test
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #13248:
URL: https://github.com/apache/flink/pull/13248#issuecomment-680766918
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "c67f4e27864b0af383d58248c2767e04342c9fbb",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "c67f4e27864b0af383d58248c2767e04342c9fbb",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* c67f4e27864b0af383d58248c2767e04342c9fbb UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] rmetzger commented on a change in pull request #13248: [FLINK-18222][e2e] Stabilize Avro Confluent Schema Registry nightly test
Posted by GitBox <gi...@apache.org>.
rmetzger commented on a change in pull request #13248:
URL: https://github.com/apache/flink/pull/13248#discussion_r478332807
##########
File path: flink-end-to-end-tests/test-scripts/kafka-common.sh
##########
@@ -59,13 +59,29 @@ function setup_confluent_dist {
sed -i -e "s#listeners=http://0.0.0.0:8081#listeners=http://0.0.0.0:${SCHEMA_REGISTRY_PORT}#" $CONFLUENT_DIR/etc/schema-registry/schema-registry.properties
}
+function wait_for_zookeeper_running {
+ while $KAFKA_DIR/bin/zookeeper-shell.sh localhost:2181 get /testnonexistent 2>&1 | grep -q "Connection refused"; do
+ echo "waiting for zookeeper to start."
+ sleep 1
+ done
Review comment:
Yes, that's a good point. I'll add one.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] rmetzger closed pull request #13248: [FLINK-18222][e2e] Stabilize Avro Confluent Schema Registry nightly test
Posted by GitBox <gi...@apache.org>.
rmetzger closed pull request #13248:
URL: https://github.com/apache/flink/pull/13248
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org