[GitHub] [incubator-tvm] MarisaKirisame commented on a change in pull request #6086: [Relay] Fix interpreter for dyanmic shape input of ndarray_size

[GitBox <gi...@apache.org>]

MarisaKirisame commented on a change in pull request #6086:
URL: https://github.com/apache/incubator-tvm/pull/6086#discussion_r460089408



##########
File path: src/relay/backend/interpreter.cc
##########
@@ -486,6 +487,9 @@ class Interpreter : public ExprFunctor<ObjectRef(const Expr& n)>,
       // The output shape of shape_of must be static since Relay doesn't support
       // dynamic rank tensors.
       is_dyn = false;
+    } else if (call_node->op == ndarray_size_op_) {

Review comment:
       can you refactor the code into IsDynamic? e.g. make an IsDynamic that take a call node.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org