You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@commons.apache.org by Ben Anderson <be...@benanderson.us> on 2004/10/04 13:08:23 UTC
Re: (JELLY-150) j:forEach tag not properly using varStatus attribute
no, it belongs in javax.servlet.
http://java.sun.com/products/jsp/jstl/1.1/docs/api/javax/servlet/jsp/jstl/core/LoopTagSupport.html
Does your "unified format" comment pertain to the diff file I posted? This is
the first patch I've ever submitted. I wasn't sure what to do with the new
files, so I appended them to that file. I'm assuming this is not the way to do
it, but I didn't know how. If someone will let me know how I'm supposed to do
it, I'll do it when I get home tonight (I can't access Jira here at work)
Thanks,
Ben
Quoting commons-dev@jakarta.apache.org:
> The following comment has been added to this issue:
>
> Author: Hans Gilde
> Created: Sat, 2 Oct 2004 9:30 PM
> Body:
> This patch adds a class in the package javax.servlet. This is a no-no.
> Everything should be in a jelly packge. Maybe LoopTagStatus should be a
> public static inner class of LoopTagStatus?
>
> Also, this patch isn't the Unified format.
>
> I haven't looked over the logic, yet, just the structure.
>
> ---------------------------------------------------------------------
> View this comment:
> http://issues.apache.org/jira/browse/JELLY-150?page=comments#action_53634
>
> ---------------------------------------------------------------------
> View the issue:
> http://issues.apache.org/jira/browse/JELLY-150
>
> Here is an overview of the issue:
> ---------------------------------------------------------------------
> Key: JELLY-150
> Summary: j:forEach tag not properly using varStatus attribute
> Type: Bug
>
> Status: Unassigned
> Priority: Major
>
> Project: jelly
> Components:
> core / taglib.core
> Versions:
> 1.0-beta-4
> 1.0
> 1.1-beta-1
> jface-1.0-beta-1
> jface-1.0
> swt-1.0
> 1.0-beta-5
>
> Assignee:
> Reporter: Ben Anderson
>
> Created: Fri, 24 Sep 2004 4:57 AM
> Updated: Sat, 2 Oct 2004 9:30 PM
> Environment: win2k / cygwin
>
> Description:
> According to the jstl specification 1.1, the varStatus attribute of the
> forEach tag should create a variable with type
> javax.servlet.jsp.jstl.core.LoopTagStatus. Currently a variable is set with
> type Integer which contains the index of the current iteration. I created a
> test case (I don't think any existed for forEach) that demonstrates this. I
> also began making the fix, but it doesn't fully work. I am submitting my
> patch along with the test cases. The comments I placed in the code should be
> enough to tip someone off as to why it's not working (I hope). I am
> relatively new to jelly (been using the standard taglibs for awhile) and have
> never opened the source before. I am willing to complete the patch, but will
> probably need some guidance because I messed with it for awhile before
> determing I couldn't complete without some help. Thanks! :-)
>
>
> ---------------------------------------------------------------------
> JIRA INFORMATION:
> This message is automatically generated by JIRA.
>
> If you think it was sent incorrectly contact one of the administrators:
> http://issues.apache.org/jira/secure/Administrators.jspa
>
> If you want more information on JIRA, or have a bug to report see:
> http://www.atlassian.com/software/jira
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
> For additional commands, e-mail: commons-dev-help@jakarta.apache.org
>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-dev-help@jakarta.apache.org
Re: (JELLY-150) j:forEach tag not properly using varStatus attribute
Posted by Paul Libbrecht <pa...@activemath.org>.
Le 4 oct. 04, à 15:36, Ben Anderson a écrit :
> you make a valid point. I had just copied that interface from the
> jakarta-taglibs project. It is an interface - not a class. I'll
> admit, I
> don't know too much about licensing. I was just assuming that it's
> legal to
> create a physical manifestion of interfaces defined by Sun.
It's perfectly legal. Licenses tend yo restrict people at transmission
times... download such an interface's class-file may be the time when
this get restricted. For example, the servlet 2.1 API license (at least
when downloaded from Sun) had a license claim that said that the
licensee can redistribute the jar along with your own product at latest
180 days after the latest release of the servlet 2.1 API!
JCP outcomes licensing has been a hot topic and I don't know wether
that's really set...
> The actual
> implementation is done in an anonymous inner class. How else would we
> stick to
> the standards defined by jstl? Isn't this the whole point of the JCP?
> The
> community defines the spec, which can be implemented by anyone. As a
> side
> note, the servletapi in the maven repository does not contain this
> interface.
> Essentially the only difference in not having this dependency vs.
> having it is
> the namespace. The dependency doesn't change, it's just whether the
> name is:
> javax.servlet.jsp.jstl.core.LoopTagStatus
> or
> org.apache.commons.jelly.whatever.LoopTagStatus
But the class-name is irrelevant for Jexl... do you need anything else
than jexl (or any other reflection-based system) ?
paul
---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-dev-help@jakarta.apache.org
Re: (JELLY-150) j:forEach tag not properly using varStatus attribute
Posted by Ben Anderson <be...@benanderson.us>.
you make a valid point. I had just copied that interface from the
jakarta-taglibs project. It is an interface - not a class. I'll admit, I
don't know too much about licensing. I was just assuming that it's legal to
create a physical manifestion of interfaces defined by Sun. The actual
implementation is done in an anonymous inner class. How else would we stick to
the standards defined by jstl? Isn't this the whole point of the JCP? The
community defines the spec, which can be implemented by anyone. As a side
note, the servletapi in the maven repository does not contain this interface.
Essentially the only difference in not having this dependency vs. having it is
the namespace. The dependency doesn't change, it's just whether the name is:
javax.servlet.jsp.jstl.core.LoopTagStatus
or
org.apache.commons.jelly.whatever.LoopTagStatus
-Ben
Quoting Paul Libbrecht <pa...@activemath.org>:
> As Hans said,
>
> We don't want to introduce such a dependency in the core jelly.
> It used to be a problem because it wasn't maven distributable... now it
> looks like it actually is maven distributed (under the project-name
> servletapi).
> I'd like to have a kind of better confirmation than just seeing it in
> the maven repository before comitting to such a jump. (the licenses in
> the maven repo are... Apache license! I doubt this is from Sun).
>
> Do note that, if you want to use it from jexl, it is probably
> irrelevant wether it is actually of the given class or just implements
> all the methods with same signature. So, before the immensely long time
> someone of Sun actually claims the Apache license is correct, it might
> be faster to just write an class with the same methods...
>
> paul
>
>
> Le 4 oct. 04, à 13:08, Ben Anderson a écrit :
>
> > no, it belongs in javax.servlet.
> > http://java.sun.com/products/jsp/jstl/1.1/docs/api/javax/servlet/jsp/
> > jstl/core/LoopTagSupport.html
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
> For additional commands, e-mail: commons-dev-help@jakarta.apache.org
>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-dev-help@jakarta.apache.org
Re: (JELLY-150) j:forEach tag not properly using varStatus attribute
Posted by Paul Libbrecht <pa...@activemath.org>.
As Hans said,
We don't want to introduce such a dependency in the core jelly.
It used to be a problem because it wasn't maven distributable... now it
looks like it actually is maven distributed (under the project-name
servletapi).
I'd like to have a kind of better confirmation than just seeing it in
the maven repository before comitting to such a jump. (the licenses in
the maven repo are... Apache license! I doubt this is from Sun).
Do note that, if you want to use it from jexl, it is probably
irrelevant wether it is actually of the given class or just implements
all the methods with same signature. So, before the immensely long time
someone of Sun actually claims the Apache license is correct, it might
be faster to just write an class with the same methods...
paul
Le 4 oct. 04, à 13:08, Ben Anderson a écrit :
> no, it belongs in javax.servlet.
> http://java.sun.com/products/jsp/jstl/1.1/docs/api/javax/servlet/jsp/
> jstl/core/LoopTagSupport.html
---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-dev-help@jakarta.apache.org
RE: (JELLY-150) j:forEach tag not properly using varStatus attribute
Posted by Ben Anderson <be...@benanderson.us>.
Yes, I consulted that page. What do you mean "include the new files on the end
of cvs diff -u"? This is what I did:
$echo 'src/test/org/apache/commons/jelly/core/testForEachTag.jelly' >>site.patch
$cat src/test/org/apache/commons/jelly/core/testForEachTag.jelly >>site.patch
Was I on the right track? I tried what it sounds like you're saying:
$ cvs diff -u ./src/test/org/apache/commons/jelly/core/TestForEachTag.java
cvs server: I know nothing about
./src/test/org/apache/commons/jelly/core/TestForEachTag.java
If I contribute another patch in the future, I'd like it to be done correctly.
;-)
Thanks,
Ben
Quoting Hans Gilde <hg...@earthlink.net>:
> Ben,
>
> Now I see what you did with the patch. See
> http://jakarta.apache.org/commons/patches.html for the diff command. All you
> have to do is include the new files on the end of cvs diff -u and they'll be
> a part of the patch.
>
> Hans
>
> -----Original Message-----
> From: Ben Anderson [mailto:benanderson@benanderson.us]
> Sent: Monday, October 04, 2004 6:08 AM
> To: Jakarta Commons Developers List
> Subject: Re: (JELLY-150) j:forEach tag not properly using varStatus
> attribute
>
> no, it belongs in javax.servlet.
> http://java.sun.com/products/jsp/jstl/1.1/docs/api/javax/servlet/jsp/jstl/co
> re/LoopTagSupport.html
> Does your "unified format" comment pertain to the diff file I posted? This
> is
> the first patch I've ever submitted. I wasn't sure what to do with the new
> files, so I appended them to that file. I'm assuming this is not the way to
> do
> it, but I didn't know how. If someone will let me know how I'm supposed to
> do
> it, I'll do it when I get home tonight (I can't access Jira here at work)
> Thanks,
> Ben
>
> Quoting commons-dev@jakarta.apache.org:
>
> > The following comment has been added to this issue:
> >
> > Author: Hans Gilde
> > Created: Sat, 2 Oct 2004 9:30 PM
> > Body:
> > This patch adds a class in the package javax.servlet. This is a no-no.
> > Everything should be in a jelly packge. Maybe LoopTagStatus should be a
> > public static inner class of LoopTagStatus?
> >
> > Also, this patch isn't the Unified format.
> >
> > I haven't looked over the logic, yet, just the structure.
> >
> > ---------------------------------------------------------------------
> > View this comment:
> >
> http://issues.apache.org/jira/browse/JELLY-150?page=comments#action_53634
> >
> > ---------------------------------------------------------------------
> > View the issue:
> > http://issues.apache.org/jira/browse/JELLY-150
> >
> > Here is an overview of the issue:
> > ---------------------------------------------------------------------
> > Key: JELLY-150
> > Summary: j:forEach tag not properly using varStatus attribute
> > Type: Bug
> >
> > Status: Unassigned
> > Priority: Major
> >
> > Project: jelly
> > Components:
> > core / taglib.core
> > Versions:
> > 1.0-beta-4
> > 1.0
> > 1.1-beta-1
> > jface-1.0-beta-1
> > jface-1.0
> > swt-1.0
> > 1.0-beta-5
> >
> > Assignee:
> > Reporter: Ben Anderson
> >
> > Created: Fri, 24 Sep 2004 4:57 AM
> > Updated: Sat, 2 Oct 2004 9:30 PM
> > Environment: win2k / cygwin
> >
> > Description:
> > According to the jstl specification 1.1, the varStatus attribute of the
> > forEach tag should create a variable with type
> > javax.servlet.jsp.jstl.core.LoopTagStatus. Currently a variable is set
> with
> > type Integer which contains the index of the current iteration. I created
> a
> > test case (I don't think any existed for forEach) that demonstrates this.
> I
> > also began making the fix, but it doesn't fully work. I am submitting my
> > patch along with the test cases. The comments I placed in the code should
> be
> > enough to tip someone off as to why it's not working (I hope). I am
> > relatively new to jelly (been using the standard taglibs for awhile) and
> have
> > never opened the source before. I am willing to complete the patch, but
> will
> > probably need some guidance because I messed with it for awhile before
> > determing I couldn't complete without some help. Thanks! :-)
> >
> >
> > ---------------------------------------------------------------------
> > JIRA INFORMATION:
> > This message is automatically generated by JIRA.
> >
> > If you think it was sent incorrectly contact one of the administrators:
> > http://issues.apache.org/jira/secure/Administrators.jspa
> >
> > If you want more information on JIRA, or have a bug to report see:
> > http://www.atlassian.com/software/jira
> >
> >
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
> > For additional commands, e-mail: commons-dev-help@jakarta.apache.org
> >
> >
>
>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
> For additional commands, e-mail: commons-dev-help@jakarta.apache.org
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
> For additional commands, e-mail: commons-dev-help@jakarta.apache.org
>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-dev-help@jakarta.apache.org
RE: (JELLY-150) j:forEach tag not properly using varStatus attribute
Posted by Hans Gilde <hg...@earthlink.net>.
Ben,
Now I see what you did with the patch. See
http://jakarta.apache.org/commons/patches.html for the diff command. All you
have to do is include the new files on the end of cvs diff -u and they'll be
a part of the patch.
Hans
-----Original Message-----
From: Ben Anderson [mailto:benanderson@benanderson.us]
Sent: Monday, October 04, 2004 6:08 AM
To: Jakarta Commons Developers List
Subject: Re: (JELLY-150) j:forEach tag not properly using varStatus
attribute
no, it belongs in javax.servlet.
http://java.sun.com/products/jsp/jstl/1.1/docs/api/javax/servlet/jsp/jstl/co
re/LoopTagSupport.html
Does your "unified format" comment pertain to the diff file I posted? This
is
the first patch I've ever submitted. I wasn't sure what to do with the new
files, so I appended them to that file. I'm assuming this is not the way to
do
it, but I didn't know how. If someone will let me know how I'm supposed to
do
it, I'll do it when I get home tonight (I can't access Jira here at work)
Thanks,
Ben
Quoting commons-dev@jakarta.apache.org:
> The following comment has been added to this issue:
>
> Author: Hans Gilde
> Created: Sat, 2 Oct 2004 9:30 PM
> Body:
> This patch adds a class in the package javax.servlet. This is a no-no.
> Everything should be in a jelly packge. Maybe LoopTagStatus should be a
> public static inner class of LoopTagStatus?
>
> Also, this patch isn't the Unified format.
>
> I haven't looked over the logic, yet, just the structure.
>
> ---------------------------------------------------------------------
> View this comment:
>
http://issues.apache.org/jira/browse/JELLY-150?page=comments#action_53634
>
> ---------------------------------------------------------------------
> View the issue:
> http://issues.apache.org/jira/browse/JELLY-150
>
> Here is an overview of the issue:
> ---------------------------------------------------------------------
> Key: JELLY-150
> Summary: j:forEach tag not properly using varStatus attribute
> Type: Bug
>
> Status: Unassigned
> Priority: Major
>
> Project: jelly
> Components:
> core / taglib.core
> Versions:
> 1.0-beta-4
> 1.0
> 1.1-beta-1
> jface-1.0-beta-1
> jface-1.0
> swt-1.0
> 1.0-beta-5
>
> Assignee:
> Reporter: Ben Anderson
>
> Created: Fri, 24 Sep 2004 4:57 AM
> Updated: Sat, 2 Oct 2004 9:30 PM
> Environment: win2k / cygwin
>
> Description:
> According to the jstl specification 1.1, the varStatus attribute of the
> forEach tag should create a variable with type
> javax.servlet.jsp.jstl.core.LoopTagStatus. Currently a variable is set
with
> type Integer which contains the index of the current iteration. I created
a
> test case (I don't think any existed for forEach) that demonstrates this.
I
> also began making the fix, but it doesn't fully work. I am submitting my
> patch along with the test cases. The comments I placed in the code should
be
> enough to tip someone off as to why it's not working (I hope). I am
> relatively new to jelly (been using the standard taglibs for awhile) and
have
> never opened the source before. I am willing to complete the patch, but
will
> probably need some guidance because I messed with it for awhile before
> determing I couldn't complete without some help. Thanks! :-)
>
>
> ---------------------------------------------------------------------
> JIRA INFORMATION:
> This message is automatically generated by JIRA.
>
> If you think it was sent incorrectly contact one of the administrators:
> http://issues.apache.org/jira/secure/Administrators.jspa
>
> If you want more information on JIRA, or have a bug to report see:
> http://www.atlassian.com/software/jira
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
> For additional commands, e-mail: commons-dev-help@jakarta.apache.org
>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-dev-help@jakarta.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-dev-help@jakarta.apache.org