You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/06/27 14:51:34 UTC

[GitHub] [pulsar] codelipenghui opened a new pull request, #16245: [improve][broker] Avoid go through all the consumers to get the message ack owner

codelipenghui opened a new pull request, #16245:
URL: https://github.com/apache/pulsar/pull/16245

   ### Motivation
   
   The broker don't need to go through all the consumers to get the ack owner consumer.
   Instead, it should check the current consumer first. If the pending acks of current consumer
   don't have the ack position, go through all the consumers to find the owner consumer.
   
   <img width="1835" alt="image" src="https://user-images.githubusercontent.com/12592133/175969525-5a1250e1-5621-45da-91e2-93beac5120b0.png">
   
   Without this PR:
   [perf_broker_subscribe_1.html.txt](https://github.com/apache/pulsar/files/8993011/perf_broker_subscribe_1.html.txt)
   
   With this PR:
   [perf_broker_subscribe_2.html.txt](https://github.com/apache/pulsar/files/8993012/perf_broker_subscribe_2.html.txt)
   
   ### Does this pull request potentially affect one of the following parts:
   
   *If `yes` was chosen, please highlight the changes*
   
     - Dependencies (does it add or upgrade a dependency): (no)
     - The public API: (no)
     - The schema: (no)
     - The default values of configurations: (no)
     - The wire protocol: (no)
     - The rest endpoints: (no)
     - The admin cli options: (no)
     - Anything that affects deployment: (no)
   
   ### Documentation
   
   Check the box below or label this PR directly.
   
   Need to update docs? 
   
   - [ ] `doc-required` 
   (Your PR needs to update docs and you will update later)
     
   - [x] `doc-not-needed` 
   (Please explain why)
     
   - [ ] `doc` 
   (Your PR contains doc changes)
   
   - [ ] `doc-complete`
   (Docs have been already added)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] github-actions[bot] commented on pull request #16245: [improve][broker] Avoid go through all the consumers to get the message ack owner

Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #16245:
URL: https://github.com/apache/pulsar/pull/16245#issuecomment-1167454392

   @codelipenghui Please provide a correct documentation label for your PR.
   Instructions see [Pulsar Documentation Label Guide](https://docs.google.com/document/d/1Qw7LHQdXWBW9t2-r-A7QdFDBwmZh6ytB4guwMoXHqc0).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] hangc0276 merged pull request #16245: [improve][broker] Avoid go through all the consumers to get the message ack owner

Posted by GitBox <gi...@apache.org>.
hangc0276 merged PR #16245:
URL: https://github.com/apache/pulsar/pull/16245


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org