You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/08/15 07:54:04 UTC

[GitHub] [flink] hequn8128 opened a new pull request #13153: [FLINK-18966][python] Support key_by() on ConnectedStreams for Python DataStream API

hequn8128 opened a new pull request #13153:
URL: https://github.com/apache/flink/pull/13153


   ## What is the purpose of the change
   
   This pull request supports key_by on Python `ConnectedStreams`.
   
   
   ## Brief change log
   
     - Add key_by on Python `ConnectedStreams`.
     - Refactor `DataStreamTwoInputPythonStatelessFunctionOperator` to support keyed `ConnectedStreams`.
   
   
   ## Verifying this change
   
   This change added tests and can be verified as follows:
   
     - Added `test_key_by_on_connect_stream` integration tests in test_data_stream
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): (no)
     - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (no)
     - The serializers: (no)
     - The runtime per-record code paths (performance sensitive): (no)
     - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: (no)
     - The S3 file system connector: (no)
   
   ## Documentation
   
     - Does this pull request introduce a new feature? (yes)
     - If yes, how is the feature documented? (PythonDocs)
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #13153: [FLINK-18966][python] Support key_by() on ConnectedStreams for Python DataStream API

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13153:
URL: https://github.com/apache/flink/pull/13153#issuecomment-674367157


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "f59963fa5ee56152ca93de32ed73e7fc67eb4250",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5549",
       "triggerID" : "f59963fa5ee56152ca93de32ed73e7fc67eb4250",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * f59963fa5ee56152ca93de32ed73e7fc67eb4250 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5549) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot commented on pull request #13153: [FLINK-18966][python] Support key_by() on ConnectedStreams for Python DataStream API

Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #13153:
URL: https://github.com/apache/flink/pull/13153#issuecomment-674365357


   Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
   to review your pull request. We will use this comment to track the progress of the review.
   
   
   ## Automated Checks
   Last check on commit d0b550ef16bbd451819cf27eadc256348871325f (Sat Aug 15 07:59:29 UTC 2020)
   
   **Warnings:**
    * No documentation files were touched! Remember to keep the Flink docs up to date!
   
   
   <sub>Mention the bot in a comment to re-run the automated checks.</sub>
   ## Review Progress
   
   * ❓ 1. The [description] looks good.
   * ❓ 2. There is [consensus] that the contribution should go into to Flink.
   * ❓ 3. Needs [attention] from.
   * ❓ 4. The change fits into the overall [architecture].
   * ❓ 5. Overall code [quality] is good.
   
   Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
    The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
    - `@flinkbot approve all` to approve all aspects
    - `@flinkbot approve-until architecture` to approve everything until `architecture`
    - `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
    - `@flinkbot disapprove architecture` to remove an approval you gave earlier
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #13153: [FLINK-18966][python] Support key_by() on ConnectedStreams for Python DataStream API

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13153:
URL: https://github.com/apache/flink/pull/13153#issuecomment-674367157


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "f59963fa5ee56152ca93de32ed73e7fc67eb4250",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5549",
       "triggerID" : "f59963fa5ee56152ca93de32ed73e7fc67eb4250",
       "triggerType" : "PUSH"
     }, {
       "hash" : "588f4759045c432b17cfdc994f1fe6a2c4a4f54d",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5564",
       "triggerID" : "588f4759045c432b17cfdc994f1fe6a2c4a4f54d",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * f59963fa5ee56152ca93de32ed73e7fc67eb4250 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5549) 
   * 588f4759045c432b17cfdc994f1fe6a2c4a4f54d Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5564) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #13153: [FLINK-18966][python] Support key_by() on ConnectedStreams for Python DataStream API

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13153:
URL: https://github.com/apache/flink/pull/13153#issuecomment-674367157


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "f59963fa5ee56152ca93de32ed73e7fc67eb4250",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5549",
       "triggerID" : "f59963fa5ee56152ca93de32ed73e7fc67eb4250",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * f59963fa5ee56152ca93de32ed73e7fc67eb4250 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5549) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] hequn8128 commented on pull request #13153: [FLINK-18966][python] Support key_by() on ConnectedStreams for Python DataStream API

Posted by GitBox <gi...@apache.org>.
hequn8128 commented on pull request #13153:
URL: https://github.com/apache/flink/pull/13153#issuecomment-674754142


   @shuiqiangchen Thanks for the review. Merging...


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #13153: [FLINK-18966][python] Support key_by() on ConnectedStreams for Python DataStream API

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13153:
URL: https://github.com/apache/flink/pull/13153#issuecomment-674367157


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "f59963fa5ee56152ca93de32ed73e7fc67eb4250",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5549",
       "triggerID" : "f59963fa5ee56152ca93de32ed73e7fc67eb4250",
       "triggerType" : "PUSH"
     }, {
       "hash" : "588f4759045c432b17cfdc994f1fe6a2c4a4f54d",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "588f4759045c432b17cfdc994f1fe6a2c4a4f54d",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * f59963fa5ee56152ca93de32ed73e7fc67eb4250 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5549) 
   * 588f4759045c432b17cfdc994f1fe6a2c4a4f54d UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] hequn8128 merged pull request #13153: [FLINK-18966][python] Support key_by() on ConnectedStreams for Python DataStream API

Posted by GitBox <gi...@apache.org>.
hequn8128 merged pull request #13153:
URL: https://github.com/apache/flink/pull/13153


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] hequn8128 commented on pull request #13153: [FLINK-18966][python] Support key_by() on ConnectedStreams for Python DataStream API

Posted by GitBox <gi...@apache.org>.
hequn8128 commented on pull request #13153:
URL: https://github.com/apache/flink/pull/13153#issuecomment-674364816


   CC @shuiqiangchen 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot commented on pull request #13153: [FLINK-18966][python] Support key_by() on ConnectedStreams for Python DataStream API

Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #13153:
URL: https://github.com/apache/flink/pull/13153#issuecomment-674367157


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "f59963fa5ee56152ca93de32ed73e7fc67eb4250",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "f59963fa5ee56152ca93de32ed73e7fc67eb4250",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * f59963fa5ee56152ca93de32ed73e7fc67eb4250 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #13153: [FLINK-18966][python] Support key_by() on ConnectedStreams for Python DataStream API

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13153:
URL: https://github.com/apache/flink/pull/13153#issuecomment-674367157


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "f59963fa5ee56152ca93de32ed73e7fc67eb4250",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5549",
       "triggerID" : "f59963fa5ee56152ca93de32ed73e7fc67eb4250",
       "triggerType" : "PUSH"
     }, {
       "hash" : "588f4759045c432b17cfdc994f1fe6a2c4a4f54d",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5564",
       "triggerID" : "588f4759045c432b17cfdc994f1fe6a2c4a4f54d",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 588f4759045c432b17cfdc994f1fe6a2c4a4f54d Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5564) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org