You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@cordova.apache.org by GitBox <gi...@apache.org> on 2020/08/20 13:06:07 UTC
[GitHub] [cordova-ios] HarelM commented on a change in pull request #956: (iOS) Support multiple provisioning profiles, Resolves #953
HarelM commented on a change in pull request #956:
URL: https://github.com/apache/cordova-ios/pull/956#discussion_r473953852
##########
File path: bin/templates/scripts/cordova/lib/build.js
##########
@@ -231,7 +236,12 @@ module.exports.run = buildOpts => {
}
if (buildOpts.provisioningProfile && bundleIdentifier) {
- exportOptions.provisioningProfiles = { [bundleIdentifier]: String(buildOpts.provisioningProfile) };
+ if (typeof buildOpts.provisioningProfile === 'string') {
+ exportOptions.provisioningProfiles = { [bundleIdentifier]: String(buildOpts.provisioningProfile) };
+ } else {
+ console.log('Setting multiple provisioning profiles for signing');
Review comment:
No problem, I'll check how other places do logging.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org