You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sqoop.apache.org by Jarek Cecho <ja...@apache.org> on 2016/02/19 22:10:30 UTC
Review Request 43783: SQOOP-2848: Sqoop2: RESTiliency: Simplify
JobRequestHandler.getJobs similarly as was done for getLinks
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43783/
-----------------------------------------------------------
Review request for Sqoop and Jarek Cecho.
Bugs: SQOOP-2848
https://issues.apache.org/jira/browse/SQOOP-2848
Repository: sqoop-sqoop2
Description
-------
I would like to simplify the {{JobRequestHandler.getJobs}} similarly as we've changed for {{LinkRequestHandler.getLinks}} back in SQOOP-2670.
Diffs
-----
server/src/main/java/org/apache/sqoop/handler/JobRequestHandler.java 3070059
test/pom.xml 134bca1
test/src/main/java/org/apache/sqoop/test/testng/ReconfigureLogListener.java PRE-CREATION
test/src/test/java/org/apache/sqoop/integration/server/rest/JobRestTest.java PRE-CREATION
test/src/test/java/org/apache/sqoop/integration/server/rest/RestTest.java 5b3a7bf
test/src/test/resources/connector-loading-tests-suite.xml 02c1df3
test/src/test/resources/hive-tests-suite.xml 3e2b328
test/src/test/resources/integration-tests-suite.xml 73e0a77
test/src/test/resources/new-integration-tests-suite.xml 96a1320
test/src/test/resources/shell-tests-suite.xml e2c0b09
test/src/test/resources/tools-tests-suite.xml fee2121
test/src/test/resources/upgrade-tests-suite.xml 3318e67
Diff: https://reviews.apache.org/r/43783/diff/
Testing
-------
Thanks,
Jarek Cecho
Re: Review Request 43783: SQOOP-2848: Sqoop2: RESTiliency: Simplify
JobRequestHandler.getJobs similarly as was done for getLinks
Posted by Jarek Cecho <ja...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43783/
-----------------------------------------------------------
(Updated March 4, 2016, 10:42 p.m.)
Review request for Sqoop and Jarek Cecho.
Bugs: SQOOP-2848
https://issues.apache.org/jira/browse/SQOOP-2848
Repository: sqoop-sqoop2
Description
-------
I would like to simplify the {{JobRequestHandler.getJobs}} similarly as we've changed for {{LinkRequestHandler.getLinks}} back in SQOOP-2670.
Diffs (updated)
-----
server/src/main/java/org/apache/sqoop/handler/JobRequestHandler.java 3070059
test/src/test/java/org/apache/sqoop/integration/server/rest/JobRestTest.java PRE-CREATION
test/src/test/java/org/apache/sqoop/integration/server/rest/RestTest.java 5b3a7bf
Diff: https://reviews.apache.org/r/43783/diff/
Testing
-------
Thanks,
Jarek Cecho
Re: Review Request 43783: SQOOP-2848: Sqoop2: RESTiliency: Simplify
JobRequestHandler.getJobs similarly as was done for getLinks
Posted by Jarek Cecho <ja...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43783/
-----------------------------------------------------------
(Updated March 4, 2016, 10:39 p.m.)
Review request for Sqoop and Jarek Cecho.
Bugs: SQOOP-2848
https://issues.apache.org/jira/browse/SQOOP-2848
Repository: sqoop-sqoop2
Description
-------
I would like to simplify the {{JobRequestHandler.getJobs}} similarly as we've changed for {{LinkRequestHandler.getLinks}} back in SQOOP-2670.
Diffs (updated)
-----
server/src/main/java/org/apache/sqoop/handler/JobRequestHandler.java 3070059
test/src/test/java/org/apache/sqoop/integration/server/rest/RestTest.java 5b3a7bf
Diff: https://reviews.apache.org/r/43783/diff/
Testing
-------
Thanks,
Jarek Cecho
Re: Review Request 43783: SQOOP-2848: Sqoop2: RESTiliency: Simplify
JobRequestHandler.getJobs similarly as was done for getLinks
Posted by Jarek Cecho <ja...@apache.org>.
> On March 1, 2016, 8:44 p.m., Abraham Fine wrote:
> > server/src/main/java/org/apache/sqoop/handler/JobRequestHandler.java, line 276
> > <https://reviews.apache.org/r/43783/diff/2/?file=1263214#file1263214line276>
> >
> > perhaps this "all" should be stored in a constant somewhere as it is a special case?
> >
> > also, slightly unrelated, do you know if we have a mechanism to prevent the creation of connectors or links named "all"?
Excellent points
1) I should do the change everywhere, so I'll cover it in separate JIRA: https://issues.apache.org/jira/browse/SQOOP-2867
2) Filled https://issues.apache.org/jira/browse/SQOOP-2868 to cover it.
> On March 1, 2016, 8:44 p.m., Abraham Fine wrote:
> > test/src/test/java/org/apache/sqoop/integration/server/rest/JobRestTest.java, line 37
> > <https://reviews.apache.org/r/43783/diff/2/?file=1263215#file1263215line37>
> >
> > nit: could we avoid duplicating this validator code?
Will incorporate to next version.
- Jarek
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43783/#review121485
-----------------------------------------------------------
On Feb. 19, 2016, 9:17 p.m., Jarek Cecho wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43783/
> -----------------------------------------------------------
>
> (Updated Feb. 19, 2016, 9:17 p.m.)
>
>
> Review request for Sqoop and Jarek Cecho.
>
>
> Bugs: SQOOP-2848
> https://issues.apache.org/jira/browse/SQOOP-2848
>
>
> Repository: sqoop-sqoop2
>
>
> Description
> -------
>
> I would like to simplify the {{JobRequestHandler.getJobs}} similarly as we've changed for {{LinkRequestHandler.getLinks}} back in SQOOP-2670.
>
>
> Diffs
> -----
>
> server/src/main/java/org/apache/sqoop/handler/JobRequestHandler.java 3070059
> test/src/test/java/org/apache/sqoop/integration/server/rest/JobRestTest.java PRE-CREATION
> test/src/test/java/org/apache/sqoop/integration/server/rest/RestTest.java 5b3a7bf
>
> Diff: https://reviews.apache.org/r/43783/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Jarek Cecho
>
>
Re: Review Request 43783: SQOOP-2848: Sqoop2: RESTiliency: Simplify
JobRequestHandler.getJobs similarly as was done for getLinks
Posted by Abraham Fine <ab...@abrahamfine.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43783/#review121485
-----------------------------------------------------------
server/src/main/java/org/apache/sqoop/handler/JobRequestHandler.java (line 269)
<https://reviews.apache.org/r/43783/#comment183203>
perhaps this "all" should be stored in a constant somewhere as it is a special case?
also, slightly unrelated, do you know if we have a mechanism to prevent the creation of connectors or links named "all"?
server/src/main/java/org/apache/sqoop/handler/JobRequestHandler.java (line 280)
<https://reviews.apache.org/r/43783/#comment183205>
typo: one specific job
test/src/test/java/org/apache/sqoop/integration/server/rest/JobRestTest.java (line 37)
<https://reviews.apache.org/r/43783/#comment183206>
nit: could we avoid duplicating this validator code?
- Abraham Fine
On Feb. 19, 2016, 9:17 p.m., Jarek Cecho wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43783/
> -----------------------------------------------------------
>
> (Updated Feb. 19, 2016, 9:17 p.m.)
>
>
> Review request for Sqoop and Jarek Cecho.
>
>
> Bugs: SQOOP-2848
> https://issues.apache.org/jira/browse/SQOOP-2848
>
>
> Repository: sqoop-sqoop2
>
>
> Description
> -------
>
> I would like to simplify the {{JobRequestHandler.getJobs}} similarly as we've changed for {{LinkRequestHandler.getLinks}} back in SQOOP-2670.
>
>
> Diffs
> -----
>
> server/src/main/java/org/apache/sqoop/handler/JobRequestHandler.java 3070059
> test/src/test/java/org/apache/sqoop/integration/server/rest/JobRestTest.java PRE-CREATION
> test/src/test/java/org/apache/sqoop/integration/server/rest/RestTest.java 5b3a7bf
>
> Diff: https://reviews.apache.org/r/43783/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Jarek Cecho
>
>
Re: Review Request 43783: SQOOP-2848: Sqoop2: RESTiliency: Simplify
JobRequestHandler.getJobs similarly as was done for getLinks
Posted by Jarek Cecho <ja...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43783/
-----------------------------------------------------------
(Updated Feb. 19, 2016, 9:17 p.m.)
Review request for Sqoop and Jarek Cecho.
Bugs: SQOOP-2848
https://issues.apache.org/jira/browse/SQOOP-2848
Repository: sqoop-sqoop2
Description
-------
I would like to simplify the {{JobRequestHandler.getJobs}} similarly as we've changed for {{LinkRequestHandler.getLinks}} back in SQOOP-2670.
Diffs (updated)
-----
server/src/main/java/org/apache/sqoop/handler/JobRequestHandler.java 3070059
test/src/test/java/org/apache/sqoop/integration/server/rest/JobRestTest.java PRE-CREATION
test/src/test/java/org/apache/sqoop/integration/server/rest/RestTest.java 5b3a7bf
Diff: https://reviews.apache.org/r/43783/diff/
Testing
-------
Thanks,
Jarek Cecho