[GitHub] GJL edited a comment on issue #6491: [FLINK-10057] Update FlinkYarnSessionCli.java

[GitBox <gi...@apache.org>]

GJL edited a comment on issue #6491: [FLINK-10057] Update FlinkYarnSessionCli.java
URL: https://github.com/apache/flink/pull/6491#issuecomment-430941464
 
 
   Merging because all comments from @StefanRRichter have been addressed.
   
   Here are some additional remarks:
   * `isYarnPropertiesFileMode` is not in the performance critical path, and there are not many options to be processed. Therefore, the method should be optimized for readability.
   * Your changes improve readability but we could do better by extracting the logic in the loop, e.g.,:
   ```
   	private boolean isYarnPropertiesFileMode(CommandLine commandLine) {
   		final boolean isNotAddressOptionSet = !commandLine.hasOption(addressOption.getOpt());
   		return isNotAddressOptionSet && isNotYarnOptionsSet(commandLine);
   	}
   ```
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services