You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@mesos.apache.org by "Andrew Schwartzmeyer (JIRA)" <ji...@apache.org> on 2018/04/04 06:04:00 UTC
[jira] [Commented] (MESOS-8692) Replace _chsize_s with SetEndOfFile
on Windows
[ https://issues.apache.org/jira/browse/MESOS-8692?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16425058#comment-16425058 ]
Andrew Schwartzmeyer commented on MESOS-8692:
---------------------------------------------
This is actually tied up in [here|https://reviews.apache.org/r/66431/], but it needs to be split out.
> Replace _chsize_s with SetEndOfFile on Windows
> ----------------------------------------------
>
> Key: MESOS-8692
> URL: https://issues.apache.org/jira/browse/MESOS-8692
> Project: Mesos
> Issue Type: Task
> Reporter: Andrew Schwartzmeyer
> Assignee: Andrew Schwartzmeyer
> Priority: Major
> Labels: stout, windows
>
> The function {{os::ftruncate}} on Windows uses the CRT API {{_chsize_s}} which requires an integer file descriptor. We can replace this with the semantically similar if not equivalent logic of {{SetFilePointer}} followed by {{SetEndOfFile}}. Major different is that it doesn't write null bytes when extending the file; it leaves the data uninitialized.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)