You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by GitBox <gi...@apache.org> on 2020/01/29 11:20:50 UTC
[GitHub] [hbase] abhinabasarkar commented on issue #1074: HBASE-23350 Make
compaction files cacheonWrite configurable based on threshold
abhinabasarkar commented on issue #1074: HBASE-23350 Make compaction files cacheonWrite configurable based on threshold
URL: https://github.com/apache/hbase/pull/1074#issuecomment-579710966
How to fix the checkstyle issue for visibility modifier? This is new checkstyle issue that this patch is generating -
> ./hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/compactions/Compactor.java:134: public long totalCompactedFilesSize = 0;:17: Variable 'totalCompactedFilesSize' must be private and have accessor methods. [VisibilityModifier]
In the root checkstyle file
> https://builds.apache.org/job/HBase%20Nightly/job/branch-2/lastSuccessfulBuild/artifact/output-general/patch-checkstyle-root.txt
`Compactor.java` already has similar checkstyle warnings.
> ./hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/compactions/Compactor.java:120:17: Variable 'maxKeyCount' must be private and have accessor methods. [VisibilityModifier]
./hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/compactions/Compactor.java:122:17: Variable 'earliestPutTs' must be private and have accessor methods. [VisibilityModifier]
./hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/compactions/Compactor.java:124:17: Variable 'latestPutTs' must be private and have accessor methods. [VisibilityModifier]
./hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/compactions/Compactor.java:126:17: Variable 'maxSeqId' must be private and have accessor methods. [VisibilityModifier]
./hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/compactions/Compactor.java:128:17: Variable 'maxMVCCReadpoint' must be private and have accessor methods. [VisibilityModifier]
./hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/compactions/Compactor.java:130:16: Variable 'maxTagsLength' must be private and have accessor methods. [VisibilityModifier]
./hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/compactions/Compactor.java:132:17: Variable 'minSeqIdToKeep' must be private and have accessor methods. [VisibilityModifier]
cc @HorizonNet @busbey
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services