[jira] [Commented] (CASSANDRA-17023) Eliminate toCQLString() duplication between ReadCommand and AbstractReadQuery

["Caleb Rackliffe (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/CASSANDRA-17023?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17433030#comment-17433030 ] 

Caleb Rackliffe commented on CASSANDRA-17023:
---------------------------------------------

Left one small nit on the PR, but otherwise, this LGTM.

Thanks for the patch!

(Note: You'll just need to find one other committer to review, but then I can commit this for you.)

> Eliminate toCQLString() duplication between ReadCommand and AbstractReadQuery
> -----------------------------------------------------------------------------
>
>                 Key: CASSANDRA-17023
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-17023
>             Project: Cassandra
>          Issue Type: Task
>          Components: CQL/Syntax
>            Reporter: Caleb Rackliffe
>            Assignee: Kanthi Subramanian
>            Priority: Normal
>             Fix For: 4.1
>
>          Time Spent: 20m
>  Remaining Estimate: 0h
>
> This is certainly low-hanging fruit, but the {{toCQLString()}} in {{ReadCommand}} now entirely duplicates the one in its superclass {{AbstractReadQuery}}. I think we can just remove the former.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cassandra.apache.org
For additional commands, e-mail: commits-help@cassandra.apache.org