[GitHub] [netbeans] JaroslavTulach commented on a change in pull request #2653: Support executor ProgressHandle cancel over DAP protocol.

[GitBox <gi...@apache.org>]

JaroslavTulach commented on a change in pull request #2653:
URL: https://github.com/apache/netbeans/pull/2653#discussion_r554123044



##########
File path: java/java.lsp.server/src/org/netbeans/modules/java/lsp/server/debugging/DebugAdapterContext.java
##########
@@ -116,6 +119,19 @@ public int getDebuggerLine(int clientLine) {
     void setClientPathsAreUri(boolean clientPathsAreUri) {
         this.clientPathsAreUri = clientPathsAreUri;
     }
+    
+    public boolean requestProcessTermination() {
+        if (processExecutorHandle != null) {

Review comment:
       Only correct if `requestProcessTermination` and `setProcessExecutorHandle` are always called by the same thread.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists