You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2021/07/08 00:26:39 UTC
[GitHub] [kafka] cmccabe opened a new pull request #10995: MINOR: fix ducker-ak Dockerfile issue
cmccabe opened a new pull request #10995:
URL: https://github.com/apache/kafka/pull/10995
New versions of pip apparently removed support for Python 3.5, the
version of Python our ducker image is using. They used to support it,
and now they only support newer versions of Python.
We will eventually have to upgrade the version of Python in the image.
That will probably mean moving to a different Ubuntu base image.
However, for now, using pip 20.3.4 seems to work and is easier.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] cmccabe commented on a change in pull request #10995: MINOR: Hint about "docker system prune" when ducker-ak build fails
Posted by GitBox <gi...@apache.org>.
cmccabe commented on a change in pull request #10995:
URL: https://github.com/apache/kafka/pull/10995#discussion_r666362458
##########
File path: tests/docker/ducker-ak
##########
@@ -185,6 +185,12 @@ must_popd() {
popd &> /dev/null || die "failed to popd"
}
+echo_and_do() {
+ local cmd="${@}"
+ echo "${cmd}"
+ ${cmd}
Review comment:
Also I guess some people would say that I'm doing things too much the Java way here, and that the kewl bash way of doing this would be
```
set -x
<run command>
set +x
```
But it still feels kind of like a mess since, does `set +x` change `$?` ?
Sigh.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] kamalcph commented on pull request #10995: MINOR: Hint about "docker system prune" when ducker-ak build fails
Posted by GitBox <gi...@apache.org>.
kamalcph commented on pull request #10995:
URL: https://github.com/apache/kafka/pull/10995#issuecomment-876588345
There is also a tip to run the command with `--no-cache` flag on error. Why isn't it exposed?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] kamalcph edited a comment on pull request #10995: MINOR: Hint about "docker system prune" when ducker-ak build fails
Posted by GitBox <gi...@apache.org>.
kamalcph edited a comment on pull request #10995:
URL: https://github.com/apache/kafka/pull/10995#issuecomment-876589345
Also, can you update the label from `ducker.type` to `ducker.creator` [here](https://github.com/apache/kafka/blob/a657d735cf3ca1fafd4bd255137713a28509ed8a/tests/docker/ducker-ak#L339)?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] hachikuji commented on a change in pull request #10995: MINOR: Hint about "docker system prune" when ducker-ak build fails
Posted by GitBox <gi...@apache.org>.
hachikuji commented on a change in pull request #10995:
URL: https://github.com/apache/kafka/pull/10995#discussion_r666348755
##########
File path: tests/docker/ducker-ak
##########
@@ -185,6 +185,12 @@ must_popd() {
popd &> /dev/null || die "failed to popd"
}
+echo_and_do() {
+ local cmd="${@}"
+ echo "${cmd}"
+ ${cmd}
Review comment:
The logic through `must_do`, which we were doing previously also redirects output and checks the command return. Should we do something similar?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] kamalcph commented on pull request #10995: MINOR: Hint about "docker system prune" when ducker-ak build fails
Posted by GitBox <gi...@apache.org>.
kamalcph commented on pull request #10995:
URL: https://github.com/apache/kafka/pull/10995#issuecomment-876589345
Also, can you update the label from `ducker.type` to `ducker.creator` [here](https://github.com/apache/kafka/blob/a657d735cf3ca1fafd4bd255137713a28509ed8a/tests/docker/ducker-ak#L339).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] hachikuji commented on a change in pull request #10995: MINOR: Hint about "docker system prune" when ducker-ak build fails
Posted by GitBox <gi...@apache.org>.
hachikuji commented on a change in pull request #10995:
URL: https://github.com/apache/kafka/pull/10995#discussion_r666360055
##########
File path: tests/docker/ducker-ak
##########
@@ -185,6 +185,12 @@ must_popd() {
popd &> /dev/null || die "failed to popd"
}
+echo_and_do() {
+ local cmd="${@}"
+ echo "${cmd}"
+ ${cmd}
Review comment:
Fair enough.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] kamalcph commented on pull request #10995: MINOR: Hint about "docker system prune" when ducker-ak build fails
Posted by GitBox <gi...@apache.org>.
kamalcph commented on pull request #10995:
URL: https://github.com/apache/kafka/pull/10995#issuecomment-876604684
@cmccabe
Updated #10499, can you take another look?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] cmccabe commented on a change in pull request #10995: MINOR: Hint about "docker system prune" when ducker-ak build fails
Posted by GitBox <gi...@apache.org>.
cmccabe commented on a change in pull request #10995:
URL: https://github.com/apache/kafka/pull/10995#discussion_r666358707
##########
File path: tests/docker/ducker-ak
##########
@@ -185,6 +185,12 @@ must_popd() {
popd &> /dev/null || die "failed to popd"
}
+echo_and_do() {
+ local cmd="${@}"
+ echo "${cmd}"
+ ${cmd}
Review comment:
Well... I made this new function because the other one was checking the output and exiting if it was nonzero. That didn't allow me to print the error message I wanted. So doing the same thing here would defeat the point :)
If bash shell was a better language, I could add a lambda argument to the existing function and have the lambda return what to print on failure. But shell doesn't really do closures, so it would turn into kind of a mess.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] lbradstreet commented on pull request #10995: MINOR: fix ducker-ak Dockerfile issue
Posted by GitBox <gi...@apache.org>.
lbradstreet commented on pull request #10995:
URL: https://github.com/apache/kafka/pull/10995#issuecomment-876549710
I hit this same problem and was able to resolve it with `docker system prune -a` to make sure it grabbed a later openjdk image where this is not a problem. See the discussion in https://github.com/apache/kafka/pull/10661.
Maybe we can modify this PR to instead provide a more helpful error message?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] cmccabe commented on pull request #10995: MINOR: Hint about "docker system prune" when ducker-ak build fails
Posted by GitBox <gi...@apache.org>.
cmccabe commented on pull request #10995:
URL: https://github.com/apache/kafka/pull/10995#issuecomment-876596528
> There is also a tip to run the command with --no-cache flag on error. Why isn't it exposed?
I agree `--no-cache` should probably appear in the help output somewhere. Let's tackle this in a follow-on. I don't know if it would help with the current issue that many people are seeing with their cache.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] cmccabe merged pull request #10995: MINOR: Hint about "docker system prune" when ducker-ak build fails
Posted by GitBox <gi...@apache.org>.
cmccabe merged pull request #10995:
URL: https://github.com/apache/kafka/pull/10995
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] cmccabe commented on pull request #10995: MINOR: Hint about "docker system prune" when ducker-ak build fails
Posted by GitBox <gi...@apache.org>.
cmccabe commented on pull request #10995:
URL: https://github.com/apache/kafka/pull/10995#issuecomment-876593643
> PR: #10499
@kamalcph: Thanks for that. Can you make a more minimal PR that just changes `ducker.type` to `ducker.creator`?
We're getting so close to the release, and I just don't have time to review a lot of bash changes (to be 100% honest)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] kamalcph commented on pull request #10995: MINOR: Hint about "docker system prune" when ducker-ak build fails
Posted by GitBox <gi...@apache.org>.
kamalcph commented on pull request #10995:
URL: https://github.com/apache/kafka/pull/10995#issuecomment-876590746
> @kamalcph : Thanks, that is a good find. I agree we should update the label from ducker.type to ducker.creator. Can you make a separate PR for that? I can review it quickly.
PR: #10499
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] cmccabe commented on pull request #10995: MINOR: Hint about "docker system prune" when ducker-ak build fails
Posted by GitBox <gi...@apache.org>.
cmccabe commented on pull request #10995:
URL: https://github.com/apache/kafka/pull/10995#issuecomment-876590217
@kamalcph : Thanks, that is a good find. I agree we should update the label from ducker.type to ducker.creator. Can you make a separate PR for that? I can review it quickly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org