You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-issues@hadoop.apache.org by "Todd Lipcon (JIRA)" <ji...@apache.org> on 2011/01/10 23:35:46 UTC
[jira] Created: (HADOOP-7093) Servlets should default to text/plain
Servlets should default to text/plain
-------------------------------------
Key: HADOOP-7093
URL: https://issues.apache.org/jira/browse/HADOOP-7093
Project: Hadoop Common
Issue Type: Bug
Components: io
Affects Versions: 0.22.0
Reporter: Todd Lipcon
Assignee: Todd Lipcon
Fix For: 0.22.0
In trunk the servlets like /stacks and /metrics are returning text/html content-type instead of text/plain. Security wise it's much safer to default to text/plain and require servlets to explicitly set the content-type to text/html when required.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-7093) Servlets should default to text/plain
Posted by "Todd Lipcon (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7093?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Todd Lipcon updated HADOOP-7093:
--------------------------------
Attachment: hadoop-7093.txt
> Servlets should default to text/plain
> -------------------------------------
>
> Key: HADOOP-7093
> URL: https://issues.apache.org/jira/browse/HADOOP-7093
> Project: Hadoop Common
> Issue Type: Bug
> Components: io
> Affects Versions: 0.22.0
> Reporter: Todd Lipcon
> Assignee: Todd Lipcon
> Fix For: 0.22.0
>
> Attachments: hadoop-7093.txt
>
>
> In trunk the servlets like /stacks and /metrics are returning text/html content-type instead of text/plain. Security wise it's much safer to default to text/plain and require servlets to explicitly set the content-type to text/html when required.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-7093) Servlets should default to
text/plain
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7093?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12981718#action_12981718 ]
Hudson commented on HADOOP-7093:
--------------------------------
Integrated in Hadoop-Common-trunk #576 (See [https://hudson.apache.org/hudson/job/Hadoop-Common-trunk/576/])
HADOOP-7093. Servlets should default to text/plain. Contributed by Todd Lipcon
> Servlets should default to text/plain
> -------------------------------------
>
> Key: HADOOP-7093
> URL: https://issues.apache.org/jira/browse/HADOOP-7093
> Project: Hadoop Common
> Issue Type: Bug
> Components: io
> Affects Versions: 0.22.0
> Reporter: Todd Lipcon
> Assignee: Todd Lipcon
> Fix For: 0.22.0
>
> Attachments: hadoop-7093.2.txt, hadoop-7093.3.txt, hadoop-7093.3.txt, hadoop-7093.txt
>
>
> In trunk the servlets like /stacks and /metrics are returning text/html content-type instead of text/plain. Security wise it's much safer to default to text/plain and require servlets to explicitly set the content-type to text/html when required.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-7093) Servlets should default to text/plain
Posted by "Todd Lipcon (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7093?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Todd Lipcon updated HADOOP-7093:
--------------------------------
Status: Patch Available (was: Open)
Updated based on review comments. I tested /stacks, /metrics, and /conf on a running NN and looks good:
todd@todd-w510:~$ curl -s -I 'http://localhost:50070/metrics?format=json' | grep 'Content-Type'
Content-Type: application/json; charset=utf-8
todd@todd-w510:~$ curl -s -I 'http://localhost:50070/metrics' | grep 'Content-Type'
Content-Type: text/plain; charset=utf-8
todd@todd-w510:~$ curl -s -I 'http://localhost:50070/conf' | grep 'Content-Type'
Content-Type: text/xml; charset=utf-8
todd@todd-w510:~$ curl -s -I 'http://localhost:50070/stacks' | grep 'Content-Type'
Content-Type: text/plain; charset=utf-8
> Servlets should default to text/plain
> -------------------------------------
>
> Key: HADOOP-7093
> URL: https://issues.apache.org/jira/browse/HADOOP-7093
> Project: Hadoop Common
> Issue Type: Bug
> Components: io
> Affects Versions: 0.22.0
> Reporter: Todd Lipcon
> Assignee: Todd Lipcon
> Fix For: 0.22.0
>
> Attachments: hadoop-7093.2.txt, hadoop-7093.txt
>
>
> In trunk the servlets like /stacks and /metrics are returning text/html content-type instead of text/plain. Security wise it's much safer to default to text/plain and require servlets to explicitly set the content-type to text/html when required.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-7093) Servlets should default to text/plain
Posted by "Todd Lipcon (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7093?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Todd Lipcon updated HADOOP-7093:
--------------------------------
Attachment: hadoop-7093.3.txt
Fixed the JSON content type nit that Tom pointed out, also fixed release audit warning.
> Servlets should default to text/plain
> -------------------------------------
>
> Key: HADOOP-7093
> URL: https://issues.apache.org/jira/browse/HADOOP-7093
> Project: Hadoop Common
> Issue Type: Bug
> Components: io
> Affects Versions: 0.22.0
> Reporter: Todd Lipcon
> Assignee: Todd Lipcon
> Attachments: hadoop-7093.2.txt, hadoop-7093.3.txt, hadoop-7093.3.txt, hadoop-7093.txt
>
>
> In trunk the servlets like /stacks and /metrics are returning text/html content-type instead of text/plain. Security wise it's much safer to default to text/plain and require servlets to explicitly set the content-type to text/html when required.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-7093) Servlets should default to text/plain
Posted by "Todd Lipcon (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7093?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Todd Lipcon updated HADOOP-7093:
--------------------------------
Resolution: Fixed
Fix Version/s: 0.22.0
Hadoop Flags: [Reviewed]
Status: Resolved (was: Patch Available)
Committed in trunk and branch-0.22 (this is a bug fix since servlets were basically unviewable from web browsers with the html content type)
> Servlets should default to text/plain
> -------------------------------------
>
> Key: HADOOP-7093
> URL: https://issues.apache.org/jira/browse/HADOOP-7093
> Project: Hadoop Common
> Issue Type: Bug
> Components: io
> Affects Versions: 0.22.0
> Reporter: Todd Lipcon
> Assignee: Todd Lipcon
> Fix For: 0.22.0
>
> Attachments: hadoop-7093.2.txt, hadoop-7093.3.txt, hadoop-7093.3.txt, hadoop-7093.txt
>
>
> In trunk the servlets like /stacks and /metrics are returning text/html content-type instead of text/plain. Security wise it's much safer to default to text/plain and require servlets to explicitly set the content-type to text/html when required.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-7093) Servlets should default to
text/plain
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7093?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12983565#action_12983565 ]
Hudson commented on HADOOP-7093:
--------------------------------
Integrated in Hadoop-Common-trunk-Commit #479 (See [https://hudson.apache.org/hudson/job/Hadoop-Common-trunk-Commit/479/])
> Servlets should default to text/plain
> -------------------------------------
>
> Key: HADOOP-7093
> URL: https://issues.apache.org/jira/browse/HADOOP-7093
> Project: Hadoop Common
> Issue Type: Bug
> Components: io
> Affects Versions: 0.22.0
> Reporter: Todd Lipcon
> Assignee: Todd Lipcon
> Fix For: 0.22.0
>
> Attachments: hadoop-7093.2.txt, hadoop-7093.3.txt, hadoop-7093.3.txt, hadoop-7093.txt
>
>
> In trunk the servlets like /stacks and /metrics are returning text/html content-type instead of text/plain. Security wise it's much safer to default to text/plain and require servlets to explicitly set the content-type to text/html when required.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-7093) Servlets should default to
text/plain
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7093?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12980545#action_12980545 ]
Hadoop QA commented on HADOOP-7093:
-----------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12468071/hadoop-7093.2.txt
against trunk revision 1057970.
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 6 new or modified tests.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.
-1 release audit. The applied patch generated 2 release audit warnings (more than the trunk's current 1 warnings).
+1 core tests. The patch passed core unit tests.
+1 contrib tests. The patch passed contrib unit tests.
+1 system test framework. The patch passed system test framework compile.
Test results: https://hudson.apache.org/hudson/job/PreCommit-HADOOP-Build/174//testReport/
Release audit warnings: https://hudson.apache.org/hudson/job/PreCommit-HADOOP-Build/174//artifact/trunk/patchprocess/patchReleaseAuditProblems.txt
Findbugs warnings: https://hudson.apache.org/hudson/job/PreCommit-HADOOP-Build/174//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: https://hudson.apache.org/hudson/job/PreCommit-HADOOP-Build/174//console
This message is automatically generated.
> Servlets should default to text/plain
> -------------------------------------
>
> Key: HADOOP-7093
> URL: https://issues.apache.org/jira/browse/HADOOP-7093
> Project: Hadoop Common
> Issue Type: Bug
> Components: io
> Affects Versions: 0.22.0
> Reporter: Todd Lipcon
> Assignee: Todd Lipcon
> Fix For: 0.22.0
>
> Attachments: hadoop-7093.2.txt, hadoop-7093.txt
>
>
> In trunk the servlets like /stacks and /metrics are returning text/html content-type instead of text/plain. Security wise it's much safer to default to text/plain and require servlets to explicitly set the content-type to text/html when required.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-7093) Servlets should default to text/plain
Posted by "Todd Lipcon (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7093?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Todd Lipcon updated HADOOP-7093:
--------------------------------
Attachment: hadoop-7093.3.txt
Oops, missed test.jsp in the previous patch
> Servlets should default to text/plain
> -------------------------------------
>
> Key: HADOOP-7093
> URL: https://issues.apache.org/jira/browse/HADOOP-7093
> Project: Hadoop Common
> Issue Type: Bug
> Components: io
> Affects Versions: 0.22.0
> Reporter: Todd Lipcon
> Assignee: Todd Lipcon
> Attachments: hadoop-7093.2.txt, hadoop-7093.3.txt, hadoop-7093.3.txt, hadoop-7093.txt
>
>
> In trunk the servlets like /stacks and /metrics are returning text/html content-type instead of text/plain. Security wise it's much safer to default to text/plain and require servlets to explicitly set the content-type to text/html when required.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-7093) Servlets should default to
text/plain
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7093?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12981584#action_12981584 ]
Hadoop QA commented on HADOOP-7093:
-----------------------------------
+1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12468324/hadoop-7093.3.txt
against trunk revision 1058343.
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 7 new or modified tests.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
+1 core tests. The patch passed core unit tests.
+1 contrib tests. The patch passed contrib unit tests.
+1 system test framework. The patch passed system test framework compile.
Test results: https://hudson.apache.org/hudson/job/PreCommit-HADOOP-Build/181//testReport/
Findbugs warnings: https://hudson.apache.org/hudson/job/PreCommit-HADOOP-Build/181//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: https://hudson.apache.org/hudson/job/PreCommit-HADOOP-Build/181//console
This message is automatically generated.
> Servlets should default to text/plain
> -------------------------------------
>
> Key: HADOOP-7093
> URL: https://issues.apache.org/jira/browse/HADOOP-7093
> Project: Hadoop Common
> Issue Type: Bug
> Components: io
> Affects Versions: 0.22.0
> Reporter: Todd Lipcon
> Assignee: Todd Lipcon
> Attachments: hadoop-7093.2.txt, hadoop-7093.3.txt, hadoop-7093.3.txt, hadoop-7093.txt
>
>
> In trunk the servlets like /stacks and /metrics are returning text/html content-type instead of text/plain. Security wise it's much safer to default to text/plain and require servlets to explicitly set the content-type to text/html when required.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-7093) Servlets should default to
text/plain
Posted by "Tom White (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7093?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12980550#action_12980550 ]
Tom White commented on HADOOP-7093:
-----------------------------------
+1
Nit: with this patch there are two mimetypes for JSON; we should use "application/json" in both cases (http://tools.ietf.org/html/rfc4627).
> Servlets should default to text/plain
> -------------------------------------
>
> Key: HADOOP-7093
> URL: https://issues.apache.org/jira/browse/HADOOP-7093
> Project: Hadoop Common
> Issue Type: Bug
> Components: io
> Affects Versions: 0.22.0
> Reporter: Todd Lipcon
> Assignee: Todd Lipcon
> Fix For: 0.22.0
>
> Attachments: hadoop-7093.2.txt, hadoop-7093.txt
>
>
> In trunk the servlets like /stacks and /metrics are returning text/html content-type instead of text/plain. Security wise it's much safer to default to text/plain and require servlets to explicitly set the content-type to text/html when required.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-7093) Servlets should default to text/plain
Posted by "Todd Lipcon (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7093?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Todd Lipcon updated HADOOP-7093:
--------------------------------
Attachment: hadoop-7093.2.txt
> Servlets should default to text/plain
> -------------------------------------
>
> Key: HADOOP-7093
> URL: https://issues.apache.org/jira/browse/HADOOP-7093
> Project: Hadoop Common
> Issue Type: Bug
> Components: io
> Affects Versions: 0.22.0
> Reporter: Todd Lipcon
> Assignee: Todd Lipcon
> Fix For: 0.22.0
>
> Attachments: hadoop-7093.2.txt, hadoop-7093.txt
>
>
> In trunk the servlets like /stacks and /metrics are returning text/html content-type instead of text/plain. Security wise it's much safer to default to text/plain and require servlets to explicitly set the content-type to text/html when required.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-7093) Servlets should default to text/plain
Posted by "Todd Lipcon (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7093?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Todd Lipcon updated HADOOP-7093:
--------------------------------
Status: Patch Available (was: Open)
> Servlets should default to text/plain
> -------------------------------------
>
> Key: HADOOP-7093
> URL: https://issues.apache.org/jira/browse/HADOOP-7093
> Project: Hadoop Common
> Issue Type: Bug
> Components: io
> Affects Versions: 0.22.0
> Reporter: Todd Lipcon
> Assignee: Todd Lipcon
> Fix For: 0.22.0
>
> Attachments: hadoop-7093.txt
>
>
> In trunk the servlets like /stacks and /metrics are returning text/html content-type instead of text/plain. Security wise it's much safer to default to text/plain and require servlets to explicitly set the content-type to text/html when required.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-7093) Servlets should default to
text/plain
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7093?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12979880#action_12979880 ]
Hadoop QA commented on HADOOP-7093:
-----------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12467943/hadoop-7093.txt
against trunk revision 1056006.
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 6 new or modified tests.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.
-1 release audit. The applied patch generated 2 release audit warnings (more than the trunk's current 1 warnings).
+1 core tests. The patch passed core unit tests.
+1 contrib tests. The patch passed contrib unit tests.
+1 system test framework. The patch passed system test framework compile.
Test results: https://hudson.apache.org/hudson/job/PreCommit-HADOOP-Build/166//testReport/
Release audit warnings: https://hudson.apache.org/hudson/job/PreCommit-HADOOP-Build/166//artifact/trunk/patchprocess/patchReleaseAuditProblems.txt
Findbugs warnings: https://hudson.apache.org/hudson/job/PreCommit-HADOOP-Build/166//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: https://hudson.apache.org/hudson/job/PreCommit-HADOOP-Build/166//console
This message is automatically generated.
> Servlets should default to text/plain
> -------------------------------------
>
> Key: HADOOP-7093
> URL: https://issues.apache.org/jira/browse/HADOOP-7093
> Project: Hadoop Common
> Issue Type: Bug
> Components: io
> Affects Versions: 0.22.0
> Reporter: Todd Lipcon
> Assignee: Todd Lipcon
> Fix For: 0.22.0
>
> Attachments: hadoop-7093.txt
>
>
> In trunk the servlets like /stacks and /metrics are returning text/html content-type instead of text/plain. Security wise it's much safer to default to text/plain and require servlets to explicitly set the content-type to text/html when required.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-7093) Servlets should default to text/plain
Posted by "Todd Lipcon (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7093?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Todd Lipcon updated HADOOP-7093:
--------------------------------
Status: Open (was: Patch Available)
Canceling patch to address Tom's comments. Thanks Tom
> Servlets should default to text/plain
> -------------------------------------
>
> Key: HADOOP-7093
> URL: https://issues.apache.org/jira/browse/HADOOP-7093
> Project: Hadoop Common
> Issue Type: Bug
> Components: io
> Affects Versions: 0.22.0
> Reporter: Todd Lipcon
> Assignee: Todd Lipcon
> Fix For: 0.22.0
>
> Attachments: hadoop-7093.txt
>
>
> In trunk the servlets like /stacks and /metrics are returning text/html content-type instead of text/plain. Security wise it's much safer to default to text/plain and require servlets to explicitly set the content-type to text/html when required.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-7093) Servlets should default to
text/plain
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7093?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12981691#action_12981691 ]
Hudson commented on HADOOP-7093:
--------------------------------
Integrated in Hadoop-Common-22-branch #15 (See [https://hudson.apache.org/hudson/job/Hadoop-Common-22-branch/15/])
HADOOP-7093. Servlets should default to text/plain. Contributed by Todd Lipcon
> Servlets should default to text/plain
> -------------------------------------
>
> Key: HADOOP-7093
> URL: https://issues.apache.org/jira/browse/HADOOP-7093
> Project: Hadoop Common
> Issue Type: Bug
> Components: io
> Affects Versions: 0.22.0
> Reporter: Todd Lipcon
> Assignee: Todd Lipcon
> Fix For: 0.22.0
>
> Attachments: hadoop-7093.2.txt, hadoop-7093.3.txt, hadoop-7093.3.txt, hadoop-7093.txt
>
>
> In trunk the servlets like /stacks and /metrics are returning text/html content-type instead of text/plain. Security wise it's much safer to default to text/plain and require servlets to explicitly set the content-type to text/html when required.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-7093) Servlets should default to
text/plain
Posted by "Tom White (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7093?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12980349#action_12980349 ]
Tom White commented on HADOOP-7093:
-----------------------------------
A few comments:
* StackServlet shouldn't use HtmlQuoting since it is serving plain text.
* We need to be sure that StackServlet is serving UTF8-encoded text. Currently it is using the default platform encoding since it is using a writer constructed with new PrintWriter(response.getOutputStream()), see http://download.oracle.com/javase/6/docs/api/java/io/PrintWriter.html#PrintWriter%28java.io.OutputStream%29. Rather we might use response.getWriter(), which uses the character encoding returned by ServletResponse#getCharacterEncoding(), which should pick it up from our earlier call to ServletResponse#setContentType, according to http://download.oracle.com/javaee/6/api/javax/servlet/ServletResponse.html#getWriter%28%29. The other servlets need checking for this too.
* For JSON, MetricsServlet should set the content type to "application/json; charset=utf-8". It's not currently setting the content type.
* ConfServlet should set the charset explicitly too.
> Servlets should default to text/plain
> -------------------------------------
>
> Key: HADOOP-7093
> URL: https://issues.apache.org/jira/browse/HADOOP-7093
> Project: Hadoop Common
> Issue Type: Bug
> Components: io
> Affects Versions: 0.22.0
> Reporter: Todd Lipcon
> Assignee: Todd Lipcon
> Fix For: 0.22.0
>
> Attachments: hadoop-7093.txt
>
>
> In trunk the servlets like /stacks and /metrics are returning text/html content-type instead of text/plain. Security wise it's much safer to default to text/plain and require servlets to explicitly set the content-type to text/html when required.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.