You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@struts.apache.org by "tm_jee (JIRA)" <ji...@apache.org> on 2006/07/02 10:41:16 UTC

[jira] Commented: (WW-1368) theme.properties not read from filesystem

    [ http://issues.apache.org/struts/browse/WW-1368?page=comments#action_37632 ] 

tm_jee commented on WW-1368:
----------------------------

fixed. changes are at :-

Sending        src/main/java/org/apache/struts2/components/template/BaseTemplateEngine.java
Adding         src/test/java/org/apache/struts2/components/template
Adding         src/test/java/org/apache/struts2/components/template/BaseTemplateEngineTest.java
Adding         src/test/resources/org/apache/struts2/components/template
Adding         src/test/resources/org/apache/struts2/components/template/dummy.properties
Adding         src/test/resources/org/apache/struts2/components/template/theme1
Adding         src/test/resources/org/apache/struts2/components/template/theme1/themeThroughClassPath.properties
Adding         src/test/resources/org/apache/struts2/components/template/theme1/themeThroughFileSystem.properties
Transmitting file data .....
Committed revision 418563.

kindly review. thx

> theme.properties not read from filesystem
> -----------------------------------------
>
>          Key: WW-1368
>          URL: http://issues.apache.org/struts/browse/WW-1368
>      Project: Struts 2
>         Type: Bug

>   Components: Views
>     Versions: WW 2.2.2
>     Reporter: tm_jee
>     Assignee: tm_jee
>      Fix For: 2.0.0

>
> In BaseTemplateEngine.getThemeProps(), theme.properties is only loaded from the classpath. However, the theme spec generally implies that templates will be read from the filesystem first, and the classpath as a fallback. The theme.properties file currently has to exist in the classpath even if other templates are on the filesystem.
> getThemeProps should attempt to resolve theme.properties on the file system first, then on the classpath. 
> This is created in relation to a bug reported in WW2 at http://jira.opensymphony.com/browse/WW-1292

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/struts/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira