You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by "jmjoy (via GitHub)" <gi...@apache.org> on 2023/02/12 09:42:46 UTC
[GitHub] [skywalking-rust] jmjoy opened a new pull request, #54: Use stream to collect for grpc reporter.
jmjoy opened a new pull request, #54:
URL: https://github.com/apache/skywalking-rust/pull/54
In the past, for convenience, `collect` was called every time the data was received.
Now it is changed to stream mode, and only call `collect` once, which should improve the performance.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-rust] jmjoy commented on pull request #54: Use stream to collect for grpc reporter.
Posted by "jmjoy (via GitHub)" <gi...@apache.org>.
jmjoy commented on PR #54:
URL: https://github.com/apache/skywalking-rust/pull/54#issuecomment-1427192386
> Is this a gRPC stream? If so, gRPC stream should be completed for a bulk. Keeping a stream always open may have side effect, and cause too much load to maintain the uncompleted status.
OK, will adjust.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-rust] jmjoy commented on pull request #54: Use stream to collect for grpc reporter.
Posted by "jmjoy (via GitHub)" <gi...@apache.org>.
jmjoy commented on PR #54:
URL: https://github.com/apache/skywalking-rust/pull/54#issuecomment-1427227426
I want to adjust it as follows:
Every 30 seconds, the stream will end, and then `collect` will be called again. How about that?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-rust] wu-sheng commented on pull request #54: Use stream to collect for grpc reporter.
Posted by "wu-sheng (via GitHub)" <gi...@apache.org>.
wu-sheng commented on PR #54:
URL: https://github.com/apache/skywalking-rust/pull/54#issuecomment-1427010053
Is this a gRPC stream? If so, gRPC stream should be completed for a bulk. Keeping a stream always open may have side effect, and cause too much load to maintain the uncompleted status.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-rust] wu-sheng commented on pull request #54: Use stream to collect for grpc reporter.
Posted by "wu-sheng (via GitHub)" <gi...@apache.org>.
wu-sheng commented on PR #54:
URL: https://github.com/apache/skywalking-rust/pull/54#issuecomment-1427197953
Ref this.
https://github.com/apache/skywalking/blob/master/oap-server/server-receiver-plugin/skywalking-trace-receiver-plugin/src/main/java/org/apache/skywalking/oap/server/receiver/trace/provider/handler/v8/grpc/TraceSegmentReportServiceHandler.java#L63
If you are going to implement `push Command for downstream/agent`. `OnComplete` is a trigger point. Not through trace segment report, but other gRPC service. And backend self-telemetry relies on this to summary statistics.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-rust] codecov-commenter commented on pull request #54: Use stream to collect for grpc reporter.
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #54:
URL: https://github.com/apache/skywalking-rust/pull/54#issuecomment-1426987265
# [Codecov](https://codecov.io/gh/apache/skywalking-rust/pull/54?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#54](https://codecov.io/gh/apache/skywalking-rust/pull/54?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (650f76f) into [master](https://codecov.io/gh/apache/skywalking-rust/commit/7d4b3797a9a3c76047b53bb213a5449a9c07f978?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (7d4b379) will **increase** coverage by `0.21%`.
> The diff coverage is `0.00%`.
```diff
@@ Coverage Diff @@
## master #54 +/- ##
==========================================
+ Coverage 17.51% 17.73% +0.21%
==========================================
Files 17 17
Lines 571 564 -7
==========================================
Hits 100 100
+ Misses 471 464 -7
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking-rust/pull/54?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [src/reporter/grpc.rs](https://codecov.io/gh/apache/skywalking-rust/pull/54?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL3JlcG9ydGVyL2dycGMucnM=) | `0.00% <0.00%> (ø)` | |
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-rust] wu-sheng commented on pull request #54: Use stream to collect for grpc reporter.
Posted by "wu-sheng (via GitHub)" <gi...@apache.org>.
wu-sheng commented on PR #54:
URL: https://github.com/apache/skywalking-rust/pull/54#issuecomment-1427235483
> I want to adjust it as follows:
>
> Every 30 seconds, the stream will end, and then `collect` will be called again. How about that?
You could control it according to rust implementation. Just keep it neither always open, nor keep open/close for every segment.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-rust] wu-sheng merged pull request #54: Use stream and completed for a bulk to collect for grpc reporter.
Posted by "wu-sheng (via GitHub)" <gi...@apache.org>.
wu-sheng merged PR #54:
URL: https://github.com/apache/skywalking-rust/pull/54
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org