You are viewing a plain text version of this content. The canonical link for it is here.
Posted to bugs@httpd.apache.org by bu...@apache.org on 2021/12/01 14:54:55 UTC
[Bug 65717] New: Missing check for the return value of BIO_new()
https://bz.apache.org/bugzilla/show_bug.cgi?id=65717
Bug ID: 65717
Summary: Missing check for the return value of BIO_new()
Product: Apache httpd-2
Version: 2.5-HEAD
Hardware: PC
OS: All
Status: NEW
Severity: normal
Priority: P2
Component: mod_ssl
Assignee: bugs@httpd.apache.org
Reporter: xkernel.wang@foxmail.com
Target Milestone: ---
Missing a check for the return value of BIO_new() in
https://github.com/apache/httpd/blob/d002199454f8bc841509cdffad1c695eeae2ca7e/modules/ssl/ssl_engine_vars.c#L1159
which may further result in wrong memory access when an internal memory error
happens in BIO_new().
This bug is at least from 2.4.51 in
httpd-2.4.51/modules/ssl/ssl_engine_vars.c:1086:24.
Similarly, there are several missing checks for BIO_new() in
https://github.com/apache/httpd/blob/4d8f1f96b6e6e47a822a8e0d4c3f59d76b38ee87/modules/ssl/ssl_engine_io.c#L2290
& 2292 & 2325 & 2327. And in 2.4.51, they are located in
httpd-2.4.51/modules/ssl/ssl_engine_io.c:2193 & 2195 & 2228 & 2230,
respectively.
Once BIO_new() returns NULL, these places will make wrong memory access and
even result in corruption if lack of a valid check for BIO_new().
--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: bugs-unsubscribe@httpd.apache.org
For additional commands, e-mail: bugs-help@httpd.apache.org
[Bug 65717] Missing check for the return value of BIO_new()
Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=65717
--- Comment #2 from Giovanni Bechis <gi...@paclan.it> ---
Created attachment 38135
--> https://bz.apache.org/bugzilla/attachment.cgi?id=38135&action=edit
check BIO_new allocations
Check for memory allocations from BIO_new.
--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: bugs-unsubscribe@httpd.apache.org
For additional commands, e-mail: bugs-help@httpd.apache.org
[Bug 65717] Missing check for the return value of BIO_new()
Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=65717
Xiaoke Wang <xk...@foxmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Resolution|--- |FIXED
Status|NEW |RESOLVED
--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: bugs-unsubscribe@httpd.apache.org
For additional commands, e-mail: bugs-help@httpd.apache.org
[Bug 65717] Missing check for the return value of BIO_new()
Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=65717
--- Comment #1 from xkernel <xk...@foxmail.com> ---
Another one:
In the version of 2.4.51: httpd-2.4.51/modules/ssl/ssl_util_ocsp.c:38:11.
In current Github repository:
https://github.com/apache/httpd/blob/c9f1a0a3010032e666bd6fecbad0c66d427d3f67/modules/ssl/ssl_util_ocsp.c#L38
Though this seems like a test file, it is worth fixing it with the other
locations together.
--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: bugs-unsubscribe@httpd.apache.org
For additional commands, e-mail: bugs-help@httpd.apache.org
[Bug 65717] Missing check for the return value of BIO_new()
Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=65717
Giovanni Bechis <gi...@paclan.it> changed:
What |Removed |Added
----------------------------------------------------------------------------
Keywords| |FixedInTrunk
--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: bugs-unsubscribe@httpd.apache.org
For additional commands, e-mail: bugs-help@httpd.apache.org