You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by GitBox <gi...@apache.org> on 2020/03/25 18:50:04 UTC
[GitHub] [camel-website] CynthiaOmovoiye opened a new pull request #272:
Pull contributor data from JSON APIs
CynthiaOmovoiye opened a new pull request #272: Pull contributor data from JSON APIs
URL: https://github.com/apache/camel-website/pull/272
CAMEL 13894- Pull contributor data from JSON APIs
I have been able to pull all required data from the JSON files into the team page for Committers. I have also been able to set the GitHub API that extracts the collaborators data from the repository and rendered it to display on the team page. However, it will require a GitHub access token from the Apache GitHub account for the data to be displayed but I was able to generate one on my forked repository of the Apache camel website for testing. Thus, if an access token generated by an admin of the Apache camel website repository is inputted in the field I have made available for it in(" /layouts/shortcodes/contributors.html " **{{$token :=" "}}**), we would be able get the data of the collaborators displayed on the web page.
.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-website] zregvart commented on a change in pull request
#272: Pull contributor data from JSON APIs
Posted by GitBox <gi...@apache.org>.
zregvart commented on a change in pull request #272: Pull contributor data from JSON APIs
URL: https://github.com/apache/camel-website/pull/272#discussion_r398633172
##########
File path: layouts/shortcodes/committers.html
##########
@@ -0,0 +1,26 @@
+{{ $urlPre := "https://projects.apache.org" }}
+{{ $path := "/json/foundation" }}
+{{ $group := getJSON $urlPre $path "/groups.json"}}
+{{ $name := getJSON $urlPre $path "/people_name.json" }}
+{{$orgnisations := getJSON "data/teamdata.json" }}
+
+<table class="tableblock frame-all grid-all stretch">
+ <thead>
+ <tr>
+ <th>Name</th>
+ <th>ID</th>
+ <th>Organisation</th>
+ </tr>
+ </thead>
+ <tbody>
+ {{range $group.camel}}
+ {{ $id:= . }}
+ <tr>
+ <td>{{index $name $id}}</td>
+ <td>{{$id}}</td>
+ <td>{{index $orgnisations $id}} </td>
+ </tr>
+ {{end}}
+
+ </tbody>
+</table>
Review comment:
Add a newline at EOF
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-website] zregvart commented on a change in pull request
#272: Pull contributor data from JSON APIs
Posted by GitBox <gi...@apache.org>.
zregvart commented on a change in pull request #272: Pull contributor data from JSON APIs
URL: https://github.com/apache/camel-website/pull/272#discussion_r398625776
##########
File path: layouts/shortcodes/committers.html
##########
@@ -0,0 +1,26 @@
+{{ $urlPre := "https://projects.apache.org" }}
+{{ $path := "/json/foundation" }}
+{{ $group := getJSON $urlPre $path "/groups.json"}}
Review comment:
Why not even simpler?
```suggestion
{{ $groups := getJSON "https://projects.apache.org/json/foundation/groups.json"}}
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-website] CynthiaOmovoiye removed a comment on issue #272:
Pull contributor data from JSON APIs
Posted by GitBox <gi...@apache.org>.
CynthiaOmovoiye removed a comment on issue #272: Pull contributor data from JSON APIs
URL: https://github.com/apache/camel-website/pull/272#issuecomment-604983182
Hi Zoran,
Thank you for your feedback, I have been able to effect your corrections
and I have been able to pull the Contributors data and have it display on
the page but I am concerned that the **information** retrieved from this
data do not correspond with the information already listed in the
Contributors section on the team.md page. Is there somewhere else to pull
this data from or can I go on with what I have? Thank you.
With kind regards,
Cynthia.
On Thu, Mar 26, 2020, 4:08 PM Zoran Regvart <no...@github.com>
wrote:
> *@zregvart* commented on this pull request.
> ------------------------------
>
> In content/community/team.md
> <https://github.com/apache/camel-website/pull/272#discussion_r398647711>:
>
> > -| Pascal Schumacher | pascalschumacher | |
>
> -| Peter Palaga | ppalaga | Red Hat |
>
> -| Rich Newcomb | rnewcomb | |
>
> -| Richard Kettelerij | rickette | Avisi BV |
>
> -| Rob Davies | rajdavies | |
>
> -| Roman Kalukiewicz | romkal | |
>
> -| Scott England-Sullivan | sully6768 | Red Hat |
>
> -| Stan Lewis | slewis | Red Hat |
>
> -| Tadayoshi Sato | tsato | Red Hat |
>
> -| Tomohisa Igarashi | igarashitm | Red Hat |
>
> -| Tracy Snell | tjsnell | Juice Labs |
>
> -| Willem Jiang | ningjiang | Huawei |
>
> -| William Tam | wtam | Red Hat |
>
> -| Zoran Regvart | zregvart | Red Hat |
>
> -{{< /table >}}
>
> +# Contributors
>
>
> This is fixed with #265 <https://github.com/apache/camel-website/pull/265>,
> make sure you rebase on that. I think the issue is with non breaking white
> space.
>
> —
> You are receiving this because you authored the thread.
> Reply to this email directly, view it on GitHub
> <https://github.com/apache/camel-website/pull/272#discussion_r398647711>,
> or unsubscribe
> <https://github.com/notifications/unsubscribe-auth/AL3476HLTIELDZZB4NMHU63RJNVXFANCNFSM4LTVRMCQ>
> .
>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-website] zregvart commented on a change in pull request
#272: Pull contributor data from JSON APIs
Posted by GitBox <gi...@apache.org>.
zregvart commented on a change in pull request #272: Pull contributor data from JSON APIs
URL: https://github.com/apache/camel-website/pull/272#discussion_r398634528
##########
File path: layouts/shortcodes/contributors.html
##########
@@ -0,0 +1,32 @@
+{{ $urlPre := "https://api.github.com/repos" }}
+{{ $username := "Apache" }}
+{{ $repo := "camel-website"}}
+{{ $token := ""}}
+<!-- Enter token here -->
+{{ $scope := "all"}}
+{{ if eq $token "" }}
+<p>Unable to get contributors details[set token]</p>
+{{else}}
+{{ $collaborators := getJSON $urlPre "/" $username "/" $repo "/collaborators?access_token=" $token }}
+
+<table class="tableblock frame-all grid-all stretch">
+ <thead>
+ <tr>
+ <th>Name</th>
+ <th>Organisation</th>
Review comment:
I'd use non British spelling, seems to be more commonly used
```suggestion
<th>Organization</th>
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-website] CynthiaOmovoiye commented on a change in pull
request #272: Pull contributor data from JSON APIs
Posted by GitBox <gi...@apache.org>.
CynthiaOmovoiye commented on a change in pull request #272: Pull contributor data from JSON APIs
URL: https://github.com/apache/camel-website/pull/272#discussion_r400456689
##########
File path: data/teamdata.json
##########
@@ -0,0 +1,61 @@
+{
+ "ammulder": "Chariot Solutions",
+ "ay": "SAP",
+ "acosentino": "Red Hat",
+ " astefanutti": " Red Hat",
+ "bvahdat": "Cyberlogic Consulting GmbH",
+ "boday": "Initek Consulting",
+ "bibryam": "Red Hat",
+ "bsnyder": " ",
+ "cmoulliard": "Red Hat",
+ "cmueller": "Amazon Web Services",
+ "ceposta": "Red Hat",
+ "cschne\"id\"er": "",
+ "davsclaus": "Red Hat",
+ "coheigea": "Talend",
+ "djencks": "IBM ",
+ "dkulp": "Talend",
+ "distomin": "",
+ "dmvolod": "Red Hat",
+ "forsthofer": "SAP",
+ "ffang": "Red Hat",
+ "gtully": "Red Hat",
+ "gertv": " ",
+ "gzurowski": "Sotheby’s",
+ "gnodet": "Red Hat",
+ "hadrian": "",
+ "hekonsek": "",
+ "chirino": "Red Hat",
+ "iocanel": "Red Hat",
+ "jlaskowski": " ",
+ "jcarman": "Savoir Technologies",
+ "janbednar": "CGI IT Czech Republic",
+ "jbonofre": "Talend",
+ "jgenender": "Savoir Technologies",
+ "joed": "Savoir Technologies",
+ "": " Red Hat",
Review comment:
Is it with reference to a particular line or the entire document?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-website] zregvart commented on a change in pull request
#272: Pull contributor data from JSON APIs
Posted by GitBox <gi...@apache.org>.
zregvart commented on a change in pull request #272: Pull contributor data from JSON APIs
URL: https://github.com/apache/camel-website/pull/272#discussion_r400361300
##########
File path: data/teamdata.json
##########
@@ -0,0 +1,61 @@
+{
+ "ammulder": "Chariot Solutions",
+ "ay": "SAP",
+ "acosentino": "Red Hat",
+ " astefanutti": " Red Hat",
Review comment:
leading space
```suggestion
"astefanutti": " Red Hat",
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-website] zregvart commented on a change in pull request
#272: Pull contributor data from JSON APIs
Posted by GitBox <gi...@apache.org>.
zregvart commented on a change in pull request #272: Pull contributor data from JSON APIs
URL: https://github.com/apache/camel-website/pull/272#discussion_r398633048
##########
File path: layouts/shortcodes/contributors.html
##########
@@ -0,0 +1,32 @@
+{{ $urlPre := "https://api.github.com/repos" }}
+{{ $username := "Apache" }}
+{{ $repo := "camel-website"}}
+{{ $token := ""}}
+<!-- Enter token here -->
+{{ $scope := "all"}}
+{{ if eq $token "" }}
+<p>Unable to get contributors details[set token]</p>
+{{else}}
+{{ $collaborators := getJSON $urlPre "/" $username "/" $repo "/collaborators?access_token=" $token }}
Review comment:
Needs to be cleaned up considerably, based on the last discussion we had token is not required; this also has unused variables. Could be made considerably simpler.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-website] CynthiaOmovoiye commented on a change in pull
request #272: Pull contributor data from JSON APIs
Posted by GitBox <gi...@apache.org>.
CynthiaOmovoiye commented on a change in pull request #272: Pull contributor data from JSON APIs
URL: https://github.com/apache/camel-website/pull/272#discussion_r401210907
##########
File path: config.toml
##########
@@ -12,6 +12,7 @@ timeout = 300000
socialProfiles = ["https://twitter.com/ApacheCamel"]
organizationLogo = "https://camel.apache.org/_/img/logo-d.svg"
organizationDescription = "Apache Camel ™ is a versatile open-source integration framework based on known Enterprise Integration Patterns. Camel empowers you to define routing and mediation rules in a variety of domain-specific languages, including a Java-based Fluent API, Spring or Blueprint XML Configuration files, and a Scala DSL."
+ token = "3656a8b91e08cbd62a3d92ba09360a8d0f233216"
Review comment:
I opened a new pull request referencing the corrections for this pull request on #298 .
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-website] zregvart commented on a change in pull request
#272: Pull contributor data from JSON APIs
Posted by GitBox <gi...@apache.org>.
zregvart commented on a change in pull request #272: Pull contributor data from JSON APIs
URL: https://github.com/apache/camel-website/pull/272#discussion_r400441206
##########
File path: layouts/shortcodes/contributors.html
##########
@@ -0,0 +1,32 @@
+{{ $urlPre := "https://api.github.com/repos" }}
+{{ $username := "Apache" }}
+{{ $repo := "camel-website"}}
+{{ $token := ""}}
+<!-- Enter token here -->
+{{ $scope := "all"}}
+{{ if eq $token "" }}
+<p>Unable to get contributors details[set token]</p>
+{{else}}
+{{ $collaborators := getJSON $urlPre "/" $username "/" $repo "/collaborators?access_token=" $token }}
Review comment:
There are two sources of data: from apache.org and GitHub. From apache.org we can get the committers and project management committee members and from GitHub we can get contributors. On GitHub some of the contributors are also committers and project management committee members.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-website] CynthiaOmovoiye closed pull request #272: Pull
contributor data from JSON APIs
Posted by GitBox <gi...@apache.org>.
CynthiaOmovoiye closed pull request #272: Pull contributor data from JSON APIs
URL: https://github.com/apache/camel-website/pull/272
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-website] zregvart commented on a change in pull request
#272: Pull contributor data from JSON APIs
Posted by GitBox <gi...@apache.org>.
zregvart commented on a change in pull request #272: Pull contributor data from JSON APIs
URL: https://github.com/apache/camel-website/pull/272#discussion_r401163680
##########
File path: config.toml
##########
@@ -12,6 +12,7 @@ timeout = 300000
socialProfiles = ["https://twitter.com/ApacheCamel"]
organizationLogo = "https://camel.apache.org/_/img/logo-d.svg"
organizationDescription = "Apache Camel ™ is a versatile open-source integration framework based on known Enterprise Integration Patterns. Camel empowers you to define routing and mediation rules in a variety of domain-specific languages, including a Java-based Fluent API, Spring or Blueprint XML Configuration files, and a Scala DSL."
+ token = "3656a8b91e08cbd62a3d92ba09360a8d0f233216"
Review comment:
@CynthiaOmovoiye make sure you revoke this token
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-website] zregvart commented on a change in pull request
#272: Pull contributor data from JSON APIs
Posted by GitBox <gi...@apache.org>.
zregvart commented on a change in pull request #272: Pull contributor data from JSON APIs
URL: https://github.com/apache/camel-website/pull/272#discussion_r400361123
##########
File path: data/teamdata.json
##########
@@ -0,0 +1,61 @@
+{
+ "ammulder": "Chariot Solutions",
+ "ay": "SAP",
+ "acosentino": "Red Hat",
+ " astefanutti": " Red Hat",
+ "bvahdat": "Cyberlogic Consulting GmbH",
+ "boday": "Initek Consulting",
+ "bibryam": "Red Hat",
+ "bsnyder": " ",
+ "cmoulliard": "Red Hat",
+ "cmueller": "Amazon Web Services",
+ "ceposta": "Red Hat",
+ "cschne\"id\"er": "",
+ "davsclaus": "Red Hat",
+ "coheigea": "Talend",
+ "djencks": "IBM ",
+ "dkulp": "Talend",
+ "distomin": "",
+ "dmvolod": "Red Hat",
+ "forsthofer": "SAP",
+ "ffang": "Red Hat",
+ "gtully": "Red Hat",
+ "gertv": " ",
+ "gzurowski": "Sotheby’s",
+ "gnodet": "Red Hat",
+ "hadrian": "",
+ "hekonsek": "",
+ "chirino": "Red Hat",
+ "iocanel": "Red Hat",
+ "jlaskowski": " ",
+ "jcarman": "Savoir Technologies",
+ "janbednar": "CGI IT Czech Republic",
+ "jbonofre": "Talend",
+ "jgenender": "Savoir Technologies",
+ "joed": "Savoir Technologies",
+ "": " Red Hat",
Review comment:
Can this be removed?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-website] zregvart commented on a change in pull request
#272: Pull contributor data from JSON APIs
Posted by GitBox <gi...@apache.org>.
zregvart commented on a change in pull request #272: Pull contributor data from JSON APIs
URL: https://github.com/apache/camel-website/pull/272#discussion_r398628424
##########
File path: layouts/shortcodes/committers.html
##########
@@ -0,0 +1,26 @@
+{{ $urlPre := "https://projects.apache.org" }}
+{{ $path := "/json/foundation" }}
+{{ $group := getJSON $urlPre $path "/groups.json"}}
+{{ $name := getJSON $urlPre $path "/people_name.json" }}
+{{$orgnisations := getJSON "data/teamdata.json" }}
+
+<table class="tableblock frame-all grid-all stretch">
Review comment:
I don't see `frame-all` and `grid-all` CSS classes in our CSS, are these needed or are they missing?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-website] zregvart commented on a change in pull request
#272: Pull contributor data from JSON APIs
Posted by GitBox <gi...@apache.org>.
zregvart commented on a change in pull request #272: Pull contributor data from JSON APIs
URL: https://github.com/apache/camel-website/pull/272#discussion_r400355062
##########
File path: layouts/shortcodes/committers.html
##########
@@ -0,0 +1,26 @@
+{{ $urlPre := "https://projects.apache.org" }}
+{{ $path := "/json/foundation" }}
+{{ $group := getJSON $urlPre $path "/groups.json"}}
+{{ $name := getJSON $urlPre $path "/people_name.json" }}
+{{$orgnisations := getJSON "data/teamdata.json" }}
+
+<table class="tableblock frame-all grid-all stretch">
Review comment:
Yeah looks like that was a mistake there, I don't see those classes defined in CSS so we might just as well remove them now.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-website] CynthiaOmovoiye commented on a change in pull
request #272: Pull contributor data from JSON APIs
Posted by GitBox <gi...@apache.org>.
CynthiaOmovoiye commented on a change in pull request #272: Pull contributor data from JSON APIs
URL: https://github.com/apache/camel-website/pull/272#discussion_r399236044
##########
File path: layouts/shortcodes/contributors.html
##########
@@ -0,0 +1,32 @@
+{{ $urlPre := "https://api.github.com/repos" }}
+{{ $username := "Apache" }}
+{{ $repo := "camel-website"}}
+{{ $token := ""}}
+<!-- Enter token here -->
+{{ $scope := "all"}}
+{{ if eq $token "" }}
+<p>Unable to get contributors details[set token]</p>
+{{else}}
+{{ $collaborators := getJSON $urlPre "/" $username "/" $repo "/collaborators?access_token=" $token }}
Review comment:
I have been able to pull the Contributors data and have it display on the page but I am concerned that the names retrieved from this data do not correspond with the names listed in the Contributors section on the team.md page. Is there somewhere else to pull this data from or can I go on with what I have? Thank you.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-website] zregvart commented on a change in pull request
#272: Pull contributor data from JSON APIs
Posted by GitBox <gi...@apache.org>.
zregvart commented on a change in pull request #272: Pull contributor data from JSON APIs
URL: https://github.com/apache/camel-website/pull/272#discussion_r398633452
##########
File path: data/teamdata.json
##########
@@ -0,0 +1,61 @@
+{
+ "ammulder": "Chariot Solutions",
+ "ay": "SAP",
+ "acosentino": "Red Hat",
+ " astefanutti": " Red Hat",
+ "bvahdat": "Cyberlogic Consulting GmbH",
+ "boday": "Initek Consulting",
+ "bibryam": "Red Hat",
+ "bsnyder": " ",
+ "cmoulliard": "Red Hat",
+ "cmueller": "Amazon Web Services",
+ "ceposta": "Red Hat",
+ "cschne\"id\"er": "",
+ "davsclaus": "Red Hat",
+ "coheigea": "Talend",
+ "djencks": "IBM ",
+ "dkulp": "Talend",
+ "distomin": "",
+ "dmvolod": "Red Hat",
+ "forsthofer": "SAP",
+ "ffang": "Red Hat",
+ "gtully": "Red Hat",
+ "gertv": " ",
+ "gzurowski": "Sotheby’s",
+ "gnodet": "Red Hat",
+ "hadrian": "",
+ "hekonsek": "",
+ "chirino": "Red Hat",
+ "iocanel": "Red Hat",
+ "jlaskowski": " ",
+ "jcarman": "Savoir Technologies",
+ "janbednar": "CGI IT Czech Republic",
+ "jbonofre": "Talend",
+ "jgenender": "Savoir Technologies",
+ "joed": "Savoir Technologies",
+ "": " Red Hat",
+ "janstey": "Red Hat",
+ "Red Hat": "",
+ "jstrachan": "",
+ "lburgazzoli": "Red Hat",
+ "krasserm": "",
+ "nsandhu": "",
+ "onders": "",
+ "oalsafi": "Talend",
+ "quinn": "",
+ "raulk": " ",
+ "pascalschumacher": "",
+ "ppalaga": "Red Hat",
+ "rnewcomb": "",
+ "rickette": "Avisi BV",
+ "rajdavies": "",
+ "romkal": "",
+ "sully6768": "Red Hat",
+ "slewis": "Red Hat",
+ "tsato": "Red Hat",
+ "igarashitm": "Red Hat",
+ "tjsnell": " Juice Labs",
+ "ningjiang": "Huawei",
+ "wtam": "Red Hat",
+ "zregvart": "Red Hat"
+}
Review comment:
Add a newline at EOF.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-website] CynthiaOmovoiye commented on a change in pull
request #272: Pull contributor data from JSON APIs
Posted by GitBox <gi...@apache.org>.
CynthiaOmovoiye commented on a change in pull request #272: Pull contributor data from JSON APIs
URL: https://github.com/apache/camel-website/pull/272#discussion_r401209131
##########
File path: config.toml
##########
@@ -12,6 +12,7 @@ timeout = 300000
socialProfiles = ["https://twitter.com/ApacheCamel"]
organizationLogo = "https://camel.apache.org/_/img/logo-d.svg"
organizationDescription = "Apache Camel ™ is a versatile open-source integration framework based on known Enterprise Integration Patterns. Camel empowers you to define routing and mediation rules in a variety of domain-specific languages, including a Java-based Fluent API, Spring or Blueprint XML Configuration files, and a Scala DSL."
+ token = "3656a8b91e08cbd62a3d92ba09360a8d0f233216"
Review comment:
Revoked. Thank you.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-website] zregvart commented on issue #272: Pull contributor
data from JSON APIs
Posted by GitBox <gi...@apache.org>.
zregvart commented on issue #272: Pull contributor data from JSON APIs
URL: https://github.com/apache/camel-website/pull/272#issuecomment-604476715
Preview is [here](https://builds.apache.org/job/Camel.website/job/PR-272/Preview/).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-website] CynthiaOmovoiye commented on a change in pull
request #272: Pull contributor data from JSON APIs
Posted by GitBox <gi...@apache.org>.
CynthiaOmovoiye commented on a change in pull request #272: Pull contributor data from JSON APIs
URL: https://github.com/apache/camel-website/pull/272#discussion_r398854711
##########
File path: layouts/shortcodes/committers.html
##########
@@ -0,0 +1,26 @@
+{{ $urlPre := "https://projects.apache.org" }}
+{{ $path := "/json/foundation" }}
+{{ $group := getJSON $urlPre $path "/groups.json"}}
+{{ $name := getJSON $urlPre $path "/people_name.json" }}
+{{$orgnisations := getJSON "data/teamdata.json" }}
+
+<table class="tableblock frame-all grid-all stretch">
Review comment:
These classes already existed in /layout/shortcodes/table.html and can be traced to this [commit](https://github.com/apache/camel-website/commit/3352d32f6e8299fa78c31ae393ac247ceeb01c84).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-website] zregvart commented on a change in pull request
#272: Pull contributor data from JSON APIs
Posted by GitBox <gi...@apache.org>.
zregvart commented on a change in pull request #272: Pull contributor data from JSON APIs
URL: https://github.com/apache/camel-website/pull/272#discussion_r398638782
##########
File path: content/community/team.md
##########
@@ -5,172 +5,9 @@ title: "Team"
This page lists who we are. By all means add yourself to the list - lets sort it in alphabetical order
# Committers
+{{< committers >}}
-When posting to the mailing lists, use plain text mails. Do not use HTML mails. HTML mails is more likely to be targeted as spam mails and will be rejected; as well it's not easily readable by others.
-{{< table >}}
-| Name | ID | Organisation |
-|-------|----|--------------|
-| Aaron Mulder | ammulder | Chariot Solutions |
-| Akitoshi Yoshida | ay | SAP |
-| Andrea Cosentino | acosentino | Red Hat |
-| Antonin Stefanutti | astefanutti | Red Hat |
-| Babak Vahdat | bvahdat | Cyberlogic Consulting GmbH |
-| Ben O'Day | boday | Initek Consulting |
-| Bilgin Ibryam | bibryam | Red Hat |
-| Bruce Snyder | bsnyder | |
-| Charles Moulliard | cmoulliard | Red Hat
-| Christian Mueller | cmueller | Amazon Web Services |
-| Christian Posta | ceposta | Red Hat |
-| Christian Schneider | cschneider
-| Claus Ibsen | davsclaus | Red Hat |
-| Colm O hEigeartaigh | coheigea | Talend |
-| David Jencks | djencks | IBM |
-| Daniel Kulp | dkulp | Talend |
-| Denis Istomin | distomin | |
-| Dmitry Volodin | dmvolod | Red Hat |
-| Franz Forsthofer | forsthofer | SAP |
-| Freeman Fang | ffang | Red Hat |
-| Gary Tully | gtully | Red Hat |
-| Gert Vanthienen | gertv | |
-| Gregor Zurowski | gzurowski | Sotheby's |
-| Guillaume Nodet | gnodet | Red Hat |
-| Hadrian Zbarcea | hadrian | |
-| Henryk Konsek | hekonsek | |
-| Hiram Chirino | chirino | Red Hat |
-| Ioannis Canellos | iocanel | Red Hat |
-| Jacek Laskowski | jlaskowski | |
-| James Carman | jcarman | Savoir Technologies |
-| Jan Bednar | janbednar | CGI IT Czech Republic |
-| Jean-Baptiste Onofré | jbonofre | Talend |
-| Jeff Genender | jgenender | Savoir Technologies |
-| Johan Edstrom | joed | Savoir Technologies |
-| John Poth | | Red Hat |
-| Jonathan Anstey | janstey | Red Hat |
-| James Netherton | Red Hat | |
-| James Strachan | jstrachan | |
-| Luca Burgazzoli | lburgazzoli | Red Hat |
-| Martin Krasser | krasserm | |
-| Nicky Sandhu | nsandhu | |
-| Onder Sezgin | onders | |
-| Omar Al-Safi | oalsafi | Talend |
-| Quinn Stevenson | quinn | |
-| Raul Kripalani | raulk | |
-| Pascal Schumacher | pascalschumacher | |
-| Peter Palaga | ppalaga | Red Hat |
-| Rich Newcomb | rnewcomb | |
-| Richard Kettelerij | rickette | Avisi BV |
-| Rob Davies | rajdavies | |
-| Roman Kalukiewicz | romkal | |
-| Scott England-Sullivan | sully6768 | Red Hat |
-| Stan Lewis | slewis | Red Hat |
-| Tadayoshi Sato | tsato | Red Hat |
-| Tomohisa Igarashi | igarashitm | Red Hat |
-| Tracy Snell | tjsnell | Juice Labs |
-| Willem Jiang | ningjiang | Huawei |
-| William Tam | wtam | Red Hat |
-| Zoran Regvart | zregvart | Red Hat |
-{{< /table >}}
+# Contributors
Review comment:
For some reason this is not rendered as a heading but literally (see preview)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-website] zregvart edited a comment on issue #272: Pull
contributor data from JSON APIs
Posted by GitBox <gi...@apache.org>.
zregvart edited a comment on issue #272: Pull contributor data from JSON APIs
URL: https://github.com/apache/camel-website/pull/272#issuecomment-604476715
Preview is [here](https://builds.apache.org/job/Camel.website/job/PR-272/Preview/community/team/).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-website] zregvart commented on a change in pull request
#272: Pull contributor data from JSON APIs
Posted by GitBox <gi...@apache.org>.
zregvart commented on a change in pull request #272: Pull contributor data from JSON APIs
URL: https://github.com/apache/camel-website/pull/272#discussion_r398627052
##########
File path: layouts/shortcodes/committers.html
##########
@@ -0,0 +1,26 @@
+{{ $urlPre := "https://projects.apache.org" }}
+{{ $path := "/json/foundation" }}
+{{ $group := getJSON $urlPre $path "/groups.json"}}
+{{ $name := getJSON $urlPre $path "/people_name.json" }}
+{{$orgnisations := getJSON "data/teamdata.json" }}
Review comment:
I'd prefer simpler and more descriptive variable names
```suggestion
{{ $people_names := getJSON "https://projects.apache.org/json/foundation/people_name.json" }}
{{ $team_data := getJSON "data/teamdata.json" }}
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-website] zregvart commented on a change in pull request
#272: Pull contributor data from JSON APIs
Posted by GitBox <gi...@apache.org>.
zregvart commented on a change in pull request #272: Pull contributor data from JSON APIs
URL: https://github.com/apache/camel-website/pull/272#discussion_r398633629
##########
File path: layouts/shortcodes/contributors.html
##########
@@ -0,0 +1,32 @@
+{{ $urlPre := "https://api.github.com/repos" }}
+{{ $username := "Apache" }}
+{{ $repo := "camel-website"}}
+{{ $token := ""}}
+<!-- Enter token here -->
+{{ $scope := "all"}}
+{{ if eq $token "" }}
+<p>Unable to get contributors details[set token]</p>
+{{else}}
+{{ $collaborators := getJSON $urlPre "/" $username "/" $repo "/collaborators?access_token=" $token }}
+
+<table class="tableblock frame-all grid-all stretch">
+ <thead>
+ <tr>
+ <th>Name</th>
+ <th>Organisation</th>
+ </tr>
+ </thead>
+ <tbody>
+
+ {{range $collaborators}}
+ {{$user := getJSON .url}}
+ {{if $user.name }}
+ <tr>
+ <td> {{$user.name}} </td>
+ <td> {{$user.company}} </td>
+ </tr>
+ {{end}}
+ {{end}}
+ </tbody>
+</table>
+{{end}}
Review comment:
Add newline at EOF.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-website] CynthiaOmovoiye commented on a change in pull
request #272: Pull contributor data from JSON APIs
Posted by GitBox <gi...@apache.org>.
CynthiaOmovoiye commented on a change in pull request #272: Pull contributor data from JSON APIs
URL: https://github.com/apache/camel-website/pull/272#discussion_r400456689
##########
File path: data/teamdata.json
##########
@@ -0,0 +1,61 @@
+{
+ "ammulder": "Chariot Solutions",
+ "ay": "SAP",
+ "acosentino": "Red Hat",
+ " astefanutti": " Red Hat",
+ "bvahdat": "Cyberlogic Consulting GmbH",
+ "boday": "Initek Consulting",
+ "bibryam": "Red Hat",
+ "bsnyder": " ",
+ "cmoulliard": "Red Hat",
+ "cmueller": "Amazon Web Services",
+ "ceposta": "Red Hat",
+ "cschne\"id\"er": "",
+ "davsclaus": "Red Hat",
+ "coheigea": "Talend",
+ "djencks": "IBM ",
+ "dkulp": "Talend",
+ "distomin": "",
+ "dmvolod": "Red Hat",
+ "forsthofer": "SAP",
+ "ffang": "Red Hat",
+ "gtully": "Red Hat",
+ "gertv": " ",
+ "gzurowski": "Sotheby’s",
+ "gnodet": "Red Hat",
+ "hadrian": "",
+ "hekonsek": "",
+ "chirino": "Red Hat",
+ "iocanel": "Red Hat",
+ "jlaskowski": " ",
+ "jcarman": "Savoir Technologies",
+ "janbednar": "CGI IT Czech Republic",
+ "jbonofre": "Talend",
+ "jgenender": "Savoir Technologies",
+ "joed": "Savoir Technologies",
+ "": " Red Hat",
Review comment:
Is it with reference to a particular line or the entire document?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-website] CynthiaOmovoiye commented on issue #272: Pull
contributor data from JSON APIs
Posted by GitBox <gi...@apache.org>.
CynthiaOmovoiye commented on issue #272: Pull contributor data from JSON APIs
URL: https://github.com/apache/camel-website/pull/272#issuecomment-604983182
Hi Zoran,
Thank you for your feedback, I have been able to effect your corrections
and I have been able to pull the Contributors data and have it display on
the page but I am concerned that the **information** retrieved from this
data do not correspond with the information already listed in the
Contributors section on the team.md page. Is there somewhere else to pull
this data from or can I go on with what I have? Thank you.
With kind regards,
Cynthia.
On Thu, Mar 26, 2020, 4:08 PM Zoran Regvart <no...@github.com>
wrote:
> *@zregvart* commented on this pull request.
> ------------------------------
>
> In content/community/team.md
> <https://github.com/apache/camel-website/pull/272#discussion_r398647711>:
>
> > -| Pascal Schumacher | pascalschumacher | |
>
> -| Peter Palaga | ppalaga | Red Hat |
>
> -| Rich Newcomb | rnewcomb | |
>
> -| Richard Kettelerij | rickette | Avisi BV |
>
> -| Rob Davies | rajdavies | |
>
> -| Roman Kalukiewicz | romkal | |
>
> -| Scott England-Sullivan | sully6768 | Red Hat |
>
> -| Stan Lewis | slewis | Red Hat |
>
> -| Tadayoshi Sato | tsato | Red Hat |
>
> -| Tomohisa Igarashi | igarashitm | Red Hat |
>
> -| Tracy Snell | tjsnell | Juice Labs |
>
> -| Willem Jiang | ningjiang | Huawei |
>
> -| William Tam | wtam | Red Hat |
>
> -| Zoran Regvart | zregvart | Red Hat |
>
> -{{< /table >}}
>
> +# Contributors
>
>
> This is fixed with #265 <https://github.com/apache/camel-website/pull/265>,
> make sure you rebase on that. I think the issue is with non breaking white
> space.
>
> —
> You are receiving this because you authored the thread.
> Reply to this email directly, view it on GitHub
> <https://github.com/apache/camel-website/pull/272#discussion_r398647711>,
> or unsubscribe
> <https://github.com/notifications/unsubscribe-auth/AL3476HLTIELDZZB4NMHU63RJNVXFANCNFSM4LTVRMCQ>
> .
>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-website] zregvart commented on a change in pull request
#272: Pull contributor data from JSON APIs
Posted by GitBox <gi...@apache.org>.
zregvart commented on a change in pull request #272: Pull contributor data from JSON APIs
URL: https://github.com/apache/camel-website/pull/272#discussion_r400361514
##########
File path: data/teamdata.json
##########
@@ -0,0 +1,61 @@
+{
+ "ammulder": "Chariot Solutions",
+ "ay": "SAP",
+ "acosentino": "Red Hat",
+ " astefanutti": " Red Hat",
+ "bvahdat": "Cyberlogic Consulting GmbH",
+ "boday": "Initek Consulting",
+ "bibryam": "Red Hat",
+ "bsnyder": " ",
+ "cmoulliard": "Red Hat",
+ "cmueller": "Amazon Web Services",
+ "ceposta": "Red Hat",
+ "cschne\"id\"er": "",
+ "davsclaus": "Red Hat",
+ "coheigea": "Talend",
+ "djencks": "IBM ",
+ "dkulp": "Talend",
+ "distomin": "",
+ "dmvolod": "Red Hat",
+ "forsthofer": "SAP",
+ "ffang": "Red Hat",
+ "gtully": "Red Hat",
+ "gertv": " ",
+ "gzurowski": "Sotheby’s",
+ "gnodet": "Red Hat",
+ "hadrian": "",
+ "hekonsek": "",
+ "chirino": "Red Hat",
+ "iocanel": "Red Hat",
+ "jlaskowski": " ",
+ "jcarman": "Savoir Technologies",
+ "janbednar": "CGI IT Czech Republic",
+ "jbonofre": "Talend",
+ "jgenender": "Savoir Technologies",
+ "joed": "Savoir Technologies",
+ "": " Red Hat",
+ "janstey": "Red Hat",
+ "Red Hat": "",
Review comment:
Can this be removed?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-website] zregvart commented on a change in pull request
#272: Pull contributor data from JSON APIs
Posted by GitBox <gi...@apache.org>.
zregvart commented on a change in pull request #272: Pull contributor data from JSON APIs
URL: https://github.com/apache/camel-website/pull/272#discussion_r398629136
##########
File path: layouts/shortcodes/committers.html
##########
@@ -0,0 +1,26 @@
+{{ $urlPre := "https://projects.apache.org" }}
+{{ $path := "/json/foundation" }}
+{{ $group := getJSON $urlPre $path "/groups.json"}}
+{{ $name := getJSON $urlPre $path "/people_name.json" }}
+{{$orgnisations := getJSON "data/teamdata.json" }}
+
+<table class="tableblock frame-all grid-all stretch">
+ <thead>
+ <tr>
+ <th>Name</th>
+ <th>ID</th>
+ <th>Organisation</th>
+ </tr>
+ </thead>
+ <tbody>
+ {{range $group.camel}}
+ {{ $id:= . }}
Review comment:
This could also be simpler as
```suggestion
{{ range $id := $group.camel }}
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-website] zregvart commented on a change in pull request
#272: Pull contributor data from JSON APIs
Posted by GitBox <gi...@apache.org>.
zregvart commented on a change in pull request #272: Pull contributor data from JSON APIs
URL: https://github.com/apache/camel-website/pull/272#discussion_r398647711
##########
File path: content/community/team.md
##########
@@ -5,172 +5,9 @@ title: "Team"
This page lists who we are. By all means add yourself to the list - lets sort it in alphabetical order
# Committers
+{{< committers >}}
-When posting to the mailing lists, use plain text mails. Do not use HTML mails. HTML mails is more likely to be targeted as spam mails and will be rejected; as well it's not easily readable by others.
-{{< table >}}
-| Name | ID | Organisation |
-|-------|----|--------------|
-| Aaron Mulder | ammulder | Chariot Solutions |
-| Akitoshi Yoshida | ay | SAP |
-| Andrea Cosentino | acosentino | Red Hat |
-| Antonin Stefanutti | astefanutti | Red Hat |
-| Babak Vahdat | bvahdat | Cyberlogic Consulting GmbH |
-| Ben O'Day | boday | Initek Consulting |
-| Bilgin Ibryam | bibryam | Red Hat |
-| Bruce Snyder | bsnyder | |
-| Charles Moulliard | cmoulliard | Red Hat
-| Christian Mueller | cmueller | Amazon Web Services |
-| Christian Posta | ceposta | Red Hat |
-| Christian Schneider | cschneider
-| Claus Ibsen | davsclaus | Red Hat |
-| Colm O hEigeartaigh | coheigea | Talend |
-| David Jencks | djencks | IBM |
-| Daniel Kulp | dkulp | Talend |
-| Denis Istomin | distomin | |
-| Dmitry Volodin | dmvolod | Red Hat |
-| Franz Forsthofer | forsthofer | SAP |
-| Freeman Fang | ffang | Red Hat |
-| Gary Tully | gtully | Red Hat |
-| Gert Vanthienen | gertv | |
-| Gregor Zurowski | gzurowski | Sotheby's |
-| Guillaume Nodet | gnodet | Red Hat |
-| Hadrian Zbarcea | hadrian | |
-| Henryk Konsek | hekonsek | |
-| Hiram Chirino | chirino | Red Hat |
-| Ioannis Canellos | iocanel | Red Hat |
-| Jacek Laskowski | jlaskowski | |
-| James Carman | jcarman | Savoir Technologies |
-| Jan Bednar | janbednar | CGI IT Czech Republic |
-| Jean-Baptiste Onofré | jbonofre | Talend |
-| Jeff Genender | jgenender | Savoir Technologies |
-| Johan Edstrom | joed | Savoir Technologies |
-| John Poth | | Red Hat |
-| Jonathan Anstey | janstey | Red Hat |
-| James Netherton | Red Hat | |
-| James Strachan | jstrachan | |
-| Luca Burgazzoli | lburgazzoli | Red Hat |
-| Martin Krasser | krasserm | |
-| Nicky Sandhu | nsandhu | |
-| Onder Sezgin | onders | |
-| Omar Al-Safi | oalsafi | Talend |
-| Quinn Stevenson | quinn | |
-| Raul Kripalani | raulk | |
-| Pascal Schumacher | pascalschumacher | |
-| Peter Palaga | ppalaga | Red Hat |
-| Rich Newcomb | rnewcomb | |
-| Richard Kettelerij | rickette | Avisi BV |
-| Rob Davies | rajdavies | |
-| Roman Kalukiewicz | romkal | |
-| Scott England-Sullivan | sully6768 | Red Hat |
-| Stan Lewis | slewis | Red Hat |
-| Tadayoshi Sato | tsato | Red Hat |
-| Tomohisa Igarashi | igarashitm | Red Hat |
-| Tracy Snell | tjsnell | Juice Labs |
-| Willem Jiang | ningjiang | Huawei |
-| William Tam | wtam | Red Hat |
-| Zoran Regvart | zregvart | Red Hat |
-{{< /table >}}
+# Contributors
Review comment:
This is fixed with #265, make sure you rebase on that. I think the issue is with non breaking white space.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-website] zregvart commented on a change in pull request
#272: Pull contributor data from JSON APIs
Posted by GitBox <gi...@apache.org>.
zregvart commented on a change in pull request #272: Pull contributor data from JSON APIs
URL: https://github.com/apache/camel-website/pull/272#discussion_r398635213
##########
File path: layouts/shortcodes/contributors.html
##########
@@ -0,0 +1,32 @@
+{{ $urlPre := "https://api.github.com/repos" }}
+{{ $username := "Apache" }}
+{{ $repo := "camel-website"}}
+{{ $token := ""}}
+<!-- Enter token here -->
+{{ $scope := "all"}}
+{{ if eq $token "" }}
+<p>Unable to get contributors details[set token]</p>
+{{else}}
+{{ $collaborators := getJSON $urlPre "/" $username "/" $repo "/collaborators?access_token=" $token }}
+
+<table class="tableblock frame-all grid-all stretch">
+ <thead>
+ <tr>
+ <th>Name</th>
+ <th>Organisation</th>
+ </tr>
+ </thead>
+ <tbody>
+
+ {{range $collaborators}}
+ {{$user := getJSON .url}}
+ {{if $user.name }}
+ <tr>
+ <td> {{$user.name}} </td>
+ <td> {{$user.company}} </td>
+ </tr>
+ {{end}}
+ {{end}}
+ </tbody>
+</table>
+{{end}}
Review comment:
We write Hugo template directives with spaces after `{{` and before `}}`, makes it much easier to read.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-website] CynthiaOmovoiye commented on a change in pull
request #272: Pull contributor data from JSON APIs
Posted by GitBox <gi...@apache.org>.
CynthiaOmovoiye commented on a change in pull request #272: Pull contributor data from JSON APIs
URL: https://github.com/apache/camel-website/pull/272#discussion_r398854711
##########
File path: layouts/shortcodes/committers.html
##########
@@ -0,0 +1,26 @@
+{{ $urlPre := "https://projects.apache.org" }}
+{{ $path := "/json/foundation" }}
+{{ $group := getJSON $urlPre $path "/groups.json"}}
+{{ $name := getJSON $urlPre $path "/people_name.json" }}
+{{$orgnisations := getJSON "data/teamdata.json" }}
+
+<table class="tableblock frame-all grid-all stretch">
Review comment:
These classes already existed in /layout/shortcodes/table.html.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-website] zregvart commented on a change in pull request
#272: Pull contributor data from JSON APIs
Posted by GitBox <gi...@apache.org>.
zregvart commented on a change in pull request #272: Pull contributor data from JSON APIs
URL: https://github.com/apache/camel-website/pull/272#discussion_r398631679
##########
File path: layouts/shortcodes/committers.html
##########
@@ -0,0 +1,26 @@
+{{ $urlPre := "https://projects.apache.org" }}
+{{ $path := "/json/foundation" }}
+{{ $group := getJSON $urlPre $path "/groups.json"}}
+{{ $name := getJSON $urlPre $path "/people_name.json" }}
+{{$orgnisations := getJSON "data/teamdata.json" }}
+
+<table class="tableblock frame-all grid-all stretch">
+ <thead>
+ <tr>
+ <th>Name</th>
+ <th>ID</th>
+ <th>Organisation</th>
+ </tr>
+ </thead>
+ <tbody>
+ {{range $group.camel}}
+ {{ $id:= . }}
+ <tr>
+ <td>{{index $name $id}}</td>
+ <td>{{$id}}</td>
+ <td>{{index $orgnisations $id}} </td>
Review comment:
Formatting
```suggestion
<td>{{ index $name $id }}</td>
<td>{{ $id }}</td>
<td>{{ index $orgnisations $id }} </td>
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services