You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tomee.apache.org by GitBox <gi...@apache.org> on 2022/04/13 16:42:14 UTC

[GitHub] [tomee-patch-plugin] rzo1 opened a new pull request, #7: TOMEE-3903 - Investigate *.tar.gz distributions aren't installed correctly to Maven Reposito

rzo1 opened a new pull request, #7:
URL: https://github.com/apache/tomee-patch-plugin/pull/7

   # What does this PR do?
   
   During the first attempt of a release of 8.0.11, voters identified, that *.tar.gz files where missing in dist/dev. Investigations revealed, that they were also missing in the Maven Staging repository.
   
   The build was conducted using Maven in version 3.8.3.
   
   Further digging revealed some warnings regarding artifacts getting **attached** multiple times to the build process. While this works in Maven 3.3.9 without warnings, it breaks in newer Maven versions. In the end, *.tar.gz is deployed as *.jar, which is undefined behaviour.
   
   As TomEE build already attaches the created *.tar.gz files, the patch plugin shouldn't do it again or only if defined by the plugin user.
   
   Therefore, this PR introduces a property `attach` (default: false), which allows the user to define the behaviour. 
   
   Applying this to the TomEE build, we get back the previous behaviour (although using a new Maven version):
   
   - tar.gz goes jar (wrong)
   - tar.gz goes tar.gz (correct)
   
   ```bash
   [INFO] Installing /home/zowallar/Dokumente/work/coding/tomee/tomee/apache-tomee/target/apache-tomee-8.0.12-SNAPSHOT.jar to /home/zowallar/.m2/repository/org/apache/tomee/apache-tomee/8.0.12-SNAPSHOT/apache-tomee-8.0.12-SNAPSHOT.jar
   [INFO] Installing /home/zowallar/Dokumente/work/coding/tomee/tomee/apache-tomee/pom.xml to /home/zowallar/.m2/repository/org/apache/tomee/apache-tomee/8.0.12-SNAPSHOT/apache-tomee-8.0.12-SNAPSHOT.pom
   [INFO] Installing /home/zowallar/Dokumente/work/coding/tomee/tomee/apache-tomee/target/apache-tomee-webprofile-8.0.12-SNAPSHOT.zip to /home/zowallar/.m2/repository/org/apache/tomee/apache-tomee/8.0.12-SNAPSHOT/apache-tomee-8.0.12-SNAPSHOT-webprofile.zip
   [INFO] Installing /home/zowallar/Dokumente/work/coding/tomee/tomee/apache-tomee/target/apache-tomee-webprofile-8.0.12-SNAPSHOT.tar.gz to /home/zowallar/.m2/repository/org/apache/tomee/apache-tomee/8.0.12-SNAPSHOT/apache-tomee-8.0.12-SNAPSHOT-webprofile.tar.gz
   [INFO] Installing /home/zowallar/Dokumente/work/coding/tomee/tomee/apache-tomee/target/apache-tomee-plus-8.0.12-SNAPSHOT.zip to /home/zowallar/.m2/repository/org/apache/tomee/apache-tomee/8.0.12-SNAPSHOT/apache-tomee-8.0.12-SNAPSHOT-plus.zip
   [INFO] Installing /home/zowallar/Dokumente/work/coding/tomee/tomee/apache-tomee/target/apache-tomee-plus-8.0.12-SNAPSHOT.tar.gz to /home/zowallar/.m2/repository/org/apache/tomee/apache-tomee/8.0.12-SNAPSHOT/apache-tomee-8.0.12-SNAPSHOT-plus.tar.gz
   [INFO] Installing /home/zowallar/Dokumente/work/coding/tomee/tomee/apache-tomee/target/apache-tomee-plume-8.0.12-SNAPSHOT.zip to /home/zowallar/.m2/repository/org/apache/tomee/apache-tomee/8.0.12-SNAPSHOT/apache-tomee-8.0.12-SNAPSHOT-plume.zip
   [INFO] Installing /home/zowallar/Dokumente/work/coding/tomee/tomee/apache-tomee/target/apache-tomee-plume-8.0.12-SNAPSHOT.tar.gz to /home/zowallar/.m2/repository/org/apache/tomee/apache-tomee/8.0.12-SNAPSHOT/apache-tomee-8.0.12-SNAPSHOT-plume.tar.gz
   [INFO] Installing /home/zowallar/Dokumente/work/coding/tomee/tomee/apache-tomee/target/apache-tomee-microprofile-8.0.12-SNAPSHOT.zip to /home/zowallar/.m2/repository/org/apache/tomee/apache-tomee/8.0.12-SNAPSHOT/apache-tomee-8.0.12-SNAPSHOT-microprofile.zip
   [INFO] Installing /home/zowallar/Dokumente/work/coding/tomee/tomee/apache-tomee/target/apache-tomee-microprofile-8.0.12-SNAPSHOT.tar.gz to /home/zowallar/.m2/repository/org/apache/tomee/apache-tomee/8.0.12-SNAPSHOT/apache-tomee-8.0.12-SNAPSHOT-microprofile.tar.gz
   ```
   
   instead of the wrong behaviour:
   
   ```bash
   [INFO] Installing /home/zowallar/Dokumente/work/coding/tomee/tomee/apache-tomee/target/apache-tomee-8.0.12-SNAPSHOT.jar to /home/zowallar/.m2/repository/org/apache/tomee/apache-tomee/8.0.12-SNAPSHOT/apache-tomee-8.0.12-SNAPSHOT.jar
   [INFO] Installing /home/zowallar/Dokumente/work/coding/tomee/tomee/apache-tomee/pom.xml to /home/zowallar/.m2/repository/org/apache/tomee/apache-tomee/8.0.12-SNAPSHOT/apache-tomee-8.0.12-SNAPSHOT.pom
   [INFO] Installing /home/zowallar/Dokumente/work/coding/tomee/tomee/apache-tomee/target/apache-tomee-webprofile-8.0.12-SNAPSHOT.zip to /home/zowallar/.m2/repository/org/apache/tomee/apache-tomee/8.0.12-SNAPSHOT/apache-tomee-8.0.12-SNAPSHOT-webprofile.zip
   [INFO] Installing /home/zowallar/Dokumente/work/coding/tomee/tomee/apache-tomee/target/apache-tomee-webprofile-8.0.12-SNAPSHOT.tar.gz to /home/zowallar/.m2/repository/org/apache/tomee/apache-tomee/8.0.12-SNAPSHOT/apache-tomee-8.0.12-SNAPSHOT-webprofile.jar
   [INFO] Installing /home/zowallar/Dokumente/work/coding/tomee/tomee/apache-tomee/target/apache-tomee-plus-8.0.12-SNAPSHOT.zip to /home/zowallar/.m2/repository/org/apache/tomee/apache-tomee/8.0.12-SNAPSHOT/apache-tomee-8.0.12-SNAPSHOT-plus.zip
   [INFO] Installing /home/zowallar/Dokumente/work/coding/tomee/tomee/apache-tomee/target/apache-tomee-plus-8.0.12-SNAPSHOT.tar.gz to /home/zowallar/.m2/repository/org/apache/tomee/apache-tomee/8.0.12-SNAPSHOT/apache-tomee-8.0.12-SNAPSHOT-plus.jar
   [INFO] Installing /home/zowallar/Dokumente/work/coding/tomee/tomee/apache-tomee/target/apache-tomee-plume-8.0.12-SNAPSHOT.zip to /home/zowallar/.m2/repository/org/apache/tomee/apache-tomee/8.0.12-SNAPSHOT/apache-tomee-8.0.12-SNAPSHOT-plume.zip
   [INFO] Installing /home/zowallar/Dokumente/work/coding/tomee/tomee/apache-tomee/target/apache-tomee-plume-8.0.12-SNAPSHOT.tar.gz to /home/zowallar/.m2/repository/org/apache/tomee/apache-tomee/8.0.12-SNAPSHOT/apache-tomee-8.0.12-SNAPSHOT-plume.jar
   [INFO] Installing /home/zowallar/Dokumente/work/coding/tomee/tomee/apache-tomee/target/apache-tomee-microprofile-8.0.12-SNAPSHOT.zip to /home/zowallar/.m2/repository/org/apache/tomee/apache-tomee/8.0.12-SNAPSHOT/apache-tomee-8.0.12-SNAPSHOT-microprofile.zip
   [INFO] Installing /home/zowallar/Dokumente/work/coding/tomee/tomee/apache-tomee/target/apache-tomee-microprofile-8.0.12-SNAPSHOT.tar.gz to /home/zowallar/.m2/repository/org/apache/tomee/apache-tomee/8.0.12-SNAPSHOT/apache-tomee-8.0.12-SNAPSHOT-microprofile.jar
   ```
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@tomee.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [tomee-patch-plugin] rzo1 merged pull request #7: TOMEE-3903 - Investigate *.tar.gz distributions aren't installed correctly to Maven Repository

Posted by GitBox <gi...@apache.org>.
rzo1 merged PR #7:
URL: https://github.com/apache/tomee-patch-plugin/pull/7


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@tomee.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org