You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@httpd.apache.org by Jeff Trawick <tr...@gmail.com> on 2011/09/04 17:29:45 UTC

next steps for range fix in 2.2.x

Can anyone fill in any details for the following?

1. Any known regressions not yet fixed in trunk?
2. Any other issues not yet fixed in trunk?
a. r1163833 needs to be modified/reverted so that 200 is sent instead
of 206 (see discussion for that commit)
3. Need patch for 2.2.x to review/test; needs r1163833 (or
modification) and following from
http://svn.apache.org/viewvc/httpd/httpd/trunk/modules/http/byterange_filter.c?sortby=date&view=log
4. Wait to see if more regressions pop up in the next couple of days

Re: next steps for range fix in 2.2.x

Posted by Stefan Fritsch <sf...@sfritsch.de>.
On Sunday 04 September 2011, Jeff Trawick wrote:
> Can anyone fill in any details for the following?
> 
> 1. Any known regressions not yet fixed in trunk?

> 2. Any other issues not yet fixed in trunk?
> a. r1163833 needs to be modified/reverted so that 200 is sent
> instead of 206 (see discussion for that commit)

Reverted in r1165062. The developers of libavformat (the client of the 
bug reporter) have already committed a fix to their repo to check the 
Accept-Ranges header.

> 3. Need patch for 2.2.x to review/test; needs r1163833 (or
> modification) and following from
> http://svn.apache.org/viewvc/httpd/httpd/trunk/modules/http/byteran
> ge_filter.c?sortby=date&view=log

> 4. Wait to see if more regressions pop up in the next couple of days


Re: next steps for range fix in 2.2.x

Posted by Jim Jagielski <ji...@jaguNET.com>.
Now that the 2.2 stuff looks good, I'll be adding limit control
on the overlaps/reversals to trunk…

On Sep 5, 2011, at 6:37 PM, Jeff Trawick wrote:

> On Mon, Sep 5, 2011 at 3:39 PM, Jim Jagielski <ji...@apache.org> wrote:
>> Looks good to me...
> 
> now in STATUS
> 


Re: next steps for range fix in 2.2.x

Posted by Jeff Trawick <tr...@gmail.com>.
On Mon, Sep 5, 2011 at 3:39 PM, Jim Jagielski <ji...@apache.org> wrote:
> Looks good to me...

now in STATUS

Re: next steps for range fix in 2.2.x

Posted by Jim Jagielski <ji...@apache.org>.
Looks good to me...
On Sep 5, 2011, at 12:17 PM, Jeff Trawick wrote:

> Can anyone familiar with the nitty gritty review
> http://people.apache.org/~trawick/byterange_filter-1163819-through-1165268.txt
> ?
> 
> Here's the diff with trunk after applying:
> 
> http://people.apache.org/~trawick/byterange_filter-1165268-2.2.x-vs-trunk.txt
> 


Re: next steps for range fix in 2.2.x

Posted by Jeff Trawick <tr...@gmail.com>.
Can anyone familiar with the nitty gritty review
http://people.apache.org/~trawick/byterange_filter-1163819-through-1165268.txt
?

Here's the diff with trunk after applying:

http://people.apache.org/~trawick/byterange_filter-1165268-2.2.x-vs-trunk.txt

Re: next steps for range fix in 2.2.x

Posted by Jim Jagielski <ji...@jaguNET.com>.
I can RM 2.2.21… it'll be good to get my mind off some things…

On Sep 5, 2011, at 4:08 AM, Gregg L. Smith wrote:

> On 9/5/2011 12:44 AM, "Plüm, Rüdiger, VF-Group" wrote:
>> 
>> 
>>> -----Original Message-----
>>> From: Jeff Trawick [mailto:trawick@gmail.com]
>>> Sent: Sonntag, 4. September 2011 17:30
>>> To: Apache HTTP Server Development List
>>> Subject: next steps for range fix in 2.2.x
>>> 
>>> Can anyone fill in any details for the following?
>>> 
>>> 1. Any known regressions not yet fixed in trunk?
>>> 2. Any other issues not yet fixed in trunk?
>>> a. r1163833 needs to be modified/reverted so that 200 is sent instead
>>> of 206 (see discussion for that commit)
>>> 3. Need patch for 2.2.x to review/test; needs r1163833 (or
>>> modification) and following from
>>> http://svn.apache.org/viewvc/httpd/httpd/trunk/modules/http/by
>>> terange_filter.c?sortby=date&view=log
>>> 4. Wait to see if more regressions pop up in the next couple of days
>>> 
>> I guess we should wait until mid week for further regression.
>> After that we should create a backport starting from r1163197 until current
>> of byterange_filter.c
>> 
>> Regards
>> 
>> Rüdiger
>> 
> +1
> 
> regressions suck, but the killer is silenced as far as I can tell at this point, the script fails it's internal test, no need to rush and gain more regressions hurrying to fix the regressions from hurrying to silence the killer. My meager view anyway :)
> 
> Regards,
> 
> Gregg
> 
> 
> 
> 


Re: next steps for range fix in 2.2.x

Posted by "William A. Rowe Jr." <wr...@rowe-clan.net>.
On 9/5/2011 3:08 AM, Gregg L. Smith wrote:
> 
> regressions suck, but the killer is silenced as far as I can tell at this point, the
> script fails it's internal test, no need to rush and gain more regressions hurrying to fix
> the regressions from hurrying to silence the killer. My meager view anyway :)

I agree except that we already rushed .20 and suggest somehow that
it is the "best available version of httpd", which is nonsense ;-)

If the rate of new issue reports has stalled, and Jim's willing to
tag Wednesday, then I'd agree we should do it.  Right now we are
asking people to test a broken flavor against clients, so if we
ship with a protocol-valid flavor we'll get more useful defect
reports which either httpd or the client authors can choose to
address, depending on the actual reasons for breakage.

Right now, we know clients should be broken, so asking anyone to
report to us that 2.2.20 breaks some obscure clients is almost
useless to us and to the authors of those clients.

Re: next steps for range fix in 2.2.x

Posted by "Gregg L. Smith" <gl...@gknw.net>.
On 9/5/2011 12:44 AM, "Plüm, Rüdiger, VF-Group" wrote:
>
>
>> -----Original Message-----
>> From: Jeff Trawick [mailto:trawick@gmail.com]
>> Sent: Sonntag, 4. September 2011 17:30
>> To: Apache HTTP Server Development List
>> Subject: next steps for range fix in 2.2.x
>>
>> Can anyone fill in any details for the following?
>>
>> 1. Any known regressions not yet fixed in trunk?
>> 2. Any other issues not yet fixed in trunk?
>> a. r1163833 needs to be modified/reverted so that 200 is sent instead
>> of 206 (see discussion for that commit)
>> 3. Need patch for 2.2.x to review/test; needs r1163833 (or
>> modification) and following from
>> http://svn.apache.org/viewvc/httpd/httpd/trunk/modules/http/by
>> terange_filter.c?sortby=date&view=log
>> 4. Wait to see if more regressions pop up in the next couple of days
>>
> I guess we should wait until mid week for further regression.
> After that we should create a backport starting from r1163197 until current
> of byterange_filter.c
>
> Regards
>
> Rüdiger
>
+1

regressions suck, but the killer is silenced as far as I can tell at 
this point, the script fails it's internal test, no need to rush and 
gain more regressions hurrying to fix the regressions from hurrying to 
silence the killer. My meager view anyway :)

Regards,

Gregg





RE: next steps for range fix in 2.2.x

Posted by "Plüm, Rüdiger, VF-Group" <ru...@vodafone.com>.
 

> -----Original Message-----
> From: Jeff Trawick [mailto:trawick@gmail.com] 
> Sent: Sonntag, 4. September 2011 17:30
> To: Apache HTTP Server Development List
> Subject: next steps for range fix in 2.2.x
> 
> Can anyone fill in any details for the following?
> 
> 1. Any known regressions not yet fixed in trunk?
> 2. Any other issues not yet fixed in trunk?
> a. r1163833 needs to be modified/reverted so that 200 is sent instead
> of 206 (see discussion for that commit)
> 3. Need patch for 2.2.x to review/test; needs r1163833 (or
> modification) and following from
> http://svn.apache.org/viewvc/httpd/httpd/trunk/modules/http/by
> terange_filter.c?sortby=date&view=log
> 4. Wait to see if more regressions pop up in the next couple of days
> 

I guess we should wait until mid week for further regression.
After that we should create a backport starting from r1163197 until current
of byterange_filter.c

Regards

Rüdiger