[jira] Commented: (HTTPCLIENT-933) All implementations of SchemeSocketFactory.createSocket(HttpParams params) ignore the params

["Oleg Kalnichevski (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HTTPCLIENT-933?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12863038#action_12863038 ] 

Oleg Kalnichevski commented on HTTPCLIENT-933:
----------------------------------------------

Sebastian,

In some rare cases it might be necessary to pass initialisation parameters for the socket, for instance, when connecting through a SOCKS server

http://svn.apache.org/repos/asf/httpcomponents/httpclient/trunk/httpclient/src/examples/org/apache/http/examples/client/ClientExecuteSOCKS.java

Oleg
 

> All implementations of SchemeSocketFactory.createSocket(HttpParams params) ignore the params
> --------------------------------------------------------------------------------------------
>
>                 Key: HTTPCLIENT-933
>                 URL: https://issues.apache.org/jira/browse/HTTPCLIENT-933
>             Project: HttpComponents HttpClient
>          Issue Type: Bug
>            Reporter: Sebb
>            Priority: Minor
>
> Only TestTSCCMWithServer.StallingSocketFactory.createSocket(HttpParams params) ever uses the HttpParams parameter.
> All non-test implementations of the method ignore the parameter.
> Not sure why this version of the method exists if the parameter is never used - the parameterless method from SocketFactory could be used instead.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org