[GitHub] [solr] epugh commented on a diff in pull request #1182: SOLR-16504 Convert CLI tools to Jetty HTTP 2 client.

[GitBox <gi...@apache.org>]

epugh commented on code in PR #1182:
URL: https://github.com/apache/solr/pull/1182#discussion_r1025532208


##########
solr/core/src/java/org/apache/solr/util/PackageTool.java:
##########
@@ -360,15 +366,19 @@ private String getZkHost(CommandLine cli) throws Exception {
     String zkHost = cli.getOptionValue("zkHost");
     if (zkHost != null) return zkHost;
 
-    String systemInfoUrl = solrUrl + "/admin/info/system";
-    CloseableHttpClient httpClient = SolrCLI.getHttpClient();
+    Http2SolrClient http2SolrClient = getHttpSolrClient(solrUrl);

Review Comment:
   agreed...   @risdenk I wonder if there is a way to add a rule that would ensure we all follow the try/with/resources model?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org