You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/07/01 10:26:24 UTC

[GitHub] [arrow-datafusion] liukun4515 opened a new issue, #2820: Not evaluate the set expr in the InList for the optimization

liukun4515 opened a new issue, #2820:
URL: https://github.com/apache/arrow-datafusion/issues/2820

   **Describe the bug**
   From this pr https://github.com/apache/arrow-datafusion/pull/2156, @Ted-Jiang optimize the inlist using the set scalar.
   
   But get the static value from below codeļ¼š
   ```
   fn cast_static_filter_to_set(list: &[Arc<dyn PhysicalExpr>]) -> HashSet<ScalarValue> {
       HashSet::from_iter(list.iter().map(|expr| {
           if let Some(cast) = expr.as_any().downcast_ref::<expressions::CastExpr>() {
               cast.expr()
                   .as_any()
                   .downcast_ref::<expressions::Literal>()
                   .unwrap()
                   .value()
                   .clone()
           } else {
               expr.as_any()
                   .downcast_ref::<expressions::Literal>()
                   .unwrap()
                   .value()
                   .clone()
           }
       }))
   }
   ```
   This will not get the right value for the set expr. 
   We should eval the set expr to get the set scalar values.
   
   **To Reproduce**
   Steps to reproduce the behavior:
   
   **Expected behavior**
   A clear and concise description of what you expected to happen.
   
   **Additional context**
   Add any other context about the problem here.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow-datafusion] liukun4515 commented on issue #2820: Not evaluate the set expr in the InList for the optimization

Posted by GitBox <gi...@apache.org>.
liukun4515 commented on issue #2820:
URL: https://github.com/apache/arrow-datafusion/issues/2820#issuecomment-1172195709

   I will fix it after the issue https://github.com/apache/arrow-datafusion/issues/2817 fixed.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow-datafusion] alamb closed issue #2820: Not evaluate the set expr in the InList for the optimization

Posted by GitBox <gi...@apache.org>.
alamb closed issue #2820: Not evaluate the set expr in the InList for the optimization
URL: https://github.com/apache/arrow-datafusion/issues/2820


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org