You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2020/06/26 00:41:07 UTC

[GitHub] [beam] angoenka commented on a change in pull request #12032: [BEAM-10275] Don't eagerly parse pipeline options in sdk_worker_main.py

angoenka commented on a change in pull request #12032:
URL: https://github.com/apache/beam/pull/12032#discussion_r445910583



##########
File path: sdks/python/apache_beam/runners/worker/sdk_worker_main_test.py
##########
@@ -86,6 +92,20 @@ def test_parse_pipeline_options(self):
                          '{"options": {"eam:option:m_option:v":"mock_val"}}').
                      get_all_options(drop_default=True))
 
+  @unittest.skip(
+      'BEAM-10274: type=json.loads pipeline options cannot be parsed in the '
+      'python SDK harness')
+  def test_parse_json_object(self):

Review comment:
       Should we enable this tests after the fix.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org