[GitHub] [storm] srdo commented on a change in pull request #2990: STORM-3372: Fix NPE when shutting down HFSSpout, fix storm-hdfs tests…

[GitBox <gi...@apache.org>]

srdo commented on a change in pull request #2990: STORM-3372: Fix NPE when shutting down HFSSpout, fix storm-hdfs tests…
URL: https://github.com/apache/storm/pull/2990#discussion_r281024003
 
 

 ##########
 File path: external/storm-hdfs-blobstore/src/test/java/org/apache/storm/hdfs/blobstore/BlobStoreTest.java
 ##########
 @@ -55,30 +51,34 @@
 
 import static org.junit.Assert.*;
 
+import org.junit.jupiter.api.AfterEach;
+import org.junit.jupiter.api.BeforeEach;
+import org.junit.jupiter.api.Test;
+import org.junit.jupiter.api.extension.RegisterExtension;
+import org.junit.jupiter.params.ParameterizedTest;
+import org.junit.jupiter.params.provider.EnumSource;
+import org.junit.jupiter.params.provider.ValueSource;
+
 public class BlobStoreTest {
 
-    @ClassRule
-    public static final MiniDFSClusterRule DFS_CLUSTER_RULE = new MiniDFSClusterRule();
+    @RegisterExtension
 
 Review comment:
   This bit is just migration to JUnit 5. The reason for doing this migration is to get access to parameterized tests, which made debugging failing tests here easier.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services