You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Robert Levas <rl...@hortonworks.com> on 2014/12/17 15:38:30 UTC
Review Request 29158: HDFS service components should indicate
security state
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29158/
-----------------------------------------------------------
Review request for Ambari, Jaimin Jetly, Nate Cole, Robert Nettleton, and Yusaku Sako.
Bugs: AMBARI-8477
https://issues.apache.org/jira/browse/AMBARI-8477
Repository: ambari
Description
-------
The HDFS service components should indicate security state when queried by Ambari Agent via STATUS_COMMAND.
See https://issues.apache.org/jira/browse/AMBARI-8477 for more information.
Diffs
-----
ambari-agent/src/test/python/resource_management/TestSecurityCommons.py PRE-CREATION
ambari-common/src/main/python/resource_management/libraries/functions/security_commons.py PRE-CREATION
ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HDFS/package/scripts/datanode.py 4afd4ce
ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HDFS/package/scripts/hdfs_client.py b9f244a
ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HDFS/package/scripts/journalnode.py f664bcd
ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HDFS/package/scripts/namenode.py c8a460f
ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HDFS/package/scripts/snamenode.py 7106422
ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HDFS/package/scripts/status_params.py 0027a4c
ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HDFS/package/scripts/zkfc_slave.py ee8b418
Diff: https://reviews.apache.org/r/29158/diff/
Testing
-------
Manual tests
Added `ambari-agent/src/test/python/resource_management/TestSecurityCommons.py` - test not executed on Jenkins(?)
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 40:45 min
[INFO] Finished at: 2014-12-17T00:43:24+00:00
[INFO] Final Memory: 45M/523M
[INFO] ------------------------------------------------------------------------
Thanks,
Robert Levas
Re: Review Request 29158: HDFS service components should indicate
security state
Posted by Robert Levas <rl...@hortonworks.com>.
> On Dec. 18, 2014, 5:13 p.m., Alejandro Fernandez wrote:
> > ambari-common/src/main/python/resource_management/libraries/functions/security_commons.py, line 20
> > <https://reviews.apache.org/r/29158/diff/1/?file=794152#file794152line20>
> >
> > If possible, used named imports instead of *
Addressed in revision 2.
> On Dec. 18, 2014, 5:13 p.m., Alejandro Fernandez wrote:
> > ambari-common/src/main/python/resource_management/libraries/functions/security_commons.py, line 41
> > <https://reviews.apache.org/r/29158/diff/1/?file=794152#file794152line41>
> >
> > More efficient to iterate key,value pairs in dictionary.iteritems()
Addressed in revision 2.
> On Dec. 18, 2014, 5:13 p.m., Alejandro Fernandez wrote:
> > ambari-common/src/main/python/resource_management/libraries/functions/security_commons.py, line 47
> > <https://reviews.apache.org/r/29158/diff/1/?file=794152#file794152line47>
> >
> > use default() since params may not have that property.
Addressed in revision 2.
> On Dec. 18, 2014, 5:13 p.m., Alejandro Fernandez wrote:
> > ambari-common/src/main/python/resource_management/libraries/functions/security_commons.py, line 58
> > <https://reviews.apache.org/r/29158/diff/1/?file=794152#file794152line58>
> >
> > Insert a space after the last colon.
Addressed in revision 2.
> On Dec. 18, 2014, 5:13 p.m., Alejandro Fernandez wrote:
> > ambari-common/src/main/python/resource_management/libraries/functions/security_commons.py, line 87
> > <https://reviews.apache.org/r/29158/diff/1/?file=794152#file794152line87>
> >
> > use OS.sep instead of "/" whenever possible
Addressed in revision 2.
> On Dec. 18, 2014, 5:13 p.m., Alejandro Fernandez wrote:
> > ambari-common/src/main/python/resource_management/libraries/functions/security_commons.py, line 89
> > <https://reviews.apache.org/r/29158/diff/1/?file=794152#file794152line89>
> >
> > Is it necessary to do a size check before attempting to get [:-4]?
Addressed in revision 2.
- Robert
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29158/#review65543
-----------------------------------------------------------
On Dec. 19, 2014, 3:14 p.m., Robert Levas wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29158/
> -----------------------------------------------------------
>
> (Updated Dec. 19, 2014, 3:14 p.m.)
>
>
> Review request for Ambari, Alejandro Fernandez, Andrew Onischuk, Jaimin Jetly, Sid Wagle, and Yusaku Sako.
>
>
> Bugs: AMBARI-8477
> https://issues.apache.org/jira/browse/AMBARI-8477
>
>
> Repository: ambari
>
>
> Description
> -------
>
> The HDFS service components should indicate security state when queried by Ambari Agent via STATUS_COMMAND.
>
> See https://issues.apache.org/jira/browse/AMBARI-8477 for more information.
>
>
> Diffs
> -----
>
> ambari-agent/src/test/python/resource_management/TestSecurityCommons.py PRE-CREATION
> ambari-common/src/main/python/resource_management/libraries/functions/security_commons.py PRE-CREATION
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/datanode.py 4afd4ce
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/hdfs_client.py 3c54e6b
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/journalnode.py f664bcd
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/namenode.py c8a460f
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/snamenode.py 7106422
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/status_params.py 0027a4c
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/zkfc_slave.py ee8b418
>
> Diff: https://reviews.apache.org/r/29158/diff/
>
>
> Testing
> -------
>
> Manual tests
> Added `ambari-agent/src/test/python/resource_management/TestSecurityCommons.py` - test not executed on Jenkins(?)
>
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 40:45 min
> [INFO] Finished at: 2014-12-17T00:43:24+00:00
> [INFO] Final Memory: 45M/523M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Robert Levas
>
>
Re: Review Request 29158: HDFS service components should indicate
security state
Posted by Alejandro Fernandez <af...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29158/#review65543
-----------------------------------------------------------
ambari-common/src/main/python/resource_management/libraries/functions/security_commons.py
<https://reviews.apache.org/r/29158/#comment108769>
If possible, used named imports instead of *
ambari-common/src/main/python/resource_management/libraries/functions/security_commons.py
<https://reviews.apache.org/r/29158/#comment108765>
More efficient to iterate key,value pairs in dictionary.iteritems()
ambari-common/src/main/python/resource_management/libraries/functions/security_commons.py
<https://reviews.apache.org/r/29158/#comment108764>
use default() since params may not have that property.
ambari-common/src/main/python/resource_management/libraries/functions/security_commons.py
<https://reviews.apache.org/r/29158/#comment108766>
Insert a space after the last colon.
ambari-common/src/main/python/resource_management/libraries/functions/security_commons.py
<https://reviews.apache.org/r/29158/#comment108767>
use OS.sep instead of "/" whenever possible
ambari-common/src/main/python/resource_management/libraries/functions/security_commons.py
<https://reviews.apache.org/r/29158/#comment108768>
Is it necessary to do a size check before attempting to get [:-4]?
- Alejandro Fernandez
On Dec. 18, 2014, 8:09 p.m., Robert Levas wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29158/
> -----------------------------------------------------------
>
> (Updated Dec. 18, 2014, 8:09 p.m.)
>
>
> Review request for Ambari, Alejandro Fernandez, Andrew Onischuk, Jaimin Jetly, Sid Wagle, and Yusaku Sako.
>
>
> Bugs: AMBARI-8477
> https://issues.apache.org/jira/browse/AMBARI-8477
>
>
> Repository: ambari
>
>
> Description
> -------
>
> The HDFS service components should indicate security state when queried by Ambari Agent via STATUS_COMMAND.
>
> See https://issues.apache.org/jira/browse/AMBARI-8477 for more information.
>
>
> Diffs
> -----
>
> ambari-agent/src/test/python/resource_management/TestSecurityCommons.py PRE-CREATION
> ambari-common/src/main/python/resource_management/libraries/functions/security_commons.py PRE-CREATION
> ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HDFS/package/scripts/datanode.py 4afd4ce
> ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HDFS/package/scripts/hdfs_client.py b9f244a
> ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HDFS/package/scripts/journalnode.py f664bcd
> ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HDFS/package/scripts/namenode.py c8a460f
> ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HDFS/package/scripts/snamenode.py 7106422
> ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HDFS/package/scripts/status_params.py 0027a4c
> ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HDFS/package/scripts/zkfc_slave.py ee8b418
>
> Diff: https://reviews.apache.org/r/29158/diff/
>
>
> Testing
> -------
>
> Manual tests
> Added `ambari-agent/src/test/python/resource_management/TestSecurityCommons.py` - test not executed on Jenkins(?)
>
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 40:45 min
> [INFO] Finished at: 2014-12-17T00:43:24+00:00
> [INFO] Final Memory: 45M/523M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Robert Levas
>
>
Re: Review Request 29158: HDFS service components should indicate
security state
Posted by Jaimin Jetly <ja...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29158/#review65831
-----------------------------------------------------------
ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/hdfs_client.py
<https://reviews.apache.org/r/29158/#comment109082>
hdfs_client security state should not be determined by the host being able to authenticate via spnego principal and keytab properties.
Either I will suggest not to kinit for the hdfs client component
or
hdfs_client security state should be determined from the host being able to authenticate via hdfs user credentials.
- Jaimin Jetly
On Dec. 19, 2014, 8:14 p.m., Robert Levas wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29158/
> -----------------------------------------------------------
>
> (Updated Dec. 19, 2014, 8:14 p.m.)
>
>
> Review request for Ambari, Alejandro Fernandez, Andrew Onischuk, Jaimin Jetly, Sid Wagle, and Yusaku Sako.
>
>
> Bugs: AMBARI-8477
> https://issues.apache.org/jira/browse/AMBARI-8477
>
>
> Repository: ambari
>
>
> Description
> -------
>
> The HDFS service components should indicate security state when queried by Ambari Agent via STATUS_COMMAND.
>
> See https://issues.apache.org/jira/browse/AMBARI-8477 for more information.
>
>
> Diffs
> -----
>
> ambari-agent/src/test/python/resource_management/TestSecurityCommons.py PRE-CREATION
> ambari-common/src/main/python/resource_management/libraries/functions/security_commons.py PRE-CREATION
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/datanode.py 4afd4ce
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/hdfs_client.py 3c54e6b
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/journalnode.py f664bcd
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/namenode.py c8a460f
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/snamenode.py 7106422
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/status_params.py 0027a4c
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/zkfc_slave.py ee8b418
>
> Diff: https://reviews.apache.org/r/29158/diff/
>
>
> Testing
> -------
>
> Manual tests
> Added `ambari-agent/src/test/python/resource_management/TestSecurityCommons.py` - test not executed on Jenkins(?)
>
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 40:45 min
> [INFO] Finished at: 2014-12-17T00:43:24+00:00
> [INFO] Final Memory: 45M/523M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Robert Levas
>
>
Re: Review Request 29158: HDFS service components should indicate
security state
Posted by Alejandro Fernandez <af...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29158/#review65748
-----------------------------------------------------------
Ship it!
I did a thorough review on some sections, but glanced over others. I suggest at least one more +1
- Alejandro Fernandez
On Dec. 19, 2014, 8:14 p.m., Robert Levas wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29158/
> -----------------------------------------------------------
>
> (Updated Dec. 19, 2014, 8:14 p.m.)
>
>
> Review request for Ambari, Alejandro Fernandez, Andrew Onischuk, Jaimin Jetly, Sid Wagle, and Yusaku Sako.
>
>
> Bugs: AMBARI-8477
> https://issues.apache.org/jira/browse/AMBARI-8477
>
>
> Repository: ambari
>
>
> Description
> -------
>
> The HDFS service components should indicate security state when queried by Ambari Agent via STATUS_COMMAND.
>
> See https://issues.apache.org/jira/browse/AMBARI-8477 for more information.
>
>
> Diffs
> -----
>
> ambari-agent/src/test/python/resource_management/TestSecurityCommons.py PRE-CREATION
> ambari-common/src/main/python/resource_management/libraries/functions/security_commons.py PRE-CREATION
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/datanode.py 4afd4ce
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/hdfs_client.py 3c54e6b
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/journalnode.py f664bcd
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/namenode.py c8a460f
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/snamenode.py 7106422
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/status_params.py 0027a4c
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/zkfc_slave.py ee8b418
>
> Diff: https://reviews.apache.org/r/29158/diff/
>
>
> Testing
> -------
>
> Manual tests
> Added `ambari-agent/src/test/python/resource_management/TestSecurityCommons.py` - test not executed on Jenkins(?)
>
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 40:45 min
> [INFO] Finished at: 2014-12-17T00:43:24+00:00
> [INFO] Final Memory: 45M/523M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Robert Levas
>
>
Re: Review Request 29158: HDFS service components should indicate
security state
Posted by Robert Levas <rl...@hortonworks.com>.
> On Dec. 22, 2014, 5:14 p.m., Jaimin Jetly wrote:
> > ambari-common/src/main/python/resource_management/libraries/functions/security_commons.py, line 118
> > <https://reviews.apache.org/r/29158/diff/2/?file=797525#file797525line118>
> >
> > Over here ambari-agent is doing a kinit (authenticating) on behalf of actual component to determine the real time security state of a component.
> >
> > It will be nice if we can destroy the cached ticket as part of cleanup.
>
> Robert Levas wrote:
> This issue is address by https://issues.apache.org/jira/browse/AMBARI-8870
This is fixed in patch revision 3
- Robert
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29158/#review65828
-----------------------------------------------------------
On Dec. 23, 2014, 12:36 a.m., Robert Levas wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29158/
> -----------------------------------------------------------
>
> (Updated Dec. 23, 2014, 12:36 a.m.)
>
>
> Review request for Ambari, Alejandro Fernandez, Andrew Onischuk, Jaimin Jetly, Sid Wagle, and Yusaku Sako.
>
>
> Bugs: AMBARI-8477
> https://issues.apache.org/jira/browse/AMBARI-8477
>
>
> Repository: ambari
>
>
> Description
> -------
>
> The HDFS service components should indicate security state when queried by Ambari Agent via STATUS_COMMAND.
>
> See https://issues.apache.org/jira/browse/AMBARI-8477 for more information.
>
>
> Diffs
> -----
>
> ambari-agent/src/test/python/resource_management/TestSecurityCommons.py PRE-CREATION
> ambari-common/src/main/python/resource_management/libraries/functions/security_commons.py PRE-CREATION
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/datanode.py 4afd4ce
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/hdfs_client.py 3c54e6b
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/journalnode.py f664bcd
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/namenode.py c8a460f
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/snamenode.py 7106422
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/status_params.py 0027a4c
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/zkfc_slave.py 4102b69
>
> Diff: https://reviews.apache.org/r/29158/diff/
>
>
> Testing
> -------
>
> Manual tests on a test cluster
> Updated test in `ambari-agent/src/test/python/resource_management/TestSecurityCommons.py`
>
>
> Waiting for tests to complete on Jenkins
>
>
> Thanks,
>
> Robert Levas
>
>
Re: Review Request 29158: HDFS service components should indicate
security state
Posted by Robert Levas <rl...@hortonworks.com>.
> On Dec. 22, 2014, 5:14 p.m., Jaimin Jetly wrote:
> > ambari-common/src/main/python/resource_management/libraries/functions/security_commons.py, line 118
> > <https://reviews.apache.org/r/29158/diff/2/?file=797525#file797525line118>
> >
> > Over here ambari-agent is doing a kinit (authenticating) on behalf of actual component to determine the real time security state of a component.
> >
> > It will be nice if we can destroy the cached ticket as part of cleanup.
This issue is address by https://issues.apache.org/jira/browse/AMBARI-8870
- Robert
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29158/#review65828
-----------------------------------------------------------
On Dec. 19, 2014, 3:14 p.m., Robert Levas wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29158/
> -----------------------------------------------------------
>
> (Updated Dec. 19, 2014, 3:14 p.m.)
>
>
> Review request for Ambari, Alejandro Fernandez, Andrew Onischuk, Jaimin Jetly, Sid Wagle, and Yusaku Sako.
>
>
> Bugs: AMBARI-8477
> https://issues.apache.org/jira/browse/AMBARI-8477
>
>
> Repository: ambari
>
>
> Description
> -------
>
> The HDFS service components should indicate security state when queried by Ambari Agent via STATUS_COMMAND.
>
> See https://issues.apache.org/jira/browse/AMBARI-8477 for more information.
>
>
> Diffs
> -----
>
> ambari-agent/src/test/python/resource_management/TestSecurityCommons.py PRE-CREATION
> ambari-common/src/main/python/resource_management/libraries/functions/security_commons.py PRE-CREATION
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/datanode.py 4afd4ce
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/hdfs_client.py 3c54e6b
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/journalnode.py f664bcd
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/namenode.py c8a460f
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/snamenode.py 7106422
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/status_params.py 0027a4c
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/zkfc_slave.py ee8b418
>
> Diff: https://reviews.apache.org/r/29158/diff/
>
>
> Testing
> -------
>
> Manual tests
> Added `ambari-agent/src/test/python/resource_management/TestSecurityCommons.py` - test not executed on Jenkins(?)
>
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 40:45 min
> [INFO] Finished at: 2014-12-17T00:43:24+00:00
> [INFO] Final Memory: 45M/523M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Robert Levas
>
>
Re: Review Request 29158: HDFS service components should indicate
security state
Posted by Jaimin Jetly <ja...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29158/#review65828
-----------------------------------------------------------
ambari-common/src/main/python/resource_management/libraries/functions/security_commons.py
<https://reviews.apache.org/r/29158/#comment109077>
Over here ambari-agent is doing a kinit (authenticating) on behalf of actual component to determine the real time security state of a component.
It will be nice if we can destroy the cached ticket as part of cleanup.
- Jaimin Jetly
On Dec. 19, 2014, 8:14 p.m., Robert Levas wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29158/
> -----------------------------------------------------------
>
> (Updated Dec. 19, 2014, 8:14 p.m.)
>
>
> Review request for Ambari, Alejandro Fernandez, Andrew Onischuk, Jaimin Jetly, Sid Wagle, and Yusaku Sako.
>
>
> Bugs: AMBARI-8477
> https://issues.apache.org/jira/browse/AMBARI-8477
>
>
> Repository: ambari
>
>
> Description
> -------
>
> The HDFS service components should indicate security state when queried by Ambari Agent via STATUS_COMMAND.
>
> See https://issues.apache.org/jira/browse/AMBARI-8477 for more information.
>
>
> Diffs
> -----
>
> ambari-agent/src/test/python/resource_management/TestSecurityCommons.py PRE-CREATION
> ambari-common/src/main/python/resource_management/libraries/functions/security_commons.py PRE-CREATION
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/datanode.py 4afd4ce
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/hdfs_client.py 3c54e6b
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/journalnode.py f664bcd
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/namenode.py c8a460f
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/snamenode.py 7106422
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/status_params.py 0027a4c
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/zkfc_slave.py ee8b418
>
> Diff: https://reviews.apache.org/r/29158/diff/
>
>
> Testing
> -------
>
> Manual tests
> Added `ambari-agent/src/test/python/resource_management/TestSecurityCommons.py` - test not executed on Jenkins(?)
>
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 40:45 min
> [INFO] Finished at: 2014-12-17T00:43:24+00:00
> [INFO] Final Memory: 45M/523M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Robert Levas
>
>
Re: Review Request 29158: HDFS service components should indicate
security state
Posted by Jaimin Jetly <ja...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29158/#review65958
-----------------------------------------------------------
Ship it!
Ship It!
- Jaimin Jetly
On Dec. 23, 2014, 5:15 p.m., Robert Levas wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29158/
> -----------------------------------------------------------
>
> (Updated Dec. 23, 2014, 5:15 p.m.)
>
>
> Review request for Ambari, Alejandro Fernandez, Andrew Onischuk, Jaimin Jetly, Sid Wagle, and Yusaku Sako.
>
>
> Bugs: AMBARI-8477
> https://issues.apache.org/jira/browse/AMBARI-8477
>
>
> Repository: ambari
>
>
> Description
> -------
>
> The HDFS service components should indicate security state when queried by Ambari Agent via STATUS_COMMAND.
>
> See https://issues.apache.org/jira/browse/AMBARI-8477 for more information.
>
>
> Diffs
> -----
>
> ambari-agent/src/test/python/resource_management/TestSecurityCommons.py PRE-CREATION
> ambari-common/src/main/python/resource_management/libraries/functions/security_commons.py PRE-CREATION
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/datanode.py 4afd4ce
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/hdfs_client.py 3c54e6b
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/journalnode.py f664bcd
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/namenode.py c8a460f
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/snamenode.py 7106422
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/status_params.py 0027a4c
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/zkfc_slave.py 4102b69
>
> Diff: https://reviews.apache.org/r/29158/diff/
>
>
> Testing
> -------
>
> Manual tests on a test cluster
> Updated test in `ambari-agent/src/test/python/resource_management/TestSecurityCommons.py`
>
> All tests successfully ran
>
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 40:33 min
> [INFO] Finished at: 2014-12-23T17:04:53+00:00
> [INFO] Final Memory: 44M/526M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Robert Levas
>
>
Re: Review Request 29158: HDFS service components should indicate
security state
Posted by Robert Levas <rl...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29158/
-----------------------------------------------------------
(Updated Dec. 23, 2014, 12:15 p.m.)
Review request for Ambari, Alejandro Fernandez, Andrew Onischuk, Jaimin Jetly, Sid Wagle, and Yusaku Sako.
Bugs: AMBARI-8477
https://issues.apache.org/jira/browse/AMBARI-8477
Repository: ambari
Description
-------
The HDFS service components should indicate security state when queried by Ambari Agent via STATUS_COMMAND.
See https://issues.apache.org/jira/browse/AMBARI-8477 for more information.
Diffs
-----
ambari-agent/src/test/python/resource_management/TestSecurityCommons.py PRE-CREATION
ambari-common/src/main/python/resource_management/libraries/functions/security_commons.py PRE-CREATION
ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/datanode.py 4afd4ce
ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/hdfs_client.py 3c54e6b
ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/journalnode.py f664bcd
ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/namenode.py c8a460f
ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/snamenode.py 7106422
ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/status_params.py 0027a4c
ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/zkfc_slave.py 4102b69
Diff: https://reviews.apache.org/r/29158/diff/
Testing (updated)
-------
Manual tests on a test cluster
Updated test in `ambari-agent/src/test/python/resource_management/TestSecurityCommons.py`
All tests successfully ran
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 40:33 min
[INFO] Finished at: 2014-12-23T17:04:53+00:00
[INFO] Final Memory: 44M/526M
[INFO] ------------------------------------------------------------------------
Thanks,
Robert Levas
Re: Review Request 29158: HDFS service components should indicate
security state
Posted by Robert Levas <rl...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29158/
-----------------------------------------------------------
(Updated Dec. 23, 2014, 10:59 a.m.)
Review request for Ambari, Alejandro Fernandez, Andrew Onischuk, Jaimin Jetly, Sid Wagle, and Yusaku Sako.
Changes
-------
Fixed issue where methods in `common-services/HDFS/2.1.0.2.0/package/scripts/namenode.py` after `security_status` were shifted to the left, removing them from the `NameNode` class.
Bugs: AMBARI-8477
https://issues.apache.org/jira/browse/AMBARI-8477
Repository: ambari
Description
-------
The HDFS service components should indicate security state when queried by Ambari Agent via STATUS_COMMAND.
See https://issues.apache.org/jira/browse/AMBARI-8477 for more information.
Diffs (updated)
-----
ambari-agent/src/test/python/resource_management/TestSecurityCommons.py PRE-CREATION
ambari-common/src/main/python/resource_management/libraries/functions/security_commons.py PRE-CREATION
ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/datanode.py 4afd4ce
ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/hdfs_client.py 3c54e6b
ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/journalnode.py f664bcd
ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/namenode.py c8a460f
ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/snamenode.py 7106422
ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/status_params.py 0027a4c
ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/zkfc_slave.py 4102b69
Diff: https://reviews.apache.org/r/29158/diff/
Testing
-------
Manual tests on a test cluster
Updated test in `ambari-agent/src/test/python/resource_management/TestSecurityCommons.py`
Waiting for tests to complete on Jenkins
Thanks,
Robert Levas
Re: Review Request 29158: HDFS service components should indicate
security state
Posted by Robert Levas <rl...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29158/
-----------------------------------------------------------
(Updated Dec. 23, 2014, 12:36 a.m.)
Review request for Ambari, Alejandro Fernandez, Andrew Onischuk, Jaimin Jetly, Sid Wagle, and Yusaku Sako.
Bugs: AMBARI-8477
https://issues.apache.org/jira/browse/AMBARI-8477
Repository: ambari
Description
-------
The HDFS service components should indicate security state when queried by Ambari Agent via STATUS_COMMAND.
See https://issues.apache.org/jira/browse/AMBARI-8477 for more information.
Diffs
-----
ambari-agent/src/test/python/resource_management/TestSecurityCommons.py PRE-CREATION
ambari-common/src/main/python/resource_management/libraries/functions/security_commons.py PRE-CREATION
ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/datanode.py 4afd4ce
ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/hdfs_client.py 3c54e6b
ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/journalnode.py f664bcd
ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/namenode.py c8a460f
ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/snamenode.py 7106422
ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/status_params.py 0027a4c
ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/zkfc_slave.py 4102b69
Diff: https://reviews.apache.org/r/29158/diff/
Testing (updated)
-------
Manual tests on a test cluster
Updated test in `ambari-agent/src/test/python/resource_management/TestSecurityCommons.py`
Waiting for tests to complete on Jenkins
Thanks,
Robert Levas
Re: Review Request 29158: HDFS service components should indicate
security state
Posted by Robert Levas <rl...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29158/
-----------------------------------------------------------
(Updated Dec. 23, 2014, 12:35 a.m.)
Review request for Ambari, Alejandro Fernandez, Andrew Onischuk, Jaimin Jetly, Sid Wagle, and Yusaku Sako.
Changes
-------
This latest patch contains a large change to the caching infrastrucutre surrounding the kinit calls. The change is to allow for the creation and deletion of temporary cache files used by kinit so as to not overwrite any exsting cache file or leave behind any orphaned cached file due to this test procedure.
This patch may need to be fully reviewed.
Bugs: AMBARI-8477
https://issues.apache.org/jira/browse/AMBARI-8477
Repository: ambari
Description
-------
The HDFS service components should indicate security state when queried by Ambari Agent via STATUS_COMMAND.
See https://issues.apache.org/jira/browse/AMBARI-8477 for more information.
Diffs (updated)
-----
ambari-agent/src/test/python/resource_management/TestSecurityCommons.py PRE-CREATION
ambari-common/src/main/python/resource_management/libraries/functions/security_commons.py PRE-CREATION
ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/datanode.py 4afd4ce
ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/hdfs_client.py 3c54e6b
ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/journalnode.py f664bcd
ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/namenode.py c8a460f
ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/snamenode.py 7106422
ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/status_params.py 0027a4c
ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/zkfc_slave.py 4102b69
Diff: https://reviews.apache.org/r/29158/diff/
Testing
-------
Manual tests
Added `ambari-agent/src/test/python/resource_management/TestSecurityCommons.py` - test not executed on Jenkins(?)
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 40:45 min
[INFO] Finished at: 2014-12-17T00:43:24+00:00
[INFO] Final Memory: 45M/523M
[INFO] ------------------------------------------------------------------------
Thanks,
Robert Levas
Re: Review Request 29158: HDFS service components should indicate
security state
Posted by Robert Levas <rl...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29158/
-----------------------------------------------------------
(Updated Dec. 19, 2014, 3:14 p.m.)
Review request for Ambari, Alejandro Fernandez, Andrew Onischuk, Jaimin Jetly, Sid Wagle, and Yusaku Sako.
Changes
-------
Addressing review comments.
Bugs: AMBARI-8477
https://issues.apache.org/jira/browse/AMBARI-8477
Repository: ambari
Description
-------
The HDFS service components should indicate security state when queried by Ambari Agent via STATUS_COMMAND.
See https://issues.apache.org/jira/browse/AMBARI-8477 for more information.
Diffs (updated)
-----
ambari-agent/src/test/python/resource_management/TestSecurityCommons.py PRE-CREATION
ambari-common/src/main/python/resource_management/libraries/functions/security_commons.py PRE-CREATION
ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/datanode.py 4afd4ce
ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/hdfs_client.py 3c54e6b
ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/journalnode.py f664bcd
ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/namenode.py c8a460f
ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/snamenode.py 7106422
ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/status_params.py 0027a4c
ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/zkfc_slave.py ee8b418
Diff: https://reviews.apache.org/r/29158/diff/
Testing
-------
Manual tests
Added `ambari-agent/src/test/python/resource_management/TestSecurityCommons.py` - test not executed on Jenkins(?)
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 40:45 min
[INFO] Finished at: 2014-12-17T00:43:24+00:00
[INFO] Final Memory: 45M/523M
[INFO] ------------------------------------------------------------------------
Thanks,
Robert Levas
Re: Review Request 29158: HDFS service components should indicate
security state
Posted by Robert Levas <rl...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29158/
-----------------------------------------------------------
(Updated Dec. 18, 2014, 3:09 p.m.)
Review request for Ambari, Alejandro Fernandez, Andrew Onischuk, Jaimin Jetly, Sid Wagle, and Yusaku Sako.
Bugs: AMBARI-8477
https://issues.apache.org/jira/browse/AMBARI-8477
Repository: ambari
Description
-------
The HDFS service components should indicate security state when queried by Ambari Agent via STATUS_COMMAND.
See https://issues.apache.org/jira/browse/AMBARI-8477 for more information.
Diffs
-----
ambari-agent/src/test/python/resource_management/TestSecurityCommons.py PRE-CREATION
ambari-common/src/main/python/resource_management/libraries/functions/security_commons.py PRE-CREATION
ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HDFS/package/scripts/datanode.py 4afd4ce
ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HDFS/package/scripts/hdfs_client.py b9f244a
ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HDFS/package/scripts/journalnode.py f664bcd
ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HDFS/package/scripts/namenode.py c8a460f
ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HDFS/package/scripts/snamenode.py 7106422
ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HDFS/package/scripts/status_params.py 0027a4c
ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HDFS/package/scripts/zkfc_slave.py ee8b418
Diff: https://reviews.apache.org/r/29158/diff/
Testing
-------
Manual tests
Added `ambari-agent/src/test/python/resource_management/TestSecurityCommons.py` - test not executed on Jenkins(?)
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 40:45 min
[INFO] Finished at: 2014-12-17T00:43:24+00:00
[INFO] Final Memory: 45M/523M
[INFO] ------------------------------------------------------------------------
Thanks,
Robert Levas
Re: Review Request 29158: HDFS service components should indicate
security state
Posted by Robert Levas <rl...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29158/
-----------------------------------------------------------
(Updated Dec. 18, 2014, 3:09 p.m.)
Review request for Ambari, Alejandro Fernandez, Andrew Onischuk, Jaimin Jetly, Robert Nettleton, Sid Wagle, and Yusaku Sako.
Bugs: AMBARI-8477
https://issues.apache.org/jira/browse/AMBARI-8477
Repository: ambari
Description
-------
The HDFS service components should indicate security state when queried by Ambari Agent via STATUS_COMMAND.
See https://issues.apache.org/jira/browse/AMBARI-8477 for more information.
Diffs
-----
ambari-agent/src/test/python/resource_management/TestSecurityCommons.py PRE-CREATION
ambari-common/src/main/python/resource_management/libraries/functions/security_commons.py PRE-CREATION
ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HDFS/package/scripts/datanode.py 4afd4ce
ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HDFS/package/scripts/hdfs_client.py b9f244a
ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HDFS/package/scripts/journalnode.py f664bcd
ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HDFS/package/scripts/namenode.py c8a460f
ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HDFS/package/scripts/snamenode.py 7106422
ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HDFS/package/scripts/status_params.py 0027a4c
ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HDFS/package/scripts/zkfc_slave.py ee8b418
Diff: https://reviews.apache.org/r/29158/diff/
Testing
-------
Manual tests
Added `ambari-agent/src/test/python/resource_management/TestSecurityCommons.py` - test not executed on Jenkins(?)
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 40:45 min
[INFO] Finished at: 2014-12-17T00:43:24+00:00
[INFO] Final Memory: 45M/523M
[INFO] ------------------------------------------------------------------------
Thanks,
Robert Levas
Re: Review Request 29158: HDFS service components should indicate
security state
Posted by Robert Levas <rl...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29158/
-----------------------------------------------------------
(Updated Dec. 17, 2014, 3:52 p.m.)
Review request for Ambari, Andrew Onischuk, Jaimin Jetly, Robert Nettleton, and Yusaku Sako.
Bugs: AMBARI-8477
https://issues.apache.org/jira/browse/AMBARI-8477
Repository: ambari
Description
-------
The HDFS service components should indicate security state when queried by Ambari Agent via STATUS_COMMAND.
See https://issues.apache.org/jira/browse/AMBARI-8477 for more information.
Diffs
-----
ambari-agent/src/test/python/resource_management/TestSecurityCommons.py PRE-CREATION
ambari-common/src/main/python/resource_management/libraries/functions/security_commons.py PRE-CREATION
ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HDFS/package/scripts/datanode.py 4afd4ce
ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HDFS/package/scripts/hdfs_client.py b9f244a
ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HDFS/package/scripts/journalnode.py f664bcd
ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HDFS/package/scripts/namenode.py c8a460f
ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HDFS/package/scripts/snamenode.py 7106422
ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HDFS/package/scripts/status_params.py 0027a4c
ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HDFS/package/scripts/zkfc_slave.py ee8b418
Diff: https://reviews.apache.org/r/29158/diff/
Testing
-------
Manual tests
Added `ambari-agent/src/test/python/resource_management/TestSecurityCommons.py` - test not executed on Jenkins(?)
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 40:45 min
[INFO] Finished at: 2014-12-17T00:43:24+00:00
[INFO] Final Memory: 45M/523M
[INFO] ------------------------------------------------------------------------
Thanks,
Robert Levas