[jira] [Commented] (HBASE-16964) Successfully archived files are not cleared from compacted store file list if archiving of any file fails

["ramkrishna.s.vasudevan (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HBASE-16964?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15617520#comment-15617520 ] 

ramkrishna.s.vasudevan commented on HBASE-16964:
------------------------------------------------

I don have code with me now, but I think This can b solved . I started with a patch for this when then other bug was raised but was carried away.
Currently we can list out the failed archived files and remove only the successful ones? Excuse typos

> Successfully archived files are not cleared from compacted store file list if archiving of any file fails
> ---------------------------------------------------------------------------------------------------------
>
>                 Key: HBASE-16964
>                 URL: https://issues.apache.org/jira/browse/HBASE-16964
>             Project: HBase
>          Issue Type: Bug
>          Components: regionserver
>            Reporter: Gary Helmling
>            Assignee: Gary Helmling
>            Priority: Blocker
>             Fix For: 1.3.0
>
>
> In HStore.removeCompactedFiles(), we only clear archived files from StoreFileManager's list of compactedfiles if _all_ files were archived successfully.  If we encounter an error archiving any of the files, then any files which were already archived will remain in the list of compactedfiles.
> Even worse, this means that all subsequent attempts to archive the list of compacted files will fail (as the previously successfully archived files still in the list will now throw FileNotFoundException), and the list of compactedfiles will never be cleared from that point on.
> Finally, when the region closes, we will again throw an exception out of HStore.removeCompactedFiles(), in this case causing a regionserver abort.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)