You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@orc.apache.org by do...@apache.org on 2022/01/30 17:51:24 UTC
[orc] branch branch-1.7 updated: ORC-1106: Use transitive commons-lang3 dependency in bench module (#1032)
This is an automated email from the ASF dual-hosted git repository.
dongjoon pushed a commit to branch branch-1.7
in repository https://gitbox.apache.org/repos/asf/orc.git
The following commit(s) were added to refs/heads/branch-1.7 by this push:
new 7ce7227 ORC-1106: Use transitive commons-lang3 dependency in bench module (#1032)
7ce7227 is described below
commit 7ce7227bc6a1cd3e3d9ff35ea1e1b34596c7b243
Author: William Hyun <wi...@apache.org>
AuthorDate: Sun Jan 30 09:50:52 2022 -0800
ORC-1106: Use transitive commons-lang3 dependency in bench module (#1032)
### What changes were proposed in this pull request?
This PR aims to use transitive `commons-lang3` dependency in `bench` module.
### Why are the changes needed?
Hadoop 3.3 and Spark 3.2 are using `commons-lang3` 3.12.0
### How was this patch tested?
Manually check with
**BEFORE**
```
$ mvn dependency:tree -Dincludes=org.apache.commons:commons-lang3 -Pbenchmark | grep apache
Running `/Users/dongjoon/APACHE/orc-merge/java/mvnw`...
Using `mvn` from path: /opt/homebrew/bin/mvn
[INFO] -------------------------< org.apache.orc:orc >-------------------------
[INFO] ----------------------< org.apache.orc:orc-shims >----------------------
[INFO] ----------------------< org.apache.orc:orc-core >-----------------------
[INFO] org.apache.orc:orc-core:jar:1.8.0-SNAPSHOT
[INFO] \- org.apache.commons:commons-lang3:jar:3.12.0:compile
[INFO] --------------------< org.apache.orc:orc-mapreduce >--------------------
[INFO] org.apache.orc:orc-mapreduce:jar:1.8.0-SNAPSHOT
[INFO] \- org.apache.commons:commons-lang3:jar:3.12.0:compile
[INFO] ----------------------< org.apache.orc:orc-tools >----------------------
[INFO] org.apache.orc:orc-tools:jar:1.8.0-SNAPSHOT
[INFO] \- org.apache.commons:commons-lang3:jar:3.12.0:compile
[INFO] --------------------< org.apache.orc:orc-examples >---------------------
[INFO] org.apache.orc:orc-examples:jar:1.8.0-SNAPSHOT
[INFO] \- org.apache.orc:orc-core:jar:1.8.0-SNAPSHOT:compile
[INFO] \- org.apache.commons:commons-lang3:jar:3.12.0:compile
[INFO] -------------------< org.apache.orc:orc-benchmarks >--------------------
[INFO] -----------------< org.apache.orc:orc-benchmarks-core >-----------------
[INFO] org.apache.orc:orc-benchmarks-core:jar:1.8.0-SNAPSHOT
[INFO] \- org.apache.hadoop:hadoop-common:jar:3.3.1:compile
[INFO] \- org.apache.commons:commons-lang3:jar:3.7:runtime
[INFO] -----------------< org.apache.orc:orc-benchmarks-hive >-----------------
[INFO] org.apache.orc:orc-benchmarks-hive:jar:1.8.0-SNAPSHOT
[INFO] \- org.apache.hadoop:hadoop-common:jar:3.3.1:compile
[INFO] \- org.apache.commons:commons-lang3:jar:3.7:runtime
[INFO] ----------------< org.apache.orc:orc-benchmarks-spark >-----------------
[INFO] org.apache.orc:orc-benchmarks-spark:jar:1.8.0-SNAPSHOT
[INFO] \- org.apache.commons:commons-lang3:jar:3.7:runtime
```
**AFTER**
```
$ mvn dependency:tree -Dincludes=org.apache.commons:commons-lang3 -Pbenchmark | grep apache
Running `/Users/dongjoon/APACHE/orc-merge/java/mvnw`...
Using `mvn` from path: /opt/homebrew/bin/mvn
[INFO] -------------------------< org.apache.orc:orc >-------------------------
[INFO] ----------------------< org.apache.orc:orc-shims >----------------------
[INFO] ----------------------< org.apache.orc:orc-core >-----------------------
[INFO] org.apache.orc:orc-core:jar:1.8.0-SNAPSHOT
[INFO] \- org.apache.commons:commons-lang3:jar:3.12.0:compile
[INFO] --------------------< org.apache.orc:orc-mapreduce >--------------------
[INFO] org.apache.orc:orc-mapreduce:jar:1.8.0-SNAPSHOT
[INFO] \- org.apache.commons:commons-lang3:jar:3.12.0:compile
[INFO] ----------------------< org.apache.orc:orc-tools >----------------------
[INFO] org.apache.orc:orc-tools:jar:1.8.0-SNAPSHOT
[INFO] \- org.apache.commons:commons-lang3:jar:3.12.0:compile
[INFO] --------------------< org.apache.orc:orc-examples >---------------------
[INFO] org.apache.orc:orc-examples:jar:1.8.0-SNAPSHOT
[INFO] \- org.apache.orc:orc-core:jar:1.8.0-SNAPSHOT:compile
[INFO] \- org.apache.commons:commons-lang3:jar:3.12.0:compile
[INFO] -------------------< org.apache.orc:orc-benchmarks >--------------------
[INFO] -----------------< org.apache.orc:orc-benchmarks-core >-----------------
[INFO] org.apache.orc:orc-benchmarks-core:jar:1.8.0-SNAPSHOT
[INFO] \- org.apache.hadoop:hadoop-common:jar:3.3.1:compile
[INFO] \- org.apache.commons:commons-lang3:jar:3.12.0:compile
[INFO] -----------------< org.apache.orc:orc-benchmarks-hive >-----------------
[INFO] org.apache.orc:orc-benchmarks-hive:jar:1.8.0-SNAPSHOT
[INFO] \- org.apache.hadoop:hadoop-common:jar:3.3.1:compile
[INFO] \- org.apache.commons:commons-lang3:jar:3.12.0:compile
[INFO] ----------------< org.apache.orc:orc-benchmarks-spark >-----------------
[INFO] org.apache.orc:orc-benchmarks-spark:jar:1.8.0-SNAPSHOT
[INFO] \- org.apache.commons:commons-lang3:jar:3.12.0:compile
```
(cherry picked from commit 0622002bd140d7bd88af0ae71d73fd1b3a101c17)
Signed-off-by: Dongjoon Hyun <do...@apache.org>
---
java/bench/pom.xml | 6 ------
1 file changed, 6 deletions(-)
diff --git a/java/bench/pom.xml b/java/bench/pom.xml
index f44d08b..0922548 100644
--- a/java/bench/pom.xml
+++ b/java/bench/pom.xml
@@ -130,12 +130,6 @@
<version>1.8</version>
</dependency>
<dependency>
- <groupId>org.apache.commons</groupId>
- <artifactId>commons-lang3</artifactId>
- <version>3.7</version>
- <scope>runtime</scope>
- </dependency>
- <dependency>
<groupId>org.apache.hadoop</groupId>
<artifactId>hadoop-common</artifactId>
<version>${hadoop.version}</version>