You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cordova.apache.org by amit777 <gi...@git.apache.org> on 2014/06/09 07:46:09 UTC

[GitHub] cordova-ios pull request: Fixed RegEx error when callbackId is nil

GitHub user amit777 opened a pull request:

    https://github.com/apache/cordova-ios/pull/97

    Fixed RegEx error when callbackId is nil

    Hi, my barebones cordova/ionic app was terminating with the PushPlugin.  I have no idea if this fix is appropriate.  I submitted details of the error here:
    
    https://issues.apache.org/jira/browse/CB-6897

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/amit777/cordova-ios master

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cordova-ios/pull/97.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #97
    
----
commit c0c4d93752443a429a93d0be3b47f0ba705c7d37
Author: Amit G <am...@gmail.com>
Date:   2014-06-09T05:41:38Z

    Fixed RegEx error when callbackId is nil

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cordova-ios pull request: Fixed RegEx error when callbackId is nil

Posted by agrieve <gi...@git.apache.org>.
Github user agrieve commented on a diff in the pull request:

    https://github.com/apache/cordova-ios/pull/97#discussion_r14897935
  
    --- Diff: CordovaLib/Classes/CDVCommandDelegateImpl.m ---
    @@ -107,6 +107,10 @@ - (BOOL)isValidCallbackId:(NSString *)callbackId
                 return NO;
             }
         }
    +    //Allow nil callbackId
    +    if (callbackId == nil){
    +      return YES;
    --- End diff --
    
    I think this should return NO. nil is not a valid callback id.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cordova-ios pull request: Fixed RegEx error when callbackId is nil

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/cordova-ios/pull/97


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---