You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tapestry.apache.org by "Denis Delangle (JIRA)" <ji...@apache.org> on 2012/05/23 08:39:42 UTC
[jira] [Created] (TAP5-1936) REOPEN TAP5-698 - PageTester's
setupRequestFromURI incorrectly uses substring twice on same string
Denis Delangle created TAP5-1936:
------------------------------------
Summary: REOPEN TAP5-698 - PageTester's setupRequestFromURI incorrectly uses substring twice on same string
Key: TAP5-1936
URL: https://issues.apache.org/jira/browse/TAP5-1936
Project: Tapestry 5
Issue Type: Bug
Components: tapestry-test
Affects Versions: 5.1.0.5
Reporter: Denis Delangle
Assignee: Howard M. Lewis Ship
Fix For: 5.3
Incoming linkPath: /filelist.delete/c$002ftest2-2510777506787452085.txt?t:ac=c
int comma is set to 52
path: /filelist.delete/c$002ftest2-2510777506787452085.txt
then trying to do a path.substring(comma+1)
Fix: use linkPath instead of path at line 304:
if (comma > 0)
decodeParametersIntoRequest(path.substring(comma + 1));
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (TAP5-1936) REOPEN TAP5-698 - PageTester's
setupRequestFromURI incorrectly uses substring twice on same string
Posted by "Denis Delangle (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TAP5-1936?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Denis Delangle updated TAP5-1936:
---------------------------------
Fix Version/s: (was: 5.3)
Description:
I get this error when clicking a link with parameters in PageTester
java.lang.StringIndexOutOfBoundsException: String index out of range: -1
at java.lang.String.substring(String.java:1937)
at java.lang.String.substring(String.java:1904)
at org.apache.tapestry5.test.PageTester.setupRequestFromURI(PageTester.java:345)
That bug was corrected revision 896555 and put back revision 1185926.
The correction is trivial but have been done twice, so the bug is
still there.
I submit a patch to correct it
was:
Incoming linkPath: /filelist.delete/c$002ftest2-2510777506787452085.txt?t:ac=c
int comma is set to 52
path: /filelist.delete/c$002ftest2-2510777506787452085.txt
then trying to do a path.substring(comma+1)
Fix: use linkPath instead of path at line 304:
if (comma > 0)
decodeParametersIntoRequest(path.substring(comma + 1));
Affects Version/s: (was: 5.1.0.5)
5.3.3
> REOPEN TAP5-698 - PageTester's setupRequestFromURI incorrectly uses substring twice on same string
> --------------------------------------------------------------------------------------------------
>
> Key: TAP5-1936
> URL: https://issues.apache.org/jira/browse/TAP5-1936
> Project: Tapestry 5
> Issue Type: Bug
> Components: tapestry-test
> Affects Versions: 5.3.3
> Reporter: Denis Delangle
> Assignee: Howard M. Lewis Ship
>
> I get this error when clicking a link with parameters in PageTester
> java.lang.StringIndexOutOfBoundsException: String index out of range: -1
> at java.lang.String.substring(String.java:1937)
> at java.lang.String.substring(String.java:1904)
> at org.apache.tapestry5.test.PageTester.setupRequestFromURI(PageTester.java:345)
> That bug was corrected revision 896555 and put back revision 1185926.
> The correction is trivial but have been done twice, so the bug is
> still there.
> I submit a patch to correct it
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (TAP5-1936) REOPEN TAP5-698 - PageTester's
setupRequestFromURI incorrectly uses substring twice on same string
Posted by "Steve Eynon (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TAP5-1936?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13396640#comment-13396640 ]
Steve Eynon commented on TAP5-1936:
-----------------------------------
This is a duplicate of TAP5-1770 - https://issues.apache.org/jira/browse/TAP5-1770
Thanks for the patch file though!
> REOPEN TAP5-698 - PageTester's setupRequestFromURI incorrectly uses substring twice on same string
> --------------------------------------------------------------------------------------------------
>
> Key: TAP5-1936
> URL: https://issues.apache.org/jira/browse/TAP5-1936
> Project: Tapestry 5
> Issue Type: Bug
> Components: tapestry-test
> Affects Versions: 5.3.3
> Reporter: Denis Delangle
> Assignee: Howard M. Lewis Ship
> Attachments: patch-TAP5-1936.txt
>
>
> I get this error when clicking a link with parameters in PageTester
> java.lang.StringIndexOutOfBoundsException: String index out of range: -1
> at java.lang.String.substring(String.java:1937)
> at java.lang.String.substring(String.java:1904)
> at org.apache.tapestry5.test.PageTester.setupRequestFromURI(PageTester.java:345)
> That bug was corrected revision 896555 and put back revision 1185926.
> The correction is trivial but have been done twice, so the bug is
> still there.
> I submit a patch to correct it
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (TAP5-1936) REOPEN TAP5-698 - PageTester's
setupRequestFromURI incorrectly uses substring twice on same string
Posted by "Denis Delangle (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TAP5-1936?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Denis Delangle updated TAP5-1936:
---------------------------------
Attachment: patch-TAP5-1936.txt
> REOPEN TAP5-698 - PageTester's setupRequestFromURI incorrectly uses substring twice on same string
> --------------------------------------------------------------------------------------------------
>
> Key: TAP5-1936
> URL: https://issues.apache.org/jira/browse/TAP5-1936
> Project: Tapestry 5
> Issue Type: Bug
> Components: tapestry-test
> Affects Versions: 5.3.3
> Reporter: Denis Delangle
> Assignee: Howard M. Lewis Ship
> Attachments: patch-TAP5-1936.txt
>
>
> I get this error when clicking a link with parameters in PageTester
> java.lang.StringIndexOutOfBoundsException: String index out of range: -1
> at java.lang.String.substring(String.java:1937)
> at java.lang.String.substring(String.java:1904)
> at org.apache.tapestry5.test.PageTester.setupRequestFromURI(PageTester.java:345)
> That bug was corrected revision 896555 and put back revision 1185926.
> The correction is trivial but have been done twice, so the bug is
> still there.
> I submit a patch to correct it
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Comment Edited] (TAP5-1936) REOPEN TAP5-698 - PageTester's
setupRequestFromURI incorrectly uses substring twice on same string
Posted by "Steve Eynon (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TAP5-1936?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13396640#comment-13396640 ]
Steve Eynon edited comment on TAP5-1936 at 6/19/12 10:08 AM:
-------------------------------------------------------------
This is a duplicate of TAP5-1770 - Thanks for the patch file though!
was (Author: slimerdude):
This is a duplicate of TAP5-1770 - https://issues.apache.org/jira/browse/TAP5-1770
Thanks for the patch file though!
> REOPEN TAP5-698 - PageTester's setupRequestFromURI incorrectly uses substring twice on same string
> --------------------------------------------------------------------------------------------------
>
> Key: TAP5-1936
> URL: https://issues.apache.org/jira/browse/TAP5-1936
> Project: Tapestry 5
> Issue Type: Bug
> Components: tapestry-test
> Affects Versions: 5.3.3
> Reporter: Denis Delangle
> Assignee: Howard M. Lewis Ship
> Attachments: patch-TAP5-1936.txt
>
>
> I get this error when clicking a link with parameters in PageTester
> java.lang.StringIndexOutOfBoundsException: String index out of range: -1
> at java.lang.String.substring(String.java:1937)
> at java.lang.String.substring(String.java:1904)
> at org.apache.tapestry5.test.PageTester.setupRequestFromURI(PageTester.java:345)
> That bug was corrected revision 896555 and put back revision 1185926.
> The correction is trivial but have been done twice, so the bug is
> still there.
> I submit a patch to correct it
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (TAP5-1936) REOPEN TAP5-698 - PageTester's
setupRequestFromURI incorrectly uses substring twice on same string
Posted by "Denis Delangle (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TAP5-1936?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Denis Delangle updated TAP5-1936:
---------------------------------
Fix Version/s: (was: 5.3)
Description:
I get this error when clicking a link with parameters in PageTester
java.lang.StringIndexOutOfBoundsException: String index out of range: -1
at java.lang.String.substring(String.java:1937)
at java.lang.String.substring(String.java:1904)
at org.apache.tapestry5.test.PageTester.setupRequestFromURI(PageTester.java:345)
That bug was corrected revision 896555 and put back revision 1185926.
The correction is trivial but have been done twice, so the bug is
still there.
I submit a patch to correct it
was:
Incoming linkPath: /filelist.delete/c$002ftest2-2510777506787452085.txt?t:ac=c
int comma is set to 52
path: /filelist.delete/c$002ftest2-2510777506787452085.txt
then trying to do a path.substring(comma+1)
Fix: use linkPath instead of path at line 304:
if (comma > 0)
decodeParametersIntoRequest(path.substring(comma + 1));
Affects Version/s: (was: 5.1.0.5)
5.3.3
> REOPEN TAP5-698 - PageTester's setupRequestFromURI incorrectly uses substring twice on same string
> --------------------------------------------------------------------------------------------------
>
> Key: TAP5-1936
> URL: https://issues.apache.org/jira/browse/TAP5-1936
> Project: Tapestry 5
> Issue Type: Bug
> Components: tapestry-test
> Affects Versions: 5.3.3
> Reporter: Denis Delangle
> Assignee: Howard M. Lewis Ship
>
> I get this error when clicking a link with parameters in PageTester
> java.lang.StringIndexOutOfBoundsException: String index out of range: -1
> at java.lang.String.substring(String.java:1937)
> at java.lang.String.substring(String.java:1904)
> at org.apache.tapestry5.test.PageTester.setupRequestFromURI(PageTester.java:345)
> That bug was corrected revision 896555 and put back revision 1185926.
> The correction is trivial but have been done twice, so the bug is
> still there.
> I submit a patch to correct it
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (TAP5-1936) REOPEN TAP5-698 - PageTester's
setupRequestFromURI incorrectly uses substring twice on same string
Posted by "Steve Eynon (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TAP5-1936?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13396640#comment-13396640 ]
Steve Eynon commented on TAP5-1936:
-----------------------------------
This is a duplicate of TAP5-1770 - https://issues.apache.org/jira/browse/TAP5-1770
Thanks for the patch file though!
> REOPEN TAP5-698 - PageTester's setupRequestFromURI incorrectly uses substring twice on same string
> --------------------------------------------------------------------------------------------------
>
> Key: TAP5-1936
> URL: https://issues.apache.org/jira/browse/TAP5-1936
> Project: Tapestry 5
> Issue Type: Bug
> Components: tapestry-test
> Affects Versions: 5.3.3
> Reporter: Denis Delangle
> Assignee: Howard M. Lewis Ship
> Attachments: patch-TAP5-1936.txt
>
>
> I get this error when clicking a link with parameters in PageTester
> java.lang.StringIndexOutOfBoundsException: String index out of range: -1
> at java.lang.String.substring(String.java:1937)
> at java.lang.String.substring(String.java:1904)
> at org.apache.tapestry5.test.PageTester.setupRequestFromURI(PageTester.java:345)
> That bug was corrected revision 896555 and put back revision 1185926.
> The correction is trivial but have been done twice, so the bug is
> still there.
> I submit a patch to correct it
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (TAP5-1936) REOPEN TAP5-698 - PageTester's
setupRequestFromURI incorrectly uses substring twice on same string
Posted by "Denis Delangle (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TAP5-1936?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Denis Delangle updated TAP5-1936:
---------------------------------
Attachment: patch-TAP5-1936.txt
> REOPEN TAP5-698 - PageTester's setupRequestFromURI incorrectly uses substring twice on same string
> --------------------------------------------------------------------------------------------------
>
> Key: TAP5-1936
> URL: https://issues.apache.org/jira/browse/TAP5-1936
> Project: Tapestry 5
> Issue Type: Bug
> Components: tapestry-test
> Affects Versions: 5.3.3
> Reporter: Denis Delangle
> Assignee: Howard M. Lewis Ship
> Attachments: patch-TAP5-1936.txt
>
>
> I get this error when clicking a link with parameters in PageTester
> java.lang.StringIndexOutOfBoundsException: String index out of range: -1
> at java.lang.String.substring(String.java:1937)
> at java.lang.String.substring(String.java:1904)
> at org.apache.tapestry5.test.PageTester.setupRequestFromURI(PageTester.java:345)
> That bug was corrected revision 896555 and put back revision 1185926.
> The correction is trivial but have been done twice, so the bug is
> still there.
> I submit a patch to correct it
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Comment Edited] (TAP5-1936) REOPEN TAP5-698 - PageTester's
setupRequestFromURI incorrectly uses substring twice on same string
Posted by "Steve Eynon (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TAP5-1936?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13396640#comment-13396640 ]
Steve Eynon edited comment on TAP5-1936 at 6/19/12 10:08 AM:
-------------------------------------------------------------
This is a duplicate of TAP5-1770 - Thanks for the patch file though!
was (Author: slimerdude):
This is a duplicate of TAP5-1770 - https://issues.apache.org/jira/browse/TAP5-1770
Thanks for the patch file though!
> REOPEN TAP5-698 - PageTester's setupRequestFromURI incorrectly uses substring twice on same string
> --------------------------------------------------------------------------------------------------
>
> Key: TAP5-1936
> URL: https://issues.apache.org/jira/browse/TAP5-1936
> Project: Tapestry 5
> Issue Type: Bug
> Components: tapestry-test
> Affects Versions: 5.3.3
> Reporter: Denis Delangle
> Assignee: Howard M. Lewis Ship
> Attachments: patch-TAP5-1936.txt
>
>
> I get this error when clicking a link with parameters in PageTester
> java.lang.StringIndexOutOfBoundsException: String index out of range: -1
> at java.lang.String.substring(String.java:1937)
> at java.lang.String.substring(String.java:1904)
> at org.apache.tapestry5.test.PageTester.setupRequestFromURI(PageTester.java:345)
> That bug was corrected revision 896555 and put back revision 1185926.
> The correction is trivial but have been done twice, so the bug is
> still there.
> I submit a patch to correct it
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira