You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mynewt.apache.org by GitBox <gi...@apache.org> on 2021/04/09 08:21:26 UTC
[GitHub] [mynewt-nimble] kasjer opened a new pull request #963: [RFC] targets: Add sample target for controller on NRF5340 bsp
kasjer opened a new pull request #963:
URL: https://github.com/apache/mynewt-nimble/pull/963
This adds sample target for building NimBLE controller (blehci app)
for Nordic NRF5340. It is used by default when combine image build
is used for nordic_pca10095 bsp.
Sample target should be used as a base for creating customized targets.
This targets nordic_pca10095_net bsp, custom targets should point to
appropriate BSP.
### Warning !!!
This target in this form is full of random settings accumulated over time
It would be good if @andrzej-kaczmarek or @sjanc of @rymanluk could
help with keeping only sensible stuff here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [mynewt-nimble] apache-mynewt-bot removed a comment on pull request #963: targets: Add sample target for controller on NRF5340 bsp
Posted by GitBox <gi...@apache.org>.
apache-mynewt-bot removed a comment on pull request #963:
URL: https://github.com/apache/mynewt-nimble/pull/963#issuecomment-820444879
<!-- style-bot -->
## Style check summary
#### No suggestions at this time!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [mynewt-nimble] sjanc commented on a change in pull request #963: targets: Add sample target for controller on NRF5340 bsp
Posted by GitBox <gi...@apache.org>.
sjanc commented on a change in pull request #963:
URL: https://github.com/apache/mynewt-nimble/pull/963#discussion_r615885831
##########
File path: targets/nordic_pca10095-blehci/syscfg.yml
##########
@@ -0,0 +1,45 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+#
+
+syscfg.vals:
+ BLE_HCI_TRANSPORT: nrf5340
+
+ MSYS_1_BLOCK_COUNT: 12
+ MSYS_1_BLOCK_SIZE: 292
+ BLE_LL_CFG_FEAT_DATA_LEN_EXT: 1
+ BLE_LL_CFG_FEAT_LE_2M_PHY: 1
+ BLE_LL_CFG_FEAT_LE_CODED_PHY: 1
+ BLE_LL_CFG_FEAT_LL_PRIVACY: 1
+ BLE_LL_CFG_FEAT_CTRL_TO_HOST_FLOW_CONTROL: 1
+ BLE_LL_CONN_INIT_MAX_TX_BYTES: 251
+ BLE_LL_CONN_INIT_SLOTS: 4
+ BLE_LL_DTM: 1
+ BLE_LL_DTM_EXTENSIONS: 1
+ BLE_LL_VND_EVENT_ON_ASSERT: 1
+ BLE_MAX_CONNECTIONS: 5
+ BLE_EXT_ADV: 1
+ BLE_EXT_ADV_MAX_SIZE: 1650
+ BLE_MAX_PERIODIC_SYNCS: 5
+ BLE_MULTI_ADV_INSTANCES: 5
+ BLE_PERIODIC_ADV: 1
+ BLE_PERIODIC_ADV_SYNC_TRANSFER: 1
+ BLE_VERSION: 51
+
+ # TODO: remove once IPC fix is merged
Review comment:
HCI transport is fixed now and doesn't require this anymore, otherwise looks good
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [mynewt-nimble] sjanc commented on pull request #963: [RFC] targets: Add sample target for controller on NRF5340 bsp
Posted by GitBox <gi...@apache.org>.
sjanc commented on pull request #963:
URL: https://github.com/apache/mynewt-nimble/pull/963#issuecomment-820206685
MSYS_1_BLOCK_COUNT: 12
MSYS_1_BLOCK_SIZE: 292
BLE_LL_CFG_FEAT_DATA_LEN_EXT: 1
BLE_LL_CFG_FEAT_LE_2M_PHY: 1
BLE_LL_CFG_FEAT_LE_CODED_PHY: 1
BLE_LL_CFG_FEAT_LL_PRIVACY: 1
BLE_LL_CFG_FEAT_CTRL_TO_HOST_FLOW_CONTROL: 1
BLE_LL_CONN_INIT_MAX_TX_BYTES: 251
BLE_LL_CONN_INIT_SLOTS: 4
BLE_LL_DTM: 1
BLE_LL_DTM_EXTENSIONS: 1
BLE_LL_VND_EVENT_ON_ASSERT: 1
BLE_MAX_CONNECTIONS: 5
BLE_EXT_ADV: 1
BLE_EXT_ADV_MAX_SIZE: 1650
BLE_MAX_PERIODIC_SYNCS: 5
BLE_MULTI_ADV_INSTANCES: 5
BLE_PERIODIC_ADV: 1
BLE_PERIODIC_ADV_SYNC_TRANSFER: 1
BLE_HCI_TRANSPORT: nrf5340
BLE_VERSION: 51
This is config I'm using for testing, since we have plenty of RAM just for netcore we can be generous with MSYS configuration :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [mynewt-nimble] kasjer commented on pull request #963: [RFC] targets: Add sample target for controller on NRF5340 bsp
Posted by GitBox <gi...@apache.org>.
kasjer commented on pull request #963:
URL: https://github.com/apache/mynewt-nimble/pull/963#issuecomment-816541765
> since nrf53 has dedicated core and flash for radio, I'd go with full scale controller here, so enable all features supported:)
Is there a setting like ENABLE_ALL_FEATURES: 1 to be used in this case?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [mynewt-nimble] kasjer commented on pull request #963: targets: Add sample target for controller on NRF5340 bsp
Posted by GitBox <gi...@apache.org>.
kasjer commented on pull request #963:
URL: https://github.com/apache/mynewt-nimble/pull/963#issuecomment-820392565
Settings recommended by @sjanc applied.
Added on setting that can be removed later
```yml
IPC_NRF5340_BUF_SZ: 1024
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [mynewt-nimble] apache-mynewt-bot commented on pull request #963: targets: Add sample target for controller on NRF5340 bsp
Posted by GitBox <gi...@apache.org>.
apache-mynewt-bot commented on pull request #963:
URL: https://github.com/apache/mynewt-nimble/pull/963#issuecomment-820444879
<!-- style-bot -->
## Style check summary
#### No suggestions at this time!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [mynewt-nimble] apache-mynewt-bot commented on pull request #963: [RFC] targets: Add sample target for controller on NRF5340 bsp
Posted by GitBox <gi...@apache.org>.
apache-mynewt-bot commented on pull request #963:
URL: https://github.com/apache/mynewt-nimble/pull/963#issuecomment-816570593
<!-- style-bot -->
## Style check summary
#### No suggestions at this time!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [mynewt-nimble] apache-mynewt-bot commented on pull request #963: targets: Add sample target for controller on NRF5340 bsp
Posted by GitBox <gi...@apache.org>.
apache-mynewt-bot commented on pull request #963:
URL: https://github.com/apache/mynewt-nimble/pull/963#issuecomment-827563876
<!-- style-bot -->
## Style check summary
#### No suggestions at this time!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [mynewt-nimble] sjanc commented on pull request #963: [RFC] targets: Add sample target for controller on NRF5340 bsp
Posted by GitBox <gi...@apache.org>.
sjanc commented on pull request #963:
URL: https://github.com/apache/mynewt-nimble/pull/963#issuecomment-816526391
since nrf53 has dedicated core and flash for radio, I'd go with full scale controller here, so enable all features supported:)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [mynewt-nimble] apache-mynewt-bot removed a comment on pull request #963: targets: Add sample target for controller on NRF5340 bsp
Posted by GitBox <gi...@apache.org>.
apache-mynewt-bot removed a comment on pull request #963:
URL: https://github.com/apache/mynewt-nimble/pull/963#issuecomment-816570593
<!-- style-bot -->
## Style check summary
#### No suggestions at this time!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [mynewt-nimble] kasjer merged pull request #963: targets: Add sample target for controller on NRF5340 bsp
Posted by GitBox <gi...@apache.org>.
kasjer merged pull request #963:
URL: https://github.com/apache/mynewt-nimble/pull/963
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org