You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/04/03 03:33:49 UTC
[GitHub] [flink] wsry commented on a change in pull request #11567:
[FLINK-16645] Limit the maximum backlogs in subpartitions
wsry commented on a change in pull request #11567: [FLINK-16645] Limit the maximum backlogs in subpartitions
URL: https://github.com/apache/flink/pull/11567#discussion_r402718422
##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/PipelinedSubpartition.java
##########
@@ -342,6 +342,7 @@ private void decreaseBuffersInBacklogUnsafe(boolean isBuffer) {
assert Thread.holdsLock(buffers);
if (isBuffer) {
buffersInBacklog--;
+ parent.notifyDecreaseBacklog(buffersInBacklog);
Review comment:
the above two lines can be replaced with:
```parent.notifyDecreaseBacklog(--buffersInBacklog);```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services