[GitHub] [spark] srowen commented on a change in pull request #24101: [CORE][MINOR] Correct the comment to show heartbeat interval is configurable

[GitBox <gi...@apache.org>]

srowen commented on a change in pull request #24101: [CORE][MINOR] Correct the comment to show heartbeat interval is configurable
URL: https://github.com/apache/spark/pull/24101#discussion_r265896612
 
 

 ##########
 File path: core/src/main/scala/org/apache/spark/executor/Executor.scala
 ##########
 @@ -176,7 +176,7 @@ private[spark] class Executor(
   /**
    * When an executor is unable to send heartbeats to the driver more than `HEARTBEAT_MAX_FAILURES`
    * times, it should kill itself. The default value is 60. It means we will retry to send
-   * heartbeats about 10 minutes because the heartbeat interval is 10s.
+   * heartbeats about 10 minutes if the heartbeat interval is set to 10s or left default(10s).
 
 Review comment:
   I think the sentence still has problems. How about: "For example, if max failures is 60 and heartbeat interval is 10s, then it will try to send heartbeats for up to 600s (10 minutes)."

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org