You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Robert Levas <rl...@hortonworks.com> on 2014/11/21 22:57:53 UTC
Re: Review Request 28095: Add Security State to Ambari database
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28095/
-----------------------------------------------------------
(Updated Nov. 21, 2014, 4:57 p.m.)
Review request for Ambari, dilli dorai, Jonathan Hurley, John Speidel, Robert Nettleton, Sid Wagle, and Tom Beerbower.
Changes
-------
Updated title and description based on review comments.
Summary (updated)
-----------------
Add Security State to Ambari database
Bugs: AMBARI-8336
https://issues.apache.org/jira/browse/AMBARI-8336
Repository: ambari
Description (updated)
-------
In order to track which services and components have been or need to be secured, several tables need to be updated with a `security_state` column to contain one the following values:
* `UNKNOWN` - Indicates that it is not known whether the service or component is secured or not
* `UNSECURED` - Indicates service or component is not or should not be secured
* `SECURED_KERBEROS` - Indicates component is or should be secured using Kerberos
* `SECURING` - Indicates the component is in the process of being secured
* `UNSECURING` - Indicates the component is in the process of being unsecured
* `ERROR` - Indicates the component is not secured due to an error condition
The following tables need to be updated:
* `hostcomponentdesiredstate` - To indicate whether the component needs security added or removed
* `hostcomponentstate` - To indicate whether the component is currently configured for security or not
* `servicedesiredstate` - To indicate whether the service (and it components) should or should not be secured
Diffs
-----
ambari-server/src/main/java/org/apache/ambari/server/orm/entities/HostComponentDesiredStateEntity.java 610f77f
ambari-server/src/main/java/org/apache/ambari/server/orm/entities/HostComponentStateEntity.java 81de777
ambari-server/src/main/java/org/apache/ambari/server/orm/entities/ServiceDesiredStateEntity.java a74b021
ambari-server/src/main/java/org/apache/ambari/server/state/ComponentKerberosState.java PRE-CREATION
ambari-server/src/main/java/org/apache/ambari/server/state/Service.java 4a18c69
ambari-server/src/main/java/org/apache/ambari/server/state/ServiceComponentHost.java 3142974
ambari-server/src/main/java/org/apache/ambari/server/state/ServiceImpl.java 4b4a305
ambari-server/src/main/java/org/apache/ambari/server/state/ServiceKerberosState.java PRE-CREATION
ambari-server/src/main/java/org/apache/ambari/server/state/svccomphost/ServiceComponentHostImpl.java 606751d
ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog200.java 45e7813
ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql b2d9221
ambari-server/src/main/resources/Ambari-DDL-Oracle-CREATE.sql 50f02b8
ambari-server/src/main/resources/Ambari-DDL-Postgres-CREATE.sql d865161
ambari-server/src/main/resources/Ambari-DDL-Postgres-EMBEDDED-CREATE.sql 2e110ce
ambari-server/src/main/resources/Ambari-DDL-SQLServer-CREATE.sql d1b6435
ambari-server/src/test/java/org/apache/ambari/server/state/ServiceTest.java 493291d
ambari-server/src/test/java/org/apache/ambari/server/state/svccomphost/ServiceComponentHostTest.java 5410ee3
ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog200Test.java 6a5bab7
Diff: https://reviews.apache.org/r/28095/diff/
Testing
-------
Java Unit Tests:
Tests run: 2250, Failures: 0, Errors: 0, Skipped: 14
Manual tests to verifty tables are altered and values are updated.
Thanks,
Robert Levas
Re: Review Request 28095: Add Security State to Ambari database
Posted by Alejandro Fernandez <af...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28095/#review62815
-----------------------------------------------------------
Ship it!
Ship It!
- Alejandro Fernandez
On Nov. 24, 2014, 4:37 p.m., Robert Levas wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28095/
> -----------------------------------------------------------
>
> (Updated Nov. 24, 2014, 4:37 p.m.)
>
>
> Review request for Ambari, dilli dorai, Jonathan Hurley, John Speidel, Robert Nettleton, Sid Wagle, and Tom Beerbower.
>
>
> Bugs: AMBARI-8336
> https://issues.apache.org/jira/browse/AMBARI-8336
>
>
> Repository: ambari
>
>
> Description
> -------
>
> In order to track which services and components have been or need to be secured, several tables need to be updated with a `security_state` column to contain one the following values:
>
> * `UNKNOWN` - Indicates that it is not known whether the service or component is secured or not
> * `UNSECURED` - Indicates service or component is not or should not be secured
> * `SECURED_KERBEROS` - Indicates component is or should be secured using Kerberos
> * `SECURING` - Indicates the component is in the process of being secured
> * `UNSECURING` - Indicates the component is in the process of being unsecured
> * `ERROR` - Indicates the component is not secured due to an error condition
>
> The following tables need to be updated:
>
> * `hostcomponentdesiredstate` - To indicate whether the component needs security added or removed
> * `hostcomponentstate` - To indicate whether the component is currently configured for security or not
> * `servicedesiredstate` - To indicate whether the service (and it components) should or should not be secured
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/HostComponentDesiredStateEntity.java 610f77f
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/HostComponentStateEntity.java 81de777
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/ServiceDesiredStateEntity.java a74b021
> ambari-server/src/main/java/org/apache/ambari/server/state/SecurityState.java PRE-CREATION
> ambari-server/src/main/java/org/apache/ambari/server/state/Service.java 4a18c69
> ambari-server/src/main/java/org/apache/ambari/server/state/ServiceComponentHost.java 3142974
> ambari-server/src/main/java/org/apache/ambari/server/state/ServiceImpl.java 4b4a305
> ambari-server/src/main/java/org/apache/ambari/server/state/svccomphost/ServiceComponentHostImpl.java 606751d
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog200.java b5556ed
> ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql edcaa50
> ambari-server/src/main/resources/Ambari-DDL-Oracle-CREATE.sql 8ab0619
> ambari-server/src/main/resources/Ambari-DDL-Postgres-CREATE.sql a918f22
> ambari-server/src/main/resources/Ambari-DDL-Postgres-EMBEDDED-CREATE.sql 2e7aa07
> ambari-server/src/main/resources/Ambari-DDL-SQLServer-CREATE.sql e3e3414
> ambari-server/src/test/java/org/apache/ambari/server/state/ServiceTest.java 493291d
> ambari-server/src/test/java/org/apache/ambari/server/state/svccomphost/ServiceComponentHostTest.java aa7aab5
> ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog200Test.java be9c9bf
>
> Diff: https://reviews.apache.org/r/28095/diff/
>
>
> Testing
> -------
>
> Java Unit Tests:
> Tests run: 2279, Failures: 0, Errors: 0, Skipped: 14
>
> Manual tests to verifty tables are altered and values are updated.
>
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 38:38 min
> [INFO] Finished at: 2014-11-22T00:11:22+00:00
> [INFO] Final Memory: 43M/439M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Robert Levas
>
>
Re: Review Request 28095: Add Security State to Ambari database
Posted by Robert Nettleton <rn...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28095/#review62811
-----------------------------------------------------------
Merged patch into trunk after successfully running the ambari-server unit tests:
Tests run: 2279, Failures: 0, Errors: 0, Skipped: 14
- Robert Nettleton
On Nov. 24, 2014, 4:37 p.m., Robert Levas wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28095/
> -----------------------------------------------------------
>
> (Updated Nov. 24, 2014, 4:37 p.m.)
>
>
> Review request for Ambari, dilli dorai, Jonathan Hurley, John Speidel, Robert Nettleton, Sid Wagle, and Tom Beerbower.
>
>
> Bugs: AMBARI-8336
> https://issues.apache.org/jira/browse/AMBARI-8336
>
>
> Repository: ambari
>
>
> Description
> -------
>
> In order to track which services and components have been or need to be secured, several tables need to be updated with a `security_state` column to contain one the following values:
>
> * `UNKNOWN` - Indicates that it is not known whether the service or component is secured or not
> * `UNSECURED` - Indicates service or component is not or should not be secured
> * `SECURED_KERBEROS` - Indicates component is or should be secured using Kerberos
> * `SECURING` - Indicates the component is in the process of being secured
> * `UNSECURING` - Indicates the component is in the process of being unsecured
> * `ERROR` - Indicates the component is not secured due to an error condition
>
> The following tables need to be updated:
>
> * `hostcomponentdesiredstate` - To indicate whether the component needs security added or removed
> * `hostcomponentstate` - To indicate whether the component is currently configured for security or not
> * `servicedesiredstate` - To indicate whether the service (and it components) should or should not be secured
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/HostComponentDesiredStateEntity.java 610f77f
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/HostComponentStateEntity.java 81de777
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/ServiceDesiredStateEntity.java a74b021
> ambari-server/src/main/java/org/apache/ambari/server/state/SecurityState.java PRE-CREATION
> ambari-server/src/main/java/org/apache/ambari/server/state/Service.java 4a18c69
> ambari-server/src/main/java/org/apache/ambari/server/state/ServiceComponentHost.java 3142974
> ambari-server/src/main/java/org/apache/ambari/server/state/ServiceImpl.java 4b4a305
> ambari-server/src/main/java/org/apache/ambari/server/state/svccomphost/ServiceComponentHostImpl.java 606751d
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog200.java b5556ed
> ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql edcaa50
> ambari-server/src/main/resources/Ambari-DDL-Oracle-CREATE.sql 8ab0619
> ambari-server/src/main/resources/Ambari-DDL-Postgres-CREATE.sql a918f22
> ambari-server/src/main/resources/Ambari-DDL-Postgres-EMBEDDED-CREATE.sql 2e7aa07
> ambari-server/src/main/resources/Ambari-DDL-SQLServer-CREATE.sql e3e3414
> ambari-server/src/test/java/org/apache/ambari/server/state/ServiceTest.java 493291d
> ambari-server/src/test/java/org/apache/ambari/server/state/svccomphost/ServiceComponentHostTest.java aa7aab5
> ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog200Test.java be9c9bf
>
> Diff: https://reviews.apache.org/r/28095/diff/
>
>
> Testing
> -------
>
> Java Unit Tests:
> Tests run: 2279, Failures: 0, Errors: 0, Skipped: 14
>
> Manual tests to verifty tables are altered and values are updated.
>
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 38:38 min
> [INFO] Finished at: 2014-11-22T00:11:22+00:00
> [INFO] Final Memory: 43M/439M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Robert Levas
>
>
Re: Review Request 28095: Add Security State to Ambari database
Posted by Robert Levas <rl...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28095/
-----------------------------------------------------------
(Updated Nov. 24, 2014, 11:37 a.m.)
Review request for Ambari, dilli dorai, Jonathan Hurley, John Speidel, Robert Nettleton, Sid Wagle, and Tom Beerbower.
Changes
-------
Removed whitespace due to the following git error condition: `new blank line at EOF`
Bugs: AMBARI-8336
https://issues.apache.org/jira/browse/AMBARI-8336
Repository: ambari
Description
-------
In order to track which services and components have been or need to be secured, several tables need to be updated with a `security_state` column to contain one the following values:
* `UNKNOWN` - Indicates that it is not known whether the service or component is secured or not
* `UNSECURED` - Indicates service or component is not or should not be secured
* `SECURED_KERBEROS` - Indicates component is or should be secured using Kerberos
* `SECURING` - Indicates the component is in the process of being secured
* `UNSECURING` - Indicates the component is in the process of being unsecured
* `ERROR` - Indicates the component is not secured due to an error condition
The following tables need to be updated:
* `hostcomponentdesiredstate` - To indicate whether the component needs security added or removed
* `hostcomponentstate` - To indicate whether the component is currently configured for security or not
* `servicedesiredstate` - To indicate whether the service (and it components) should or should not be secured
Diffs (updated)
-----
ambari-server/src/main/java/org/apache/ambari/server/orm/entities/HostComponentDesiredStateEntity.java 610f77f
ambari-server/src/main/java/org/apache/ambari/server/orm/entities/HostComponentStateEntity.java 81de777
ambari-server/src/main/java/org/apache/ambari/server/orm/entities/ServiceDesiredStateEntity.java a74b021
ambari-server/src/main/java/org/apache/ambari/server/state/SecurityState.java PRE-CREATION
ambari-server/src/main/java/org/apache/ambari/server/state/Service.java 4a18c69
ambari-server/src/main/java/org/apache/ambari/server/state/ServiceComponentHost.java 3142974
ambari-server/src/main/java/org/apache/ambari/server/state/ServiceImpl.java 4b4a305
ambari-server/src/main/java/org/apache/ambari/server/state/svccomphost/ServiceComponentHostImpl.java 606751d
ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog200.java b5556ed
ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql edcaa50
ambari-server/src/main/resources/Ambari-DDL-Oracle-CREATE.sql 8ab0619
ambari-server/src/main/resources/Ambari-DDL-Postgres-CREATE.sql a918f22
ambari-server/src/main/resources/Ambari-DDL-Postgres-EMBEDDED-CREATE.sql 2e7aa07
ambari-server/src/main/resources/Ambari-DDL-SQLServer-CREATE.sql e3e3414
ambari-server/src/test/java/org/apache/ambari/server/state/ServiceTest.java 493291d
ambari-server/src/test/java/org/apache/ambari/server/state/svccomphost/ServiceComponentHostTest.java aa7aab5
ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog200Test.java be9c9bf
Diff: https://reviews.apache.org/r/28095/diff/
Testing
-------
Java Unit Tests:
Tests run: 2279, Failures: 0, Errors: 0, Skipped: 14
Manual tests to verifty tables are altered and values are updated.
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 38:38 min
[INFO] Finished at: 2014-11-22T00:11:22+00:00
[INFO] Final Memory: 43M/439M
[INFO] ------------------------------------------------------------------------
Thanks,
Robert Levas
Re: Review Request 28095: Add Security State to Ambari database
Posted by Robert Levas <rl...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28095/
-----------------------------------------------------------
(Updated Nov. 21, 2014, 8:49 p.m.)
Review request for Ambari, dilli dorai, Jonathan Hurley, John Speidel, Robert Nettleton, Sid Wagle, and Tom Beerbower.
Bugs: AMBARI-8336
https://issues.apache.org/jira/browse/AMBARI-8336
Repository: ambari
Description
-------
In order to track which services and components have been or need to be secured, several tables need to be updated with a `security_state` column to contain one the following values:
* `UNKNOWN` - Indicates that it is not known whether the service or component is secured or not
* `UNSECURED` - Indicates service or component is not or should not be secured
* `SECURED_KERBEROS` - Indicates component is or should be secured using Kerberos
* `SECURING` - Indicates the component is in the process of being secured
* `UNSECURING` - Indicates the component is in the process of being unsecured
* `ERROR` - Indicates the component is not secured due to an error condition
The following tables need to be updated:
* `hostcomponentdesiredstate` - To indicate whether the component needs security added or removed
* `hostcomponentstate` - To indicate whether the component is currently configured for security or not
* `servicedesiredstate` - To indicate whether the service (and it components) should or should not be secured
Diffs
-----
ambari-server/src/main/java/org/apache/ambari/server/orm/entities/HostComponentDesiredStateEntity.java 610f77f
ambari-server/src/main/java/org/apache/ambari/server/orm/entities/HostComponentStateEntity.java 81de777
ambari-server/src/main/java/org/apache/ambari/server/orm/entities/ServiceDesiredStateEntity.java a74b021
ambari-server/src/main/java/org/apache/ambari/server/state/SecurityState.java PRE-CREATION
ambari-server/src/main/java/org/apache/ambari/server/state/Service.java 4a18c69
ambari-server/src/main/java/org/apache/ambari/server/state/ServiceComponentHost.java 3142974
ambari-server/src/main/java/org/apache/ambari/server/state/ServiceImpl.java 4b4a305
ambari-server/src/main/java/org/apache/ambari/server/state/svccomphost/ServiceComponentHostImpl.java 606751d
ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog200.java b5556ed
ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql edcaa50
ambari-server/src/main/resources/Ambari-DDL-Oracle-CREATE.sql 8ab0619
ambari-server/src/main/resources/Ambari-DDL-Postgres-CREATE.sql a918f22
ambari-server/src/main/resources/Ambari-DDL-Postgres-EMBEDDED-CREATE.sql 2e7aa07
ambari-server/src/main/resources/Ambari-DDL-SQLServer-CREATE.sql e3e3414
ambari-server/src/test/java/org/apache/ambari/server/state/ServiceTest.java 493291d
ambari-server/src/test/java/org/apache/ambari/server/state/svccomphost/ServiceComponentHostTest.java aa7aab5
ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog200Test.java be9c9bf
Diff: https://reviews.apache.org/r/28095/diff/
Testing (updated)
-------
Java Unit Tests:
Tests run: 2279, Failures: 0, Errors: 0, Skipped: 14
Manual tests to verifty tables are altered and values are updated.
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 38:38 min
[INFO] Finished at: 2014-11-22T00:11:22+00:00
[INFO] Final Memory: 43M/439M
[INFO] ------------------------------------------------------------------------
Thanks,
Robert Levas
Re: Review Request 28095: Add Security State to Ambari database
Posted by Robert Levas <rl...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28095/
-----------------------------------------------------------
(Updated Nov. 21, 2014, 8:46 p.m.)
Review request for Ambari, dilli dorai, Jonathan Hurley, John Speidel, Robert Nettleton, Sid Wagle, and Tom Beerbower.
Changes
-------
Updated due to review comments.
* Changed Kerberos state to more general security state
* Updated state values to allow for different security types (i.e, `SECURED_KERBEROS`)
* Updated state values to allow for transitional states (`SECURING`, `UNSECURING`)
Bugs: AMBARI-8336
https://issues.apache.org/jira/browse/AMBARI-8336
Repository: ambari
Description
-------
In order to track which services and components have been or need to be secured, several tables need to be updated with a `security_state` column to contain one the following values:
* `UNKNOWN` - Indicates that it is not known whether the service or component is secured or not
* `UNSECURED` - Indicates service or component is not or should not be secured
* `SECURED_KERBEROS` - Indicates component is or should be secured using Kerberos
* `SECURING` - Indicates the component is in the process of being secured
* `UNSECURING` - Indicates the component is in the process of being unsecured
* `ERROR` - Indicates the component is not secured due to an error condition
The following tables need to be updated:
* `hostcomponentdesiredstate` - To indicate whether the component needs security added or removed
* `hostcomponentstate` - To indicate whether the component is currently configured for security or not
* `servicedesiredstate` - To indicate whether the service (and it components) should or should not be secured
Diffs (updated)
-----
ambari-server/src/main/java/org/apache/ambari/server/orm/entities/HostComponentDesiredStateEntity.java 610f77f
ambari-server/src/main/java/org/apache/ambari/server/orm/entities/HostComponentStateEntity.java 81de777
ambari-server/src/main/java/org/apache/ambari/server/orm/entities/ServiceDesiredStateEntity.java a74b021
ambari-server/src/main/java/org/apache/ambari/server/state/SecurityState.java PRE-CREATION
ambari-server/src/main/java/org/apache/ambari/server/state/Service.java 4a18c69
ambari-server/src/main/java/org/apache/ambari/server/state/ServiceComponentHost.java 3142974
ambari-server/src/main/java/org/apache/ambari/server/state/ServiceImpl.java 4b4a305
ambari-server/src/main/java/org/apache/ambari/server/state/svccomphost/ServiceComponentHostImpl.java 606751d
ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog200.java b5556ed
ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql edcaa50
ambari-server/src/main/resources/Ambari-DDL-Oracle-CREATE.sql 8ab0619
ambari-server/src/main/resources/Ambari-DDL-Postgres-CREATE.sql a918f22
ambari-server/src/main/resources/Ambari-DDL-Postgres-EMBEDDED-CREATE.sql 2e7aa07
ambari-server/src/main/resources/Ambari-DDL-SQLServer-CREATE.sql e3e3414
ambari-server/src/test/java/org/apache/ambari/server/state/ServiceTest.java 493291d
ambari-server/src/test/java/org/apache/ambari/server/state/svccomphost/ServiceComponentHostTest.java aa7aab5
ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog200Test.java be9c9bf
Diff: https://reviews.apache.org/r/28095/diff/
Testing
-------
Java Unit Tests:
Tests run: 2250, Failures: 0, Errors: 0, Skipped: 14
Manual tests to verifty tables are altered and values are updated.
Thanks,
Robert Levas