You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "lidavidm (via GitHub)" <gi...@apache.org> on 2024/07/05 07:52:42 UTC
[PR] fix(dev/release): update C# tag [arrow-adbc]
lidavidm opened a new pull request, #1973:
URL: https://github.com/apache/arrow-adbc/pull/1973
Fixes #1968.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(dev/release): update C# tag [arrow-adbc]
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou merged PR #1973:
URL: https://github.com/apache/arrow-adbc/pull/1973
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(dev/release): update C# tag [arrow-adbc]
Posted by "lidavidm (via GitHub)" <gi...@apache.org>.
lidavidm commented on code in PR #1973:
URL: https://github.com/apache/arrow-adbc/pull/1973#discussion_r1666709498
##########
dev/release/utils-prepare.sh:
##########
@@ -79,6 +81,8 @@ update_versions() {
sed -i.bak -E "s|<VersionPrefix>.+</VersionPrefix>|<VersionPrefix>${csharp_version}</VersionPrefix>|" "${ADBC_DIR}/csharp/Directory.Build.props"
rm "${ADBC_DIR}/csharp/Directory.Build.props.bak"
+ sed -i.bak -E "s|<VersionSuffix>.+</VersionSuffix>|<VersionSuffix>${csharp_suffix}</VersionSuffix>|" "${ADBC_DIR}/csharp/Directory.Build.props"
+ rm "${ADBC_DIR}/csharp/Directory.Build.props.bak"
Review Comment:
Oh cool, I didn't realize you could do that!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(dev/release): update C# tag [arrow-adbc]
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou commented on code in PR #1973:
URL: https://github.com/apache/arrow-adbc/pull/1973#discussion_r1666568433
##########
dev/release/utils-prepare.sh:
##########
@@ -79,6 +81,8 @@ update_versions() {
sed -i.bak -E "s|<VersionPrefix>.+</VersionPrefix>|<VersionPrefix>${csharp_version}</VersionPrefix>|" "${ADBC_DIR}/csharp/Directory.Build.props"
rm "${ADBC_DIR}/csharp/Directory.Build.props.bak"
+ sed -i.bak -E "s|<VersionSuffix>.+</VersionSuffix>|<VersionSuffix>${csharp_suffix}</VersionSuffix>|" "${ADBC_DIR}/csharp/Directory.Build.props"
+ rm "${ADBC_DIR}/csharp/Directory.Build.props.bak"
Review Comment:
```suggestion
sed -i.bak \
-E "s|<VersionPrefix>.+</VersionPrefix>|<VersionPrefix>${csharp_version}</VersionPrefix>|" \
-E "s|<VersionSuffix>.+</VersionSuffix>|<VersionSuffix>${csharp_suffix}</VersionSuffix>|" \
"${ADBC_DIR}/csharp/Directory.Build.props"
rm "${ADBC_DIR}/csharp/Directory.Build.props.bak"
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org