You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@commons.apache.org by gg...@apache.org on 2019/02/24 15:10:10 UTC
[commons-csv] branch master updated: Use try-with-resources.
This is an automated email from the ASF dual-hosted git repository.
ggregory pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/commons-csv.git
The following commit(s) were added to refs/heads/master by this push:
new 4e02db1 Use try-with-resources.
4e02db1 is described below
commit 4e02db1272c2f47c4c4a3746f557d28646e77abc
Author: Gary Gregory <ga...@gmail.com>
AuthorDate: Sun Feb 24 10:10:09 2019 -0500
Use try-with-resources.
---
.../apache/commons/csv/issues/JiraCsv203Test.java | 44 +++++++++++-----------
1 file changed, 22 insertions(+), 22 deletions(-)
diff --git a/src/test/java/org/apache/commons/csv/issues/JiraCsv203Test.java b/src/test/java/org/apache/commons/csv/issues/JiraCsv203Test.java
index bff193b..847f05e 100644
--- a/src/test/java/org/apache/commons/csv/issues/JiraCsv203Test.java
+++ b/src/test/java/org/apache/commons/csv/issues/JiraCsv203Test.java
@@ -35,9 +35,9 @@ public class JiraCsv203Test {
.withQuoteMode(QuoteMode.ALL);
final StringBuffer buffer = new StringBuffer();
- final CSVPrinter printer = new CSVPrinter(buffer, format);
- printer.printRecord(new Object[] { null, "Hello", null, "World" });
-
+ try (final CSVPrinter printer = new CSVPrinter(buffer, format)) {
+ printer.printRecord(new Object[] { null, "Hello", null, "World" });
+ }
Assert.assertEquals("\"N/A\",\"Hello\",\"N/A\",\"World\"\r\n", buffer.toString());
}
@@ -49,9 +49,9 @@ public class JiraCsv203Test {
.withQuoteMode(QuoteMode.ALL_NON_NULL);
final StringBuffer buffer = new StringBuffer();
- final CSVPrinter printer = new CSVPrinter(buffer, format);
- printer.printRecord(new Object[] { null, "Hello", null, "World" });
-
+ try (final CSVPrinter printer = new CSVPrinter(buffer, format)) {
+ printer.printRecord(new Object[] { null, "Hello", null, "World" });
+ }
Assert.assertEquals("N/A,\"Hello\",N/A,\"World\"\r\n", buffer.toString());
}
@@ -62,9 +62,9 @@ public class JiraCsv203Test {
.withIgnoreSurroundingSpaces(true);
final StringBuffer buffer = new StringBuffer();
- final CSVPrinter printer = new CSVPrinter(buffer, format);
- printer.printRecord(new Object[] { null, "Hello", null, "World" });
-
+ try (final CSVPrinter printer = new CSVPrinter(buffer, format)) {
+ printer.printRecord(new Object[] { null, "Hello", null, "World" });
+ }
Assert.assertEquals("N/A,Hello,N/A,World\r\n", buffer.toString());
}
@@ -76,9 +76,9 @@ public class JiraCsv203Test {
.withQuoteMode(QuoteMode.MINIMAL);
final StringBuffer buffer = new StringBuffer();
- final CSVPrinter printer = new CSVPrinter(buffer, format);
- printer.printRecord(new Object[] { null, "Hello", null, "World" });
-
+ try (final CSVPrinter printer = new CSVPrinter(buffer, format)) {
+ printer.printRecord(new Object[] { null, "Hello", null, "World" });
+ }
Assert.assertEquals("N/A,Hello,N/A,World\r\n", buffer.toString());
}
@@ -90,9 +90,9 @@ public class JiraCsv203Test {
.withQuoteMode(QuoteMode.NON_NUMERIC);
final StringBuffer buffer = new StringBuffer();
- final CSVPrinter printer = new CSVPrinter(buffer, format);
- printer.printRecord(new Object[] { null, "Hello", null, "World" });
-
+ try (final CSVPrinter printer = new CSVPrinter(buffer, format)) {
+ printer.printRecord(new Object[] { null, "Hello", null, "World" });
+ }
Assert.assertEquals("N/A,\"Hello\",N/A,\"World\"\r\n", buffer.toString());
}
@@ -104,9 +104,9 @@ public class JiraCsv203Test {
.withQuoteMode(QuoteMode.ALL);
final StringBuffer buffer = new StringBuffer();
- final CSVPrinter printer = new CSVPrinter(buffer, format);
- printer.printRecord(new Object[] { null, "Hello", null, "World" });
-
+ try (final CSVPrinter printer = new CSVPrinter(buffer, format)) {
+ printer.printRecord(new Object[] { null, "Hello", null, "World" });
+ }
Assert.assertEquals(",\"Hello\",,\"World\"\r\n", buffer.toString());
}
@@ -118,10 +118,10 @@ public class JiraCsv203Test {
.withQuoteMode(QuoteMode.ALL);
final StringBuffer buffer = new StringBuffer();
- final CSVPrinter printer = new CSVPrinter(buffer, format);
- printer.printRecord(new Object[] { "", "Hello", "", "World" });
- //printer.printRecord(new Object[] { null, "Hello", null, "World" });
-
+ try (final CSVPrinter printer = new CSVPrinter(buffer, format)) {
+ printer.printRecord(new Object[] { "", "Hello", "", "World" });
+ //printer.printRecord(new Object[] { null, "Hello", null, "World" });
+ }
Assert.assertEquals("\"\",\"Hello\",\"\",\"World\"\r\n", buffer.toString());
}
}
\ No newline at end of file