You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by GitBox <gi...@apache.org> on 2021/04/02 06:44:06 UTC

[GitHub] [zeppelin] zjffdu opened a new pull request #4086: [ZEPPELIN-5243]. Get HIVE_CONF_DIR from enviroment in flink interpreter

zjffdu opened a new pull request #4086:
URL: https://github.com/apache/zeppelin/pull/4086


   ### What is this PR for?
   
   Trivial PR to get HIVE_CONF_DIR from environment variable in flink interpreter
   
   ### What type of PR is it?
   [Bug Fix]
   
   ### Todos
   * [ ] - Task
   
   ### What is the Jira issue?
   * https://issues.apache.org/jira/browse/ZEPPELIN-5243
   
   ### How should this be tested?
   * Ci pass
   
   ### Screenshots (if appropriate)
   
   ### Questions:
   * Does the licenses files need update? No
   * Is there breaking changes for older versions? No
   * Does this needs documentation? No
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [zeppelin] zjffdu closed pull request #4086: [ZEPPELIN-5243] Get HIVE_CONF_DIR from enviroment in flink interpreter

Posted by GitBox <gi...@apache.org>.
zjffdu closed pull request #4086:
URL: https://github.com/apache/zeppelin/pull/4086


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@zeppelin.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [zeppelin] cuspymd commented on a change in pull request #4086: [ZEPPELIN-5243]. Get HIVE_CONF_DIR from enviroment in flink interpreter

Posted by GitBox <gi...@apache.org>.
cuspymd commented on a change in pull request #4086:
URL: https://github.com/apache/zeppelin/pull/4086#discussion_r606174794



##########
File path: flink/interpreter/src/main/scala/org/apache/zeppelin/flink/FlinkScalaInterpreter.scala
##########
@@ -450,9 +450,9 @@ class FlinkScalaInterpreter(val properties: Properties) {
   }
 
   private def registerHiveCatalog(): Unit = {
-    val hiveConfDir =
-      properties.getOrDefault("HIVE_CONF_DIR", System.getenv("HIVE_CONF_DIR")).toString
-    if (hiveConfDir == null) {
+    val hiveConfDir = sys.env.getOrElse("HIVE_CONF_DIR",
+      properties.getProperty("HIVE_CONF_DIR", "")).toString

Review comment:
       The priority seems be changed between environment variable and property, is it intentional?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org