[jira] [Closed] (FLINK-11075) Remove redundant code path in CompatibilityUtil

["Tzu-Li (Gordon) Tai (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/FLINK-11075?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Tzu-Li (Gordon) Tai closed FLINK-11075.
---------------------------------------
    Resolution: Won't Fix

This ticket is no longer relevant now that CompatibilityUtil has been removed.

> Remove redundant code path in CompatibilityUtil
> -----------------------------------------------
>
>                 Key: FLINK-11075
>                 URL: https://issues.apache.org/jira/browse/FLINK-11075
>             Project: Flink
>          Issue Type: Improvement
>          Components: API / Type Serialization System
>            Reporter: Tzu-Li (Gordon) Tai
>            Assignee: Tzu-Li (Gordon) Tai
>            Priority: Major
>              Labels: pull-request-available
>             Fix For: 1.8.0
>
>          Time Spent: 10m
>  Remaining Estimate: 0h
>
> In {{CompatibilityUtil#resolveCompatibilityResult}}:
> {code:java}
> CompatibilityResult<T> initialResult = resolveCompatibilityResult(
>      (TypeSerializerSnapshot<T>) precedingSerializerConfigSnapshot,
>      newSerializer);
> if (!initialResult.isRequiresMigration()) {
>     return initialResult;
> } else {
>      if (precedingSerializer != null && !(precedingSerializer.getClass().equals(dummySerializerClassTag))) {         
>          // if the preceding serializer exists and is not a dummy, use
>          // that for converting instead of any provided convert deserializer
>         return CompatibilityResult.requiresMigration((TypeSerializer<T>) precedingSerializer);
>      } else {
>         // requires migration (may or may not have a convert deserializer)
>         return initialResult;
> }
> {code}
> {{initialResult}} can actually be returned already, since the case where we try to provide a convert deserializer is no longer relevant. We do not need to check if a convert deserializer is provided because that will never be the case.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)